diff mbox series

[rdma-next,v2,08/15] RDMA/core: Remove the kobject_uevent() NOP

Message ID 49231c92c7d4c60686de18f7e20932d0c82160ee.1623427137.git.leonro@nvidia.com (mailing list archive)
State New
Headers show
Series Reorganize sysfs file creation for struct ib_devices | expand

Commit Message

Leon Romanovsky June 11, 2021, 4 p.m. UTC
From: Jason Gunthorpe <jgg@nvidia.com>

This call does nothing because the ib_port kobj is nested under a struct
device kobject and the dev_uevent_filter() function of the struct device
blocks uevents for any children kobj's that are not also struct devices.

A uevent for the struct device will be triggered after
ib_setup_port_attrs() returns which causes udev to pick up all the deep
"attributes" which are implemented as kobjects nested under a struct
device and assign them to the udev object for the struct device:

 $ udevadm info -a /sys/class/infiniband/ibp0s9

Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
 drivers/infiniband/core/sysfs.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series


diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
index 07a00d3d3d44..14b838863b5d 100644
--- a/drivers/infiniband/core/sysfs.c
+++ b/drivers/infiniband/core/sysfs.c
@@ -1422,8 +1422,6 @@  int ib_setup_port_attrs(struct ib_core_device *coredev)
 			if (ret)
 				goto err_put;
-		kobject_uevent(&port->kobj, KOBJ_ADD);
 	return 0;