From patchwork Sun Jun 6 04:59:16 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Or Gerlitz X-Patchwork-Id: 104502 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o564xReW018961 for ; Sun, 6 Jun 2010 04:59:27 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751270Ab0FFE7W (ORCPT ); Sun, 6 Jun 2010 00:59:22 -0400 Received: from fwil.voltaire.com ([193.47.165.2]:37330 "EHLO exil.voltaire.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751211Ab0FFE7W (ORCPT ); Sun, 6 Jun 2010 00:59:22 -0400 Received: from zuben.voltaire.com ([172.25.5.1]) by exil.voltaire.com with Microsoft SMTPSVC(6.0.3790.4675); Sun, 6 Jun 2010 07:59:16 +0300 Message-ID: <4C0B2B24.6020304@Voltaire.com> Date: Sun, 06 Jun 2010 07:59:16 +0300 From: Or Gerlitz User-Agent: Thunderbird 2.0.0.19 (X11/20081209) MIME-Version: 1.0 To: Sumeet Lahorani , Roland Dreier CC: linux-rdma@vger.kernel.org Subject: Re: root owned writeable files under /sys References: <4C082598.8000809@oracle.com> In-Reply-To: <4C082598.8000809@oracle.com> X-OriginalArrivalTime: 06 Jun 2010 04:59:16.0850 (UTC) FILETIME=[03FCDD20:01CB0535] Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Sun, 06 Jun 2010 04:59:27 +0000 (UTC) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index df3eb8c..b4b2257 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c @@ -1163,7 +1163,7 @@ static ssize_t create_child(struct device *dev, return ret ? ret : count; } -static DEVICE_ATTR(create_child, S_IWUGO, NULL, create_child); +static DEVICE_ATTR(create_child, S_IWUSR, NULL, create_child); static ssize_t delete_child(struct device *dev, struct device_attribute *attr, @@ -1183,7 +1183,7 @@ static ssize_t delete_child(struct device *dev, return ret ? ret : count; } -static DEVICE_ATTR(delete_child, S_IWUGO, NULL, delete_child); +static DEVICE_ATTR(delete_child, S_IWUSR, NULL, delete_child); int ipoib_add_pkey_attr(struct net_device *dev) {