From patchwork Tue Sep 7 15:00:30 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yevgeny Kliteynik X-Patchwork-Id: 161111 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o87F0vGH032530 for ; Tue, 7 Sep 2010 15:00:57 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751910Ab0IGPA4 (ORCPT ); Tue, 7 Sep 2010 11:00:56 -0400 Received: from mail.mellanox.co.il ([194.90.237.43]:50774 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757330Ab0IGPA4 (ORCPT ); Tue, 7 Sep 2010 11:00:56 -0400 Received: from Internal Mail-Server by MTLPINE2 (envelope-from kliteyn@mellanox.co.il) with SMTP; 7 Sep 2010 18:00:13 +0300 Received: from [10.4.1.29] (10.4.1.29) by mtlmail01.mtl.com (10.0.8.12) with Microsoft SMTP Server id 8.2.254.0; Tue, 7 Sep 2010 18:00:30 +0300 Message-ID: <4C86538E.3080206@mellanox.co.il> Date: Tue, 7 Sep 2010 18:00:30 +0300 From: Yevgeny Kliteynik Reply-To: kliteyn@dev.mellanox.co.il User-Agent: Thunderbird 1.5.0.5 (X11/20060719) MIME-Version: 1.0 To: Sasha Khapyorsky , Linux RDMA Subject: [PATCH] opensm/osm_mesh.c: fixing a bug in compare_switches() Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Tue, 07 Sep 2010 15:00:57 +0000 (UTC) diff --git a/opensm/opensm/osm_mesh.c b/opensm/opensm/osm_mesh.c index 9d1082a..d156b7a 100644 --- a/opensm/opensm/osm_mesh.c +++ b/opensm/opensm/osm_mesh.c @@ -1385,7 +1385,8 @@ static int compare_switches(const void *p1, const void *p2) for (i = 0; i < ctx->mesh->dimension; i++) { j = ctx->mesh->dim_order[i]; - if ((ret = s1->node->coord[j] - s2->node->coord[j])); + ret = s1->node->coord[j] - s2->node->coord[j]; + if (ret) return ret; }