diff mbox

opensm/osm_subnet.c: fixing small bug in error path

Message ID 4C865486.4040909@mellanox.co.il (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Yevgeny Kliteynik Sept. 7, 2010, 3:04 p.m. UTC
None
diff mbox

Patch

diff --git a/opensm/opensm/osm_subnet.c b/opensm/opensm/osm_subnet.c
index d5c5ab2..149ab85 100644
--- a/opensm/opensm/osm_subnet.c
+++ b/opensm/opensm/osm_subnet.c
@@ -1163,8 +1163,10 @@  int osm_subn_parse_conf_file(char *file_name, osm_subn_opt_t * p_opts)
 	cl_log_event("OpenSM", CL_LOG_INFO, line, NULL, 0);

 	p_opts->config_file = file_name;
-	if (!p_opts->file_opts && !(p_opts->file_opts = malloc(sizeof(*p_opts))))
+	if (!p_opts->file_opts && !(p_opts->file_opts = malloc(sizeof(*p_opts)))) {
+		fclose(opts_file);
 		return -1;
+	}
 	memcpy(p_opts->file_opts, p_opts, sizeof(*p_opts));

 	while (fgets(line, 1023, opts_file) != NULL) {