diff mbox

opensm/osm_ucast_ftree.c: Fix some issues found by Coverity

Message ID 4DE4D13F.6050702@dev.mellanox.co.il (mailing list archive)
State Accepted
Delegated to: Alex Netes
Headers show

Commit Message

Hal Rosenstock May 31, 2011, 11:30 a.m. UTC
Signed-off-by: Hal Rosenstock <hal@mellanox.com>
---
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Alex Netes June 1, 2011, 4:24 p.m. UTC | #1
On 07:30 Tue 31 May     , Hal Rosenstock wrote:
> 
> Signed-off-by: Hal Rosenstock <hal@mellanox.com>
> ---

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/opensm/osm_ucast_ftree.c b/opensm/osm_ucast_ftree.c
index 51e252a..e7e7b8e 100644
--- a/opensm/osm_ucast_ftree.c
+++ b/opensm/osm_ucast_ftree.c
@@ -3281,7 +3281,7 @@  fabric_construct_hca_ports(IN ftree_fabric_t * p_ftree, IN ftree_hca_t * p_hca)
 		p_remote_node =
 		    osm_node_get_remote_node(p_node, i, &remote_port_num);
 
-		if (!p_remote_osm_port)
+		if (!p_remote_osm_port || !p_remote_node)
 			continue;
 
 		remote_node_type = osm_node_get_type(p_remote_node);
@@ -3420,6 +3420,8 @@  static int fabric_construct_sw_ports(IN ftree_fabric_t * p_ftree,
 
 		p_remote_node =
 		    osm_node_get_remote_node(p_node, i, &remote_port_num);
+		if (!p_remote_node)
+			continue;
 
 		/* ignore any loopback connection on switch */
 		if (p_node == p_remote_node) {