From patchwork Wed Jan 30 08:59:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 2066381 X-Patchwork-Delegate: alexne@voltaire.com Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 45D063FDD1 for ; Wed, 30 Jan 2013 08:59:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753386Ab3A3I7i (ORCPT ); Wed, 30 Jan 2013 03:59:38 -0500 Received: from georges.telenet-ops.be ([195.130.137.68]:45480 "EHLO georges.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751382Ab3A3I7i (ORCPT ); Wed, 30 Jan 2013 03:59:38 -0500 Received: from [192.168.1.102] ([178.119.64.133]) by georges.telenet-ops.be with bizsmtp id u8zb1k00m2sVyXE068zbpQ; Wed, 30 Jan 2013 09:59:36 +0100 Message-ID: <5108E0F6.3060602@acm.org> Date: Wed, 30 Jan 2013 09:59:34 +0100 From: Bart Van Assche User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 MIME-Version: 1.0 To: Alex Netes CC: linux-rdma@vger.kernel.org, Doug Ledford Subject: Re: [PATCH] opensm/configure.in: Remove Default-Start from opensmd init script References: <20130129171850.GB2961@calypso.mtl.com> In-Reply-To: <20130129171850.GB2961@calypso.mtl.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 01/29/13 18:18, Alex Netes wrote: > During opensm RPM packaging, `chkconfig --add opensmd` is called. > `chkconfig --add` creates the appropriate entry as specified by the > default values in the init script. Having opensmd run by default on boot > isn't desired. > > Signed-off-by: Alex Netes > --- > configure.in | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/configure.in b/configure.in > index 4515ae2..f798be2 100644 > --- a/configure.in > +++ b/configure.in > @@ -18,12 +18,13 @@ AC_ARG_WITH([rdma_service], > AC_SUBST(RDMA_SERVICE, ${with_rdma_service:-${default_rdma_service}}) > > if { rpm -q sles-release || rpm -q openSUSE-release; } >/dev/null 2>&1; then > - default_start="2 3 5" > default_stop="0 1 4 6" > else > - default_start="2 3 4 5" > default_stop="0 1 6" > fi > + > +default_start="null" > + > AC_SUBST(DEFAULT_START, $default_start) > AC_SUBST(DEFAULT_STOP, $default_stop) Sorry but this patch doesn't make sense to me. This patch will prevent anyone to enable opensm to run during boot via chkconfig. How about replacing the above by the (untested) patch below ? iff --git a/opensm.spec.in b/opensm.spec.in index 6ae525b..2325b70 100644 Bart. --- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/opensm.spec.in +++ b/opensm.spec.in @@ -107,13 +107,6 @@ rm -rf $RPM_BUILD_ROOT %post if [ $1 = 1 ]; then - if [ -e /sbin/chkconfig ]; then - /sbin/chkconfig --add opensmd - elif [ -e /usr/sbin/update-rc.d ]; then - /usr/sbin/update-rc.d opensmd defaults - else - /usr/lib/lsb/install_initd /etc/init.d/opensmd - fi if type systemctl >/dev/null 2>&1; then systemctl --system daemon-reload fi