diff mbox

[v2,opensm] osm_subnet.c: Fix memory leak caused by commit dc0760cb8088fbe079e19682570a884ba01e94ff

Message ID 52137D21.1080806@dev.mellanox.co.il (mailing list archive)
State Accepted
Delegated to: Hal Rosenstock
Headers show

Commit Message

Hal Rosenstock Aug. 20, 2013, 2:28 p.m. UTC 
From: Vladimir Koushnir <vladimirk@mellanox.com>

double strdup for p_opt->dump_files_dir is causing memory leak

Approach from Bart Van Assche <bvanassche@acm.org>

Signed-off-by: Vladimir Koushnir <vladimirk@mellanox.com>
Signed-off-by: Hal Rosenstock <hal@mellanox.com>
---
Change since v1:
Eliminate cast by doing separate strdup

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c
index 7ab1671..d0835b9 100644
--- a/opensm/osm_subnet.c
+++ b/opensm/osm_subnet.c
@@ -1499,7 +1499,8 @@  void osm_subn_set_default_opt(IN osm_subn_opt_t * p_opt)
 	p_opt->dump_files_dir = getenv("OSM_TMP_DIR");
 	if (!p_opt->dump_files_dir || !(*p_opt->dump_files_dir))
 		p_opt->dump_files_dir = strdup(OSM_DEFAULT_TMP_DIR);
-	p_opt->dump_files_dir = strdup(p_opt->dump_files_dir);
+	else
+		p_opt->dump_files_dir = strdup(p_opt->dump_files_dir);
 	p_opt->log_file = strdup(OSM_DEFAULT_LOG_FILE);
 	p_opt->log_max_size = 0;
 	p_opt->partition_config_file = strdup(OSM_DEFAULT_PARTITION_CONFIG_FILE);