From patchwork Mon Oct 7 20:35:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hal Rosenstock X-Patchwork-Id: 2999131 X-Patchwork-Delegate: hal@mellanox.com Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F2986BF924 for ; Mon, 7 Oct 2013 20:35:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1B87E2021B for ; Mon, 7 Oct 2013 20:35:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BC18201B4 for ; Mon, 7 Oct 2013 20:35:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752695Ab3JGUfk (ORCPT ); Mon, 7 Oct 2013 16:35:40 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:33434 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752693Ab3JGUfk (ORCPT ); Mon, 7 Oct 2013 16:35:40 -0400 Received: by mail-wg0-f46.google.com with SMTP id k14so7880489wgh.25 for ; Mon, 07 Oct 2013 13:35:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:content-type:content-transfer-encoding; bh=gRpmjMPfsEAYWwXBJNDcvoIX2TbnMgjXeZnJmb98E6I=; b=fhqHr2HfBiP1crfmhUdol8+BXFvBnLHomuyxf4TVtcj9AIvpYMn3h0yqDpZZJciu3N 1QXPZjTSjq3onCUZfNqvbml4JFl1CCugmsYb7iUXRHfz/k27wud9G/7zTVUe9sAKqgQj nci7Vzn/C7+vAuxl2UqJWd7lCXdvQamTixivxEMQwKoxjGMsFrUwWOJP55Wni4EBVHLQ es4/AhRrzhH5zQ3MtqZq7q5dsnBhLW1uoc8qIv1dEVp87Ds25jwBm34i+QWkoSkka/fr gfDYpaNYsO2UlRsTYVPQO4L8s0tXsk9kLfg3LVHKCFdL2viv7gZU2ShTjlBsNWnDQV5y 8bgg== X-Gm-Message-State: ALoCoQksvo+wPph5BpjUjk9GxbTkzUID4l+3cPA6yA6E8NqnwD2wbwmTK0VC01iktA+ID6z6NLH1 X-Received: by 10.180.10.8 with SMTP id e8mr20722251wib.65.1381178138737; Mon, 07 Oct 2013 13:35:38 -0700 (PDT) Received: from [192.168.1.102] (c-98-229-118-119.hsd1.ma.comcast.net. [98.229.118.119]) by mx.google.com with ESMTPSA id fz8sm516291wic.0.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 07 Oct 2013 13:35:38 -0700 (PDT) Message-ID: <52531B18.1010304@dev.mellanox.co.il> Date: Mon, 07 Oct 2013 16:35:36 -0400 From: Hal Rosenstock User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: "linux-rdma (linux-rdma@vger.kernel.org)" Subject: [PATCH OpenSM] osm_vendor_ibumad.c: Improve ERR 5430 log message Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add in class, method and attribute so have better idea on failure without increasing log verbosity Signed-off-by: Hal Rosenstock --- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/libvendor/osm_vendor_ibumad.c b/libvendor/osm_vendor_ibumad.c index ee14f5b..19551a5 100644 --- a/libvendor/osm_vendor_ibumad.c +++ b/libvendor/osm_vendor_ibumad.c @@ -1138,8 +1138,10 @@ Resp: resp_expected ? p_bind->timeout : 0, p_bind->max_retries)) < 0) { OSM_LOG(p_vend->p_log, OSM_LOG_ERROR, "ERR 5430: " - "Send p_madw = %p of size %d TID 0x%" PRIx64 " failed %d (%m)\n", - p_madw, sent_mad_size, tid, ret); + "Send p_madw = %p of size %d, Class 0x%x, Method 0x%X, " + "Attr 0x%X, TID 0x%" PRIx64 " failed %d (%m)\n", + p_madw, sent_mad_size, p_mad->mgmt_class, + p_mad->method, cl_ntoh16(p_mad->attr_id), tid, ret); if (resp_expected) { get_madw(p_vend, &p_mad->trans_id, p_mad->mgmt_class); /* remove from aging table */