From patchwork Mon Oct 28 12:12:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hal Rosenstock X-Patchwork-Id: 3101801 X-Patchwork-Delegate: hal@mellanox.com Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C3B159F2B7 for ; Mon, 28 Oct 2013 12:12:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A6CED2022A for ; Mon, 28 Oct 2013 12:12:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FA1E20220 for ; Mon, 28 Oct 2013 12:12:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755572Ab3J1MML (ORCPT ); Mon, 28 Oct 2013 08:12:11 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:56181 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754133Ab3J1MMK (ORCPT ); Mon, 28 Oct 2013 08:12:10 -0400 Received: by mail-ee0-f46.google.com with SMTP id c1so3411479eek.33 for ; Mon, 28 Oct 2013 05:12:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:content-type:content-transfer-encoding; bh=eTEKImq67tkWP7/SqyzG4A6RBx5nxj/jrVecxjAaNIM=; b=DwMdSWu4fcYWrCEsYXrrrf7Yy3hWThDVL2zDgyWE7upNuWbhcXt2suh3GkIWW2sKFX dwVL5Mtbw9wLCM2fVq+DuoFRWhJL1/JLLl/hUgoX97Eoaxm2BE+WpMxtF0wQIbjd2J4d PfT0H6qJe0TqrccwxXmoOWxebO53I8AgiAEo4bQctO8apO/fxkl/ZJ3k4MUbVkbdXMFz fdtbIJg8IUaw8QGhM4H7kUkjXXTxGg7jrlQfnPtTYDzle5Ex8M35pDgtyLdaBTO5j1iX IDPa41GPrkLnPOcsIuxCCQbNKAlXDvYhhsXz5kSkVJp46Qc+ihpls//ghpDgfKYH577u Oinw== X-Gm-Message-State: ALoCoQlEQHUawmGzFa+AEHiMcddBtM+rVPQv0yj2FK9yMeDavl8shxmD3KZ0BTuIhnZ5YpM4Oe03 X-Received: by 10.15.32.198 with SMTP id a46mr21885069eev.31.1382962329086; Mon, 28 Oct 2013 05:12:09 -0700 (PDT) Received: from [192.168.1.102] (c-98-229-118-119.hsd1.ma.comcast.net. [98.229.118.119]) by mx.google.com with ESMTPSA id s3sm56538051eeo.3.2013.10.28.05.12.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 28 Oct 2013 05:12:08 -0700 (PDT) Message-ID: <526E5495.6070402@dev.mellanox.co.il> Date: Mon, 28 Oct 2013 08:12:05 -0400 From: Hal Rosenstock User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: "linux-rdma (linux-rdma@vger.kernel.org)" CC: Vladimir Koushnir Subject: [PATCH opensm] osm_link_mgr.c: active_transition parameter in PortInfo(Set) context may not be initialized Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Vladimir Koushnir --- opensm/osm_link_mgr.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/opensm/osm_link_mgr.c b/opensm/osm_link_mgr.c index 98126f1..0d00984 100644 --- a/opensm/osm_link_mgr.c +++ b/opensm/osm_link_mgr.c @@ -440,13 +440,12 @@ static int link_mgr_set_physp_pi(osm_sm_t * sm, IN osm_physp_t * p_physp, } Send: + context.pi_context.active_transition = FALSE; if (port_state != IB_LINK_NO_CHANGE && port_state != ib_port_info_get_port_state(p_old_pi)) { send_set = TRUE; if (port_state == IB_LINK_ACTIVE) context.pi_context.active_transition = TRUE; - else - context.pi_context.active_transition = FALSE; } context.pi_context.node_guid = osm_node_get_node_guid(p_node);