diff mbox

[opensm] osm_ucast_cache.c: Fix memory leak in ucast_cache

Message ID 526E7E42.8060302@dev.mellanox.co.il (mailing list archive)
State Accepted
Delegated to: Hal Rosenstock
Headers show

Commit Message

Hal Rosenstock Oct. 28, 2013, 3:09 p.m. UTC 
From: Alex Netes <alexne@mellanox.com>

When invalidating cache p_sw->hops[i] arrays aren't cleared.

Signed-off-by: Alex Netes <alexne@mellanox.com>
Signed-off-by: Hal Rosenstock <hal@mellanox.com>
---
 opensm/osm_ucast_cache.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
diff mbox

Patch

diff --git a/opensm/osm_ucast_cache.c b/opensm/osm_ucast_cache.c
index e3f7c7b..2238ba3 100644
--- a/opensm/osm_ucast_cache.c
+++ b/opensm/osm_ucast_cache.c
@@ -114,13 +114,19 @@  static cache_switch_t *cache_sw_new(uint16_t lid_ho, unsigned num_ports)
 
 static void cache_sw_destroy(cache_switch_t * p_sw)
 {
+	unsigned i;
+
 	if (!p_sw)
 		return;
 
 	if (p_sw->lft)
 		free(p_sw->lft);
-	if (p_sw->hops)
+	if (p_sw->hops) {
+		for (i = 0; i < p_sw->num_hops; i++)
+			if (p_sw->hops[i])
+				free(p_sw->hops[i]);
 		free(p_sw->hops);
+	}
 	free(p_sw);
 }