From patchwork Mon Nov 11 20:23:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hal Rosenstock X-Patchwork-Id: 3169721 X-Patchwork-Delegate: hal@mellanox.com Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6045AC045B for ; Mon, 11 Nov 2013 20:24:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 75F36203AF for ; Mon, 11 Nov 2013 20:24:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8932F20387 for ; Mon, 11 Nov 2013 20:24:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752560Ab3KKUYB (ORCPT ); Mon, 11 Nov 2013 15:24:01 -0500 Received: from mail-ea0-f179.google.com ([209.85.215.179]:46144 "EHLO mail-ea0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752342Ab3KKUXk (ORCPT ); Mon, 11 Nov 2013 15:23:40 -0500 Received: by mail-ea0-f179.google.com with SMTP id r15so925897ead.10 for ; Mon, 11 Nov 2013 12:23:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:content-type:content-transfer-encoding; bh=meMLtE9IVez6iCo/hA+6moiD3nSxggo5MoDbhVWdp/Y=; b=iBnd3NXidnFQJed56W7668AW0zivkDz4jz31AtnQi6jeWGmnixBVP/jgCCa5Tgmiq3 CFpUCH9SAvDde3/70RWAgeIpfl4inidWCYF4YCYwFWe8HYe+zuP+5fpw7PnmjBpd2alQ sUUvUiemH6Nr80v5Mup3yMBX8feeBX75v5G8WyLDDJEnr7dPEkZ2/clhxIzDdjWRyH6j 8+lUATp2CDph1KZRm/1W9IcnIVn/LjoBYaBmUMTFRwCYzef74QJy5wJospUkjdLTUoL+ B4BYJhjExRjKQhwj8DDH8RyDNSACb0LR1HO+8bFZBKyP4u6XRqoN9v2D98L96Q5hbf85 25Lw== X-Gm-Message-State: ALoCoQm3bOLVOwYoL6JwxQgr2tgvnnK+jgyowVat0guUJICjiMp/nVcWR3a89tszP3Mqij38hyk+ X-Received: by 10.15.23.1 with SMTP id g1mr4370717eeu.63.1384201416014; Mon, 11 Nov 2013 12:23:36 -0800 (PST) Received: from [192.168.1.102] (c-98-229-118-119.hsd1.ma.comcast.net. [98.229.118.119]) by mx.google.com with ESMTPSA id i1sm67063718eeg.0.2013.11.11.12.23.35 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 11 Nov 2013 12:23:35 -0800 (PST) Message-ID: <52813CC6.4070801@dev.mellanox.co.il> Date: Mon, 11 Nov 2013 15:23:34 -0500 From: Hal Rosenstock User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: "linux-rdma (linux-rdma@vger.kernel.org)" CC: Shlomi Nimrodi Subject: [PATCH 2/2 opensm] osm_link_mgr.c: Fix uninitialized value (physp0) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Shlomi Nimrodi physp0 might be uninitialized for HCA. Signed-off-by: Shlomi Nimrodi Signed-off-by: Hal Rosenstock --- opensm/osm_link_mgr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/opensm/osm_link_mgr.c b/opensm/osm_link_mgr.c index 5fdb7ca..44bfbe6 100644 --- a/opensm/osm_link_mgr.c +++ b/opensm/osm_link_mgr.c @@ -101,7 +101,7 @@ static int link_mgr_set_physp_pi(osm_sm_t * sm, IN osm_physp_t * p_physp, ib_api_status_t status; uint8_t port_num, mtu, op_vls, smsl = OSM_DEFAULT_SL; boolean_t esp0 = FALSE, send_set = FALSE, send_set2 = FALSE; - osm_physp_t *p_remote_physp, *physp0; + osm_physp_t *p_remote_physp, *physp0 = NULL; int issue_ext = 0, fdr10_change = 0; int ret = 0; ib_net32_t attr_mod, cap_mask;