From patchwork Sun Dec 15 17:22:13 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hal Rosenstock X-Patchwork-Id: 3350671 X-Patchwork-Delegate: hal@mellanox.com Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6F457C0D4A for ; Sun, 15 Dec 2013 17:22:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 69E8E2012F for ; Sun, 15 Dec 2013 17:22:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 853AD200BE for ; Sun, 15 Dec 2013 17:22:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751679Ab3LORWT (ORCPT ); Sun, 15 Dec 2013 12:22:19 -0500 Received: from mail-we0-f169.google.com ([74.125.82.169]:60025 "EHLO mail-we0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751665Ab3LORWS (ORCPT ); Sun, 15 Dec 2013 12:22:18 -0500 Received: by mail-we0-f169.google.com with SMTP id w61so3773046wes.0 for ; Sun, 15 Dec 2013 09:22:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:content-type:content-transfer-encoding; bh=Wsm9+6NQ/ZFJaMa+G5xogr6wTWk1Ae+TWx7tRySAWbw=; b=EbGp17a396t7Z9gfrroghkXjz9oGQLWIEtIarKvEPo8JPbWLvIiPUnbjibDX1ShDDh LV0dS9E3JwyxlBF/hDZG3sTK/zpkIY1b6zHpCBfj7rlprAyRu8dgTkcAjZP5cxdj70IF MvffLVNRJR7RW1OWWmvqdImvJvaYrKNJJXTTgDhHAkcvFvNPU4Df5etEPxwfwEunpOHr MTDmoBFWvCG8ssyTM4GpbaaT6iylHUxJb+YW4PKr5sQhf9SaZW26mWRxTJwyZjN+/cgN SAAf1XsGYBMGQiJsJAkrgkAoAnIovXBOcDLawl+GgPko9VW6EYN1VHs9/mSiOA/rNC6O 5LPw== X-Gm-Message-State: ALoCoQkPpn398q1ZGSn76T5bZmLQXqRCYrpcvrNf+SW3J7nkI6EjJGOaknBsi1WANb10rybNQ1yn X-Received: by 10.194.174.36 with SMTP id bp4mr10508819wjc.7.1387128137513; Sun, 15 Dec 2013 09:22:17 -0800 (PST) Received: from [192.168.1.102] (c-98-229-118-119.hsd1.ma.comcast.net. [98.229.118.119]) by mx.google.com with ESMTPSA id fj8sm34862576wib.1.2013.12.15.09.22.16 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 15 Dec 2013 09:22:16 -0800 (PST) Message-ID: <52ADE545.5030509@dev.mellanox.co.il> Date: Sun, 15 Dec 2013 12:22:13 -0500 From: Hal Rosenstock User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: "linux-rdma (linux-rdma@vger.kernel.org)" CC: Vladimir Koushnir Subject: [PATCH opensm] osm_sa_path_record.c: Improve ERR 1F1D to show the pkey specified in PathQuery Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Vladimir Koushnir Signed-off-by: Vladimir Koushnir Signed-off-by: Hal Rosenstock --- opensm/osm_sa_path_record.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/opensm/osm_sa_path_record.c b/opensm/osm_sa_path_record.c index 8384ece..1709062 100644 --- a/opensm/osm_sa_path_record.c +++ b/opensm/osm_sa_path_record.c @@ -680,18 +680,18 @@ static ib_api_status_t pr_rcv_get_path_parms(IN osm_sa_t * sa, if (p_qos_level && p_qos_level->pkey_range_len && !osm_qos_level_has_pkey(p_qos_level, pkey)) { OSM_LOG(sa->p_log, OSM_LOG_ERROR, "ERR 1F1D: " - "Ports 0x%016" PRIx64 " (%s port %d) and " - "0x%016"PRIx64" (%s port %d) " - "do not share PKeys defined by QoS level " - "\"%s\"\n", + "QoS level \"%s\" doesn't define specified PKey 0x%04x " + "for ports 0x%016" PRIx64 " (%s port %d) and " + "0x%016"PRIx64" (%s port %d)\n", + p_qos_level->name, + cl_ntoh16(pkey), cl_ntoh64(osm_physp_get_port_guid(p_src_physp)), p_src_physp->p_node->print_desc, p_src_alias_guid->p_base_port->p_physp->port_num, cl_ntoh64(osm_physp_get_port_guid (p_dest_physp)), p_dest_physp->p_node->print_desc, - p_dest_alias_guid->p_base_port->p_physp->port_num, - p_qos_level->name); + p_dest_alias_guid->p_base_port->p_physp->port_num); status = IB_NOT_FOUND; goto Exit; }