From patchwork Wed Jan 15 20:29:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hal Rosenstock X-Patchwork-Id: 3493671 X-Patchwork-Delegate: hal@mellanox.com Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B991AC02DC for ; Wed, 15 Jan 2014 20:29:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E90E420155 for ; Wed, 15 Jan 2014 20:29:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9EEE20154 for ; Wed, 15 Jan 2014 20:29:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751767AbaAOU3L (ORCPT ); Wed, 15 Jan 2014 15:29:11 -0500 Received: from mail-ee0-f48.google.com ([74.125.83.48]:43929 "EHLO mail-ee0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751744AbaAOU3K (ORCPT ); Wed, 15 Jan 2014 15:29:10 -0500 Received: by mail-ee0-f48.google.com with SMTP id t10so1079918eei.21 for ; Wed, 15 Jan 2014 12:29:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:content-type:content-transfer-encoding; bh=AXO8CBGRc9uCynwSWrVBqjczawmjQqv0HqHtT3COoDg=; b=N1jh1kMbftvlWnz/BSBTuY302k3bIfphB7oQEwCevxXinYbu5w16nlmJJ4mILLsdBf EqhU0led3RMcku5/POntlaJaDoKGLISWwIiX+MdlMTdrZ2pDZp9KSIMCONZboVffhAww A6uFHm1yO1MkwadnxtMDRiDtKu3TWy3TGqIDk9iOAHB7cTMPiVsgh+aNSy4+i35ICyj5 C/piymPK8BAY7PqpoN/fmDv4Yb/s8P9KGN+q2OqIcJh80/hJqtwXXrRvUfNSG2C1MsYy snOyOBsIO1w3+UbvfO6VG0dytSIQeRU4vQ9AbblygBf/10PGypBnYn2gs98TLCvAktEi iGBA== X-Gm-Message-State: ALoCoQlQDq105pCNEZYflYcVRiJZmvfGP1jx0O2eQ4Vb62eyqQ+XLCSE3MXEhtK6Xhm5a+mEKzus X-Received: by 10.15.98.196 with SMTP id bj44mr5992284eeb.75.1389817749079; Wed, 15 Jan 2014 12:29:09 -0800 (PST) Received: from [192.168.1.102] (c-98-229-118-119.hsd1.ma.comcast.net. [98.229.118.119]) by mx.google.com with ESMTPSA id v1sm13053628eef.9.2014.01.15.12.29.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 15 Jan 2014 12:29:08 -0800 (PST) Message-ID: <52D6EF93.7030105@dev.mellanox.co.il> Date: Wed, 15 Jan 2014 15:29:07 -0500 From: Hal Rosenstock User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: "linux-rdma (linux-rdma@vger.kernel.org)" CC: Alex Netes Subject: [PATCH opensm 4/4] osm_trap_rcv.c: Removed unneeded lock when disabling port Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From 0ff054ae2f6e53e9e908f72f23b35cb40b3aeab4 Mon Sep 17 00:00:00 2001 From: Alex Netes Date: Sun, 5 May 2013 12:20:40 +0300 Subject: [PATCH 4/4] osm_trap_rcv.c: Removed unneeded lock when disabling port When disabling a noisy port, read-lock was taken twice. Signed-off-by: Alex Netes Signed-off-by: Hal Rosenstock --- opensm/osm_trap_rcv.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/opensm/osm_trap_rcv.c b/opensm/osm_trap_rcv.c index 2623536..472083d 100644 --- a/opensm/osm_trap_rcv.c +++ b/opensm/osm_trap_rcv.c @@ -258,13 +258,11 @@ static int disable_port(osm_sm_t *sm, osm_physp_t *p) pi->master_sm_base_lid = sm->p_subn->sm_base_lid; } - CL_PLOCK_ACQUIRE(sm->p_lock); status = osm_req_set(sm, osm_physp_get_dr_path_ptr(p), payload, sizeof(payload), IB_MAD_ATTR_PORT_INFO, cl_hton32(osm_physp_get_port_num(p)), FALSE, m_key, CL_DISP_MSGID_NONE, &context); - CL_PLOCK_RELEASE(sm->p_lock); return status; }