From patchwork Sat Feb 1 16:20:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hal Rosenstock X-Patchwork-Id: 3564981 X-Patchwork-Delegate: hal@mellanox.com Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CAEF29F383 for ; Sat, 1 Feb 2014 16:20:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D360120295 for ; Sat, 1 Feb 2014 16:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BED3C2028D for ; Sat, 1 Feb 2014 16:20:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754520AbaBAQUM (ORCPT ); Sat, 1 Feb 2014 11:20:12 -0500 Received: from mail-we0-f172.google.com ([74.125.82.172]:55660 "EHLO mail-we0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751944AbaBAQUL (ORCPT ); Sat, 1 Feb 2014 11:20:11 -0500 Received: by mail-we0-f172.google.com with SMTP id p61so700816wes.31 for ; Sat, 01 Feb 2014 08:20:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:content-type:content-transfer-encoding; bh=3xd5ypVTSGxEVIL63c+1DlRTPet1uF914KRKkrr1oiw=; b=ZJUHyn5PNfNI0XqyTNpDd4uoy9lQdD3jfk3FmfEN6+F/NhL7RXKwYhlRqrIA9jQcE8 aEKK7v1tWNT1MZnzlJg+Egr2hwU9ERWRkY9kiG3biphc+AlDDyEr3BojsKsZHzV82Pch evBs6wWclzyXKk5aCxvRxb51MiF24Eg+9ezh8cSbEqAdIWuRnJbNBXgKmQjkR2iXHmMn gku0I4RGjQLGhSeO7XDAIKltUETAvpSyChBm36gCAHfNgWDUFvTNK+nYFKrzKVXRE1hR Ie63sQC748qbVI4YpzAZup87k9yxaiL5nXJeY3vo1rLCNDHHDDFl4CtJ+uEJVdWqwFMF UrBw== X-Gm-Message-State: ALoCoQk/Adl6o61RAUExNGVvYynl5/JEDmqpOa34JW6u0ufw3Pf0nNx6clONmfwtSvYFQ458HBJw X-Received: by 10.181.13.82 with SMTP id ew18mr499865wid.22.1391271608507; Sat, 01 Feb 2014 08:20:08 -0800 (PST) Received: from [192.168.1.102] (c-98-229-118-119.hsd1.ma.comcast.net. [98.229.118.119]) by mx.google.com with ESMTPSA id di9sm7931686wid.6.2014.02.01.08.20.07 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 01 Feb 2014 08:20:08 -0800 (PST) Message-ID: <52ED1EB5.9080206@dev.mellanox.co.il> Date: Sat, 01 Feb 2014 11:20:05 -0500 From: Hal Rosenstock User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: "linux-rdma (linux-rdma@vger.kernel.org)" Subject: [PATCH opensm] osm_port.c: Improve ERR 4108 log message Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Even though routine name is called osm_physp_set_pkey_tbl, this is called for GetResp to either Get or Set so change set to update in log message. Also, indicate max_blocks in message. Signed-off-by: Hal Rosenstock --- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/opensm/osm_port.c b/opensm/osm_port.c index bcee338..ae74ba6 100644 --- a/opensm/osm_port.c +++ b/opensm/osm_port.c @@ -632,9 +632,9 @@ void osm_physp_set_pkey_tbl(IN osm_log_t * p_log, IN const osm_subn_t * p_subn, if (block_num >= max_blocks) { OSM_LOG(p_log, OSM_LOG_ERROR, "ERR 4108: " - "Got illegal set for block number:%u " - "For GUID: %" PRIx64 " port number:%u\n", - block_num, + "Got illegal update for block number:%u max:%u " + "for GUID: %" PRIx64 " port number:%u\n", + block_num, max_blocks, cl_ntoh64(p_physp->p_node->node_info.node_guid), p_physp->port_num); return;