diff mbox

[librdmacm,2/2] examples/riostream.c: Eliminate unneeded include

Message ID 5314CD84.5010104@dev.mellanox.co.il (mailing list archive)
State Rejected
Headers show

Commit Message

Hal Rosenstock March 3, 2014, 6:44 p.m. UTC
Signed-off-by: Hal Rosenstock <hal@mellanox.com>
---
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Hefty, Sean March 3, 2014, 7:25 p.m. UTC | #1
> Signed-off-by: Hal Rosenstock <hal@mellanox.com>
> ---
> diff --git a/examples/riostream.c b/examples/riostream.c
> index a1d3671..019d9e1 100644
> --- a/examples/riostream.c
> +++ b/examples/riostream.c
> @@ -44,7 +44,6 @@
>  #include <netinet/in.h>
>  #include <netinet/tcp.h>
> 
> -#include <rdma/rdma_cma.h>

Isn't this now needed for rdma_getaddrinfo?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Hal Rosenstock March 3, 2014, 7:36 p.m. UTC | #2
On 3/3/2014 2:25 PM, Hefty, Sean wrote:
>> Signed-off-by: Hal Rosenstock <hal@mellanox.com>
>> ---
>> diff --git a/examples/riostream.c b/examples/riostream.c
>> index a1d3671..019d9e1 100644
>> --- a/examples/riostream.c
>> +++ b/examples/riostream.c
>> @@ -44,7 +44,6 @@
>>  #include <netinet/in.h>
>>  #include <netinet/tcp.h>
>>
>> -#include <rdma/rdma_cma.h>
> 
> Isn't this now needed for rdma_getaddrinfo?

It's included by rsocket.h so not sure if it should be explicit here or
not. I just made the includes consistent with rstream example.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/examples/riostream.c b/examples/riostream.c
index a1d3671..019d9e1 100644
--- a/examples/riostream.c
+++ b/examples/riostream.c
@@ -44,7 +44,6 @@ 
 #include <netinet/in.h>
 #include <netinet/tcp.h>
 
-#include <rdma/rdma_cma.h>
 #include <rdma/rsocket.h>
 #include "common.h"