From patchwork Tue Mar 3 20:23:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hal Rosenstock X-Patchwork-Id: 5925831 X-Patchwork-Delegate: hal@mellanox.com Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 22F60BF440 for ; Tue, 3 Mar 2015 20:23:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5313720437 for ; Tue, 3 Mar 2015 20:23:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28E5820435 for ; Tue, 3 Mar 2015 20:23:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755860AbbCCUXP (ORCPT ); Tue, 3 Mar 2015 15:23:15 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:38548 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755764AbbCCUXO (ORCPT ); Tue, 3 Mar 2015 15:23:14 -0500 Received: by wiwh11 with SMTP id h11so25799042wiw.3 for ; Tue, 03 Mar 2015 12:23:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:content-type:content-transfer-encoding; bh=4mWcnmxMBAvoNKk+1Lo417vzRmAh1jKTKqTohEuMFxM=; b=Q22rVc9RvNVSAoOJfd9c9HsROk9WsnWXsw7YSmM+8qwn9DmSqmNr/zaxQFSV+cW35a IcdNZM/yuBmN95uyVkH+k4b3Xu3WTZZJJluU/5NuX7OhVZixs5WhNFyeWeo7LsNYIbWL jFoxMHWiXxIsoiamnTQLeAmIVJn8XouAv8oYHfdkCiDvhiH1fHDRTu09QJAOV2VKe41J kabeohoxr8ens5Hfi+anTNTJRGNuxsL9bYQVZRHXSchP6AfEZ6qaYMtp9QyzcoiCnLpv coYIq4Zm0zbmBHA27BVv1fiGxx+qPu+HG0veGGtRSCiKjNPaA2utg4coIw7aDq8CvYpk OOlA== X-Gm-Message-State: ALoCoQmd48WxSTltyIQbDtuB7RxBOSyw55kKWyi6S2gN6iBV/CvLFVZdCbRPHtdrKlWR5RtBzvzO X-Received: by 10.194.120.132 with SMTP id lc4mr1332799wjb.92.1425414193419; Tue, 03 Mar 2015 12:23:13 -0800 (PST) Received: from [192.168.1.102] (c-98-229-118-119.hsd1.ma.comcast.net. [98.229.118.119]) by mx.google.com with ESMTPSA id bx3sm2812981wjc.21.2015.03.03.12.23.11 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 03 Mar 2015 12:23:12 -0800 (PST) Message-ID: <54F61829.3070903@dev.mellanox.co.il> Date: Tue, 03 Mar 2015 15:23:05 -0500 From: Hal Rosenstock User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: "linux-rdma (linux-rdma@vger.kernel.org)" CC: Ira Weiny , "rafiw@mellanox.com" Subject: [PATCH libibumad] umad.h: Remove umad_reg_flags from enum declaration Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This causes it to be a global variable which causes linking issues when used by multiple files linked together. It results in multiple definition of `umad_reg_flags'. Found-by: Rafi Weiner Signed-off-by: Hal Rosenstock Reviewed-by: Ira Weiny --- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/infiniband/umad.h b/include/infiniband/umad.h index 6c3e7dc..1db4505 100644 --- a/include/infiniband/umad.h +++ b/include/infiniband/umad.h @@ -201,7 +201,7 @@ int umad_unregister(int portid, int agentid); enum { UMAD_USER_RMPP = (1 << 0) -} umad_reg_flags; +}; struct umad_reg_attr { uint8_t mgmt_class;