From patchwork Sat Dec 26 18:47:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 7922221 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3FD63BEEE5 for ; Sat, 26 Dec 2015 18:47:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4944920320 for ; Sat, 26 Dec 2015 18:47:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7EACE20306 for ; Sat, 26 Dec 2015 18:47:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbbLZSrd (ORCPT ); Sat, 26 Dec 2015 13:47:33 -0500 Received: from mout.web.de ([212.227.15.14]:65102 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbbLZSrc (ORCPT ); Sat, 26 Dec 2015 13:47:32 -0500 Received: from [192.168.1.2] ([78.53.181.98]) by smtp.web.de (mrweb001) with ESMTPSA (Nemesis) id 0M09uu-1aR0Pb0FdU-00uLFl; Sat, 26 Dec 2015 19:47:19 +0100 Subject: [PATCH 3/6] InfiniBand-ocrdma: Returning only value constants in ocrdma_qp_state_change() To: linux-rdma@vger.kernel.org, Devesh Sharma , Doug Ledford , Hal Rosenstock , Mitesh Ahuja , Sean Hefty , Selvin Xavier References: <566ABCD9.1060404@users.sourceforge.net> <567EDED5.4040201@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <567EE0B5.5020707@users.sourceforge.net> Date: Sat, 26 Dec 2015 19:47:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <567EDED5.4040201@users.sourceforge.net> X-Provags-ID: V03:K0:C9Dm/04uRz2Lff6Bvh56eJ/KUvO/ga9dvDWMVoKnKmlno49wLkC XVyRofl2XqEmELya0yIcUZx8lN0Qpe4jHMKmX53pQFEJl0w8PXme8kCNuebn2KWTpw6DJM3 2wK6zkixM5Muj8zAsnuUEEQFFYaGtYGWv7waFEmo+BGjhBdYep+riBZxglU7ufx887jJov5 O4oa7bHVbuJ0ZOXNE6d2Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:cWmGuu18tGw=:/Rg1IO8oM65FTV7PeN77jp jM9RUprdamZcFC9i0hV+3xGgi12bNlofzTA1wNSs8hx61XAKQYtAYCTleLSUch9EHoIN3ztxv OLeVLtfXiwETF3mI84Sq/ScKrDP0hGXJ1s78HFP0o/TcgY56cYlPIEaz2pA+ylHvgVnyUUKC+ DH3WS3reX368PJJeinqjzusy7tAvVxRtOfcWl0BKSikT2BUMTdilAOGIT3MsslUZ7kMdyoT0j UfLAv/8TLdiBlI0vGZ4mOgH+on/N77aPoYAomMOuFKW4EEPS2RZ4yJaV+CkihmEG1YjwMHD7Q G5wZMjAaFpTus7bOS5Z8mzLX5/iZrj36CbhTBtff4MqFTlNviHHlX0CDpiwXd+JwrhwkaFwhI fJLLxZP+wNVWnjzfd5dxPS9Pb0/9OwBb+73Lo7jw3TXxITNSXDX0r6P19JKJuPv4Do5p0tc2x SIONABt1SRTYCiBrmKwHS75QeDUsIYsnJo3+d10Ddbv/Rb7jtLnOVvlAjV8QJ0zL1QfNF8lv1 0oZEed+jbvtyynZbpDGd/J6OhxlnVedPNLSJAjY8SBwEhjSOPkHkuJ8uc7zWIN0QZxvjEAA9f ABw2BuKYDwRz/SowdzHH+TXhDut88vxq3084W+UjTCNp93EZWLp1VliNd5JbbuxdmVgCl3MRV cADj8IYUEvzhHDo3zQt3HFxmlFrmUHbVQgoKlXieXoJwHUdU4ShzC36igVAC2IjWbXkOaBOrw 6EphY/Kw3JWQyTXbpeH6XnRsA/XBYywtuhJ6Q8i3pSN9tpx3RU/PJ2MLbeBn0aeZ1VUz+BNM1 Vmx0Fz/ Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 26 Dec 2015 18:28:35 +0100 Return zero at the end without using the local variable "status". Signed-off-by: Markus Elfring --- drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c index 6647aa6..9a2b153 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c @@ -2110,7 +2110,6 @@ int ocrdma_qp_state_change(struct ocrdma_qp *qp, enum ib_qp_state new_ib_state, enum ib_qp_state *old_ib_state) { unsigned long flags; - int status = 0; enum ocrdma_qp_state new_state; new_state = get_ocrdma_qp_state(new_ib_state); @@ -2135,7 +2134,7 @@ int ocrdma_qp_state_change(struct ocrdma_qp *qp, enum ib_qp_state new_ib_state, qp->state = new_state; spin_unlock_irqrestore(&qp->q_lock, flags); - return status; + return 0; } static u32 ocrdma_set_create_qp_mbx_access_flags(struct ocrdma_qp *qp)