From patchwork Tue Apr 5 08:55:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagi Grimberg X-Patchwork-Id: 8748841 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4DA0FC0553 for ; Tue, 5 Apr 2016 08:55:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5FEA72034F for ; Tue, 5 Apr 2016 08:55:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4ED7E2034C for ; Tue, 5 Apr 2016 08:55:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756626AbcDEIzq (ORCPT ); Tue, 5 Apr 2016 04:55:46 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34209 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757557AbcDEIzp (ORCPT ); Tue, 5 Apr 2016 04:55:45 -0400 Received: by mail-wm0-f65.google.com with SMTP id n3so2326100wmn.1 for ; Tue, 05 Apr 2016 01:55:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=vzcERygozpvLNBKABKlr/Wajnb0XHryH1CeKSIo5kFY=; b=Q6u4nIJngijsnvdTxRVq13uGHmlj+0mf3UD7w6CcNUZAelDVwYssHQvAPbEbXPo27V AYUC1RI215gDI0TkG2VAeQv6AV9v04KXI/01FSwdtAHz/w4SKkcAbAUGKzhHqkd4O8qy Cx/ALar0/xrNUp+MD8ZvFEZmdPixsND1pTDLJlMBzLWVV4J38nVA1wP8TzjaPtAQlTlG +K0WKM38T4AxZVM1HdU0txaKePH/rgJgc6VgPeQC0PTnl5X81V3WDAku7b5MlyzNJcCz Yh/ifbXtW7nscxGcDtm+kFAL+4XUlG83uZtM1rfdELiTIZNbNaZ0Y+/NOOOpdJKFcDI9 Uv7Q== X-Gm-Message-State: AD7BkJLpqau0NPEVGvGYQQKtEoITVYcpU2Krp71fogCXW8xqDYTpuf1likPdoV7ksnb9pQ== X-Received: by 10.194.122.138 with SMTP id ls10mr22817288wjb.51.1459846544002; Tue, 05 Apr 2016 01:55:44 -0700 (PDT) Received: from [192.168.1.248] (bzq-82-81-101-184.red.bezeqint.net. [82.81.101.184]) by smtp.gmail.com with ESMTPSA id i5sm33387209wja.23.2016.04.05.01.55.42 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 05 Apr 2016 01:55:43 -0700 (PDT) Subject: Re: iSER initiator in 4.5 is unhappy.. To: Christoph Hellwig References: <20160404134656.GA30269@infradead.org> <5702A46F.5070109@grimberg.me> <5702A6AC.9020008@grimberg.me> <20160404225831.GA6725@infradead.org> Cc: linux-rdma@vger.kernel.org From: sagig Message-ID: <57037D8E.4030506@grimberg.me> Date: Tue, 5 Apr 2016 11:55:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160404225831.GA6725@infradead.org> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP >> Odd, I see that Ming's patches made it to 4.5... >> >> Can you verify that this patches exist in your tree: >> e827091cb1bc block: merge: get the 1st and last bvec via helpers >> 25e71a99f10e block: get the 1st and last bvec via helpers >> e0af29171aa8 block: check virt boundary in bio_will_gap() >> 7bcd79ac50d9 block: bio: introduce helpers to get the 1st and last bvec > > I've done a clean rebuild because I didn't trust the previous one > lingering around, and the syptoms are slightly different now, in that I > still get the same spew of messages, but it seems like xfstests is > very slowly progressing regardless. > > Also when testing srp I see similar messages with the same setup: > > [ 130.896116] scsi host7: ib_srp: Failed to map data (-12) > [ 130.896225] scsi host7: ib_srp: Failed to map data (-12) > [ 130.896232] scsi host7: ib_srp: Failed to map data (-12) > [ 130.896235] scsi host7: ib_srp: Failed to map data (-12) > [ 130.896835] scsi host7: ib_srp: Failed to map data (-12) > [ 130.993339] scsi host7: ib_srp: Failed to map data (-12) > [ 130.993345] scsi host7: ib_srp: Failed to map data (-12) > [ 130.993349] scsi host7: ib_srp: Failed to map data (-12) > [ 130.993841] scsi host7: ib_srp: Failed to map data (-12) > [ 130.993844] scsi host7: ib_srp: Failed to map data (-12) > [ 131.035723] scsi host7: ib_srp: Failed to map data (-12) > [ 131.058006] scsi host7: ib_srp: Failed to map data (-12) > [ 131.058059] scsi host7: ib_srp: Failed to map data (-12) > This implies that maybe something broke in ib_sg_to_pages: Can you run iser with this patch applied (FR or FMR): --- sg_page(sg), sg->offset, @@ -450,6 +450,7 @@ static int iser_fast_reg_mr(struct iscsi_iser_task *iser_task, if (unlikely(n != mem->size)) { iser_err("failed to map sg (%d/%d)\n", n, mem->size); + iser_data_buf_dump(mem, iser_task->iser_conn->ib_conn.device->ib_device); return n < 0 ? n : -EINVAL; } -- This sg dump will tell us what sort of scatterlist we can't handle. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/infiniband/ulp/iser/iser_memory.c b/drivers/infiniband/ulp/iser/iser_memory.c index 44cc85f206f3..67499d8f6a3a 100644 --- a/drivers/infiniband/ulp/iser/iser_memory.c +++ b/drivers/infiniband/ulp/iser/iser_memory.c @@ -143,7 +143,7 @@ static void iser_data_buf_dump(struct iser_data_buf *data, int i; for_each_sg(data->sg, sg, data->dma_nents, i) - iser_dbg("sg[%d] dma_addr:0x%lX page:0x%p " + iser_err("sg[%d] dma_addr:0x%lX page:0x%p " "off:0x%x sz:0x%x dma_len:0x%x\n", i, (unsigned long)ib_sg_dma_address(ibdev, sg),