From patchwork Thu Nov 10 04:17:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Henry Orosco X-Patchwork-Id: 9420595 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 07CB160720 for ; Thu, 10 Nov 2016 04:17:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ED2322684F for ; Thu, 10 Nov 2016 04:17:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E1A292927A; Thu, 10 Nov 2016 04:17:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5E69A28888 for ; Thu, 10 Nov 2016 04:17:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755097AbcKJERj convert rfc822-to-8bit (ORCPT ); Wed, 9 Nov 2016 23:17:39 -0500 Received: from mga05.intel.com ([192.55.52.43]:23656 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755095AbcKJERi (ORCPT ); Wed, 9 Nov 2016 23:17:38 -0500 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP; 09 Nov 2016 20:17:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,616,1473145200"; d="scan'208";a="1066486511" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 09 Nov 2016 20:17:35 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 9 Nov 2016 20:17:34 -0800 Received: from fmsmsx118.amr.corp.intel.com ([169.254.1.10]) by FMSMSX109.amr.corp.intel.com ([169.254.15.235]) with mapi id 14.03.0248.002; Wed, 9 Nov 2016 20:17:30 -0800 From: "Orosco, Henry" To: "dledford@redhat.com" CC: "linux-rdma@vger.kernel.org" , "e1000-rdma@lists.sourceforge.net" Subject: RE: [PATCH 1/2] i40iw: Remove variable flush_code and check to set qp->sq_flush Thread-Topic: [PATCH 1/2] i40iw: Remove variable flush_code and check to set qp->sq_flush Thread-Index: AQHSOwRrcXC67qu+oky2IZO9E0b2OaDRnCYA Date: Thu, 10 Nov 2016 04:17:29 +0000 Message-ID: <7F6CD2AB1343D04CBA3B1EDA4144D73897368DFB@fmsmsx118.amr.corp.intel.com> References: <20161110034207.18016-1-henry.orosco@intel.com> In-Reply-To: <20161110034207.18016-1-henry.orosco@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmQ4ZTBjMzEtMDg5OC00NjNhLTllNDUtYTAzMzE1OTMzZTMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImVyNExibW55Szh0U0FKbVwvdmlZSWdzYlZ5ZVZqb1c5eFZRYUVqZ08xdDNrPSJ9 x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Please disregard this one. Accidently sent this one as part of a series. -----Original Message----- From: Orosco, Henry Sent: Wednesday, November 09, 2016 9:42 PM To: dledford@redhat.com Cc: linux-rdma@vger.kernel.org; e1000-rdma@lists.sourceforge.net; Orosco, Henry Subject: [PATCH 1/2] i40iw: Remove variable flush_code and check to set qp->sq_flush The flush_code variable in i40iw_bld_terminate_hdr() is obsolete and the check to set qp->sq_flush is unreachable. Currently flush code is populated in setup_term_hdr() and both SQ and RQ are flushed always as part of the tear down flow. Signed-off-by: Shiraz Saleem Signed-off-by: Henry Orosco --- drivers/infiniband/hw/i40iw/i40iw_ctrl.c | 4 ---- 1 file changed, 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c index cd71444..57a4236 100644 --- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c +++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c @@ -4045,7 +4045,6 @@ static int i40iw_bld_terminate_hdr(struct i40iw_sc_qp *qp, u16 ddp_seg_len; int copy_len = 0; u8 is_tagged = 0; - enum i40iw_flush_opcode flush_code = FLUSH_INVALID; u32 opcode; struct i40iw_terminate_hdr *termhdr; @@ -4218,9 +4217,6 @@ static int i40iw_bld_terminate_hdr(struct i40iw_sc_qp *qp, if (copy_len) memcpy(termhdr + 1, pkt, copy_len); - if (flush_code && !info->in_rdrsp_wr) - qp->sq_flush = (info->sq) ? true : false; - return sizeof(struct i40iw_terminate_hdr) + copy_len; } -- 1.8.3.1