From patchwork Thu Jul 16 15:31:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey X-Patchwork-Id: 6808591 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6307E9F3A0 for ; Thu, 16 Jul 2015 15:49:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6729D2061E for ; Thu, 16 Jul 2015 15:49:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3D0820661 for ; Thu, 16 Jul 2015 15:49:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753673AbbGPPtu (ORCPT ); Thu, 16 Jul 2015 11:49:50 -0400 Received: from alukardd.org ([188.134.93.171]:37201 "EHLO alukardd.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbbGPPtt (ORCPT ); Thu, 16 Jul 2015 11:49:49 -0400 X-Greylist: delayed 1070 seconds by postgrey-1.27 at vger.kernel.org; Thu, 16 Jul 2015 11:49:49 EDT DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=alukardd.org; s=mail; h=Message-ID:Subject:To:From:Date:Content-Transfer-Encoding:Content-Type:MIME-Version; bh=dhP9i5AgryywcgxCbSHkIXhrAD/7mWZNvpmCHiHDzLY=; b=Wjee/Yhnctk1S4UALLTR0PeOcjx1mZj++sGmVAz/xmUcdB0dtFLU68WPFPN/pu8e84TK8m1AIcHCl2VBPf3vslzS/zFjtpMPt9cQelV3huNnLzcGp6kUV3HKmUP5Yy8kAQNzZ58GS8s/U3yLAjt9hhwrTZwZhabYVku8ZRdyMnc=; Received: from alukardd.org ([172.17.0.101]:38353 helo=mail.alukardd.org) by alukardd.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84) (envelope-from ) id 1ZFl8e-0007Vb-H1 for linux-rdma@vger.kernel.org; Thu, 16 Jul 2015 18:31:58 +0300 MIME-Version: 1.0 Date: Thu, 16 Jul 2015 18:31:56 +0300 From: Alexey To: linux-rdma@vger.kernel.org Subject: QLogic driver problem (ib_qib) Message-ID: <82fd80bcd97dae02558e4122b7c6964f@alukardd.org> X-Sender: alukardd@alukardd.org User-Agent: Alukardd Webmail Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello. I have issue with stuck ib_srp module because ib_qib driver is too old. From dmesg about srp_daemon: [Mon Jul 13 18:16:01 2015] srp_daemon D ffff880be35fa8f0 0 20491 1 0x00000000 [Mon Jul 13 18:16:01 2015] ffff880be35fa8f0 0000000000000000 ffff880c097ae150 0000000000013b40 [Mon Jul 13 18:16:01 2015] 0000000000013b40 ffff880be35fa8f0 ffff8800bad5ffd8 0000000000000000 [Mon Jul 13 18:16:01 2015] 7fffffffffffffff 7fffffffffffffff 0000000000000002 ffff8818047ba870 [Mon Jul 13 18:16:01 2015] Call Trace: [Mon Jul 13 18:16:01 2015] [] ? console_conditional_schedule+0xf/0xf [Mon Jul 13 18:16:01 2015] [] ? schedule_timeout+0x1c/0xec [Mon Jul 13 18:16:01 2015] [] ? _raw_spin_lock_irq+0xa/0x15 [Mon Jul 13 18:16:01 2015] [] ? __wait_for_common+0x124/0x163 [Mon Jul 13 18:16:01 2015] [] ? try_to_wake_up+0x1a8/0x1a8 [Mon Jul 13 18:16:01 2015] [] ? _raw_spin_unlock_irqrestore+0xc/0xd [Mon Jul 13 18:16:01 2015] [] ? srp_destroy_qp+0xe5/0xee [ib_srp] [Mon Jul 13 18:16:01 2015] [] ? srp_free_ch_ib+0x97/0x14f [ib_srp] [Mon Jul 13 18:16:01 2015] [] ? srp_create_target+0xa2c/0xac5 [ib_srp] [Mon Jul 13 18:16:01 2015] [] ? path_cleanup+0x1a/0x33 [Mon Jul 13 18:16:01 2015] [] ? path_openat+0x418/0x46d [Mon Jul 13 18:16:01 2015] [] ? __kmalloc+0xe5/?0xf7 [Mon Jul 13 18:16:01 2015] [] ? kernfs_fop_write+0x60/0x128 [Mon Jul 13 18:16:01 2015] [] ? kernfs_fop_write+0xdc/0x128 [Mon Jul 13 18:16:01 2015] [] ? vfs_write+0x9c/?0x11e [Mon Jul 13 18:16:01 2015] [] ? SyS_write+0x51/?0x85 [Mon Jul 13 18:16:01 2015] [] ? system_call_fastpath+0x12/0x17 Bart Van Assche help us and resulting patch you can see below: But with mlx driver all works fine. My current installation is: linux 3.19.1 qib 1.11 ib_srp 2.0.32 InfiniBand: QLogic Corp. IBA7322 QDR InfiniBand HCA (rev 02) I hope you can help fix ib_qib driver and we can remove this ugly patch from our source of ib_srp. Regards, Alexey Mochkin --- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index c5af67a..470eb54 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c @@ -59,6 +59,7 @@ #include "../../../../include/scsi/scsi_transport_srp.h" #include "ib_srp.h" +#include #define DRV_NAME "ib_srp" #define PFX DRV_NAME ": " @@ -621,11 +622,7 @@ static void srp_destroy_qp(struct srp_rdma_ch *ch) if (ret) goto out; - init_completion(&ch->done); - ret = ib_post_recv(ch->qp, &wr, &bad_wr); - WARN_ONCE(ret, "ib_post_recv() returned %d\n", ret); - if (ret == 0) - wait_for_completion(&ch->done); + msleep(100); out: ib_destroy_qp(ch->qp);