From patchwork Wed Mar 8 13:07:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9611045 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 400456016C for ; Wed, 8 Mar 2017 13:16:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8483A28585 for ; Wed, 8 Mar 2017 13:16:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 78BCC2858D; Wed, 8 Mar 2017 13:16:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 55D2D28585 for ; Wed, 8 Mar 2017 13:16:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753372AbdCHNPp (ORCPT ); Wed, 8 Mar 2017 08:15:45 -0500 Received: from mout.web.de ([212.227.15.3]:49221 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752415AbdCHNOt (ORCPT ); Wed, 8 Mar 2017 08:14:49 -0500 Received: from [192.168.1.2] ([92.228.144.238]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Lxx0G-1c9Me20tjo-015Igy; Wed, 08 Mar 2017 14:07:02 +0100 Subject: [PATCH 12/26] IB/ocrdma: Adjust ten checks for null pointers To: linux-rdma@vger.kernel.org, Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <8795100d-0577-bdcf-f4f2-04d04154bf71@users.sourceforge.net> Date: Wed, 8 Mar 2017 14:07:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: X-Provags-ID: V03:K0:xQ8P3Dr87cLLbyvTSwVL99Tm3FrgOjpLqKfY8cBRRD3kyMHFSFi U2lElin1asbqmOdqN9NAF42b6wwlf8sXnvr362CPuaUPVfZ3dGHPmYt1Xa7Iout9oCBtp6n 2Y+emHlPSJbsXOR7NJoULNFxE+mOoqb2ecVve29TZeX7DmDGBhmE53pCdJEiv6hgoDER0jc 7A/JJMSGfuezj1uE+HTXg== X-UI-Out-Filterresults: notjunk:1; V01:K0:G53OvF86qlA=:Zp5sju1XOG7tZosVNKZAG2 sI7j49XElUxPWgRoPNl0iookLNZQIbffpTeBwLwvJKQLLyQU4Jz40JF+SGKdqgV6AUkM15Xcz lLKT0BnkaiLX3TIGZZtGeBG4BhnRbyYDwhg419ZCnt+/imEJ78UmOsnqJysANzLKeDQX06zmy WZvjIurVHVN3glRWJdsBfiyvwtcyXxN4a5074Y/aNtnT8lSg31khPmFUG4CAbgsy0fuGE52oQ +02HrGI2u0Pa0IdfYu5VcD8Wipn1m3LoySQOatEa0D2sgHfG0QaKpG5tOxg0Y2BOoWIIH1Prw +5wUE28ysR6xvSZq0YsWFolO/QWraIP4A/MHceRd9PEVoqyr8MZabnc43QZGkPYoI/PGG3Tm3 u4wSoVGm+iktgIRE9/z7jROC7BR/TgzJt/ynDWKI52FcA8Iv/eqQdLh2j8yUhGW1dOcuckzma rVrD0bkiMi+NRcayObtd6bLcQD5SXIxHC+I18bFI+GW+KM7P8Q3+dJZRxl8JpSYdvE9dmGcth rLdeUn+HTMKTEcicJIVVGMGV3Ik2G70oWnYUD+XmAOlsiNBw0mPgoLqKtgtG+nLkxOFs4wVTn Z0Wfty7M+McJ4pwwII1aZRtUz69bdpoglTKzRw/dDEa8DM3cp4mb/U24G/+xMRzAEK4NZrMlw v87KZ4hNIZK7rn9fo6oMEN8bM+cl+bDfD6aBmXj4I9xWPgqz4wCPIRbxeVCAok6ZZARg/1qcT Tojb9qcAk/iQxwo/gspZ9p5OoOoTPm2Vxznx4gblUjbBX4vWQewjNmZUf+/vEh9OnckuAdHeK dP2wWaW Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Tue, 7 Mar 2017 21:32:22 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl“ pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring Reviewed-by: Yuval Shaia --- drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c index d5b988b011d1..8c7f0b108a7f 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c @@ -665,7 +665,7 @@ static void ocrdma_process_qpcat_error(struct ocrdma_dev *dev, enum ib_qp_state new_ib_qps = IB_QPS_ERR; enum ib_qp_state old_ib_qps; - if (qp == NULL) + if (!qp) BUG(); ocrdma_qp_state_change(qp, new_ib_qps, &old_ib_qps); } @@ -693,7 +693,7 @@ static void ocrdma_dispatch_ibevent(struct ocrdma_dev *dev, if (cqe->qpvalid_qpid & OCRDMA_AE_MCQE_QPVALID) { if (qpid < dev->attr.max_qp) qp = dev->qp_tbl[qpid]; - if (qp == NULL) { + if (!qp) { pr_err("ocrdma%d:Async event - qpid %u is not valid\n", dev->id, qpid); return; @@ -703,7 +703,7 @@ static void ocrdma_dispatch_ibevent(struct ocrdma_dev *dev, if (cqe->cqvalid_cqid & OCRDMA_AE_MCQE_CQVALID) { if (cqid < dev->attr.max_cq) cq = dev->cq_tbl[cqid]; - if (cq == NULL) { + if (!cq) { pr_err("ocrdma%d:Async event - cqid %u is not valid\n", dev->id, cqid); return; @@ -882,7 +882,7 @@ static int ocrdma_mq_cq_handler(struct ocrdma_dev *dev, u16 cq_id) while (1) { cqe = ocrdma_get_mcqe(dev); - if (cqe == NULL) + if (!cqe) break; ocrdma_le32_to_cpu(cqe, sizeof(*cqe)); cqe_popped += 1; @@ -948,7 +948,7 @@ static void ocrdma_qp_buddy_cq_handler(struct ocrdma_dev *dev, * false - Check for RQ CQ */ bcq = _ocrdma_qp_buddy_cq_handler(dev, cq, true); - if (bcq == NULL) + if (!bcq) bcq = _ocrdma_qp_buddy_cq_handler(dev, cq, false); spin_unlock_irqrestore(&dev->flush_q_lock, flags); @@ -969,7 +969,7 @@ static void ocrdma_qp_cq_handler(struct ocrdma_dev *dev, u16 cq_idx) BUG(); cq = dev->cq_tbl[cq_idx]; - if (cq == NULL) + if (!cq) return; if (cq->ibcq.comp_handler) { @@ -1289,7 +1289,7 @@ int ocrdma_mbx_rdma_stats(struct ocrdma_dev *dev, bool reset) int status; old_stats = kmalloc(sizeof(*old_stats), GFP_KERNEL); - if (old_stats == NULL) + if (!old_stats) return -ENOMEM; memset(mqe, 0, sizeof(*mqe)); @@ -1676,12 +1676,12 @@ static int ocrdma_mbx_create_ah_tbl(struct ocrdma_dev *dev) dev->av_tbl.pbl.va = dma_alloc_coherent(&pdev->dev, PAGE_SIZE, &dev->av_tbl.pbl.pa, GFP_KERNEL); - if (dev->av_tbl.pbl.va == NULL) + if (!dev->av_tbl.pbl.va) goto mem_err; dev->av_tbl.va = dma_alloc_coherent(&pdev->dev, dev->av_tbl.size, &pa, GFP_KERNEL); - if (dev->av_tbl.va == NULL) + if (!dev->av_tbl.va) goto mem_err_ah; dev->av_tbl.pa = pa; dev->av_tbl.num_ah = max_ah; @@ -1722,7 +1722,7 @@ static void ocrdma_mbx_delete_ah_tbl(struct ocrdma_dev *dev) struct ocrdma_delete_ah_tbl *cmd; struct pci_dev *pdev = dev->nic_info.pdev; - if (dev->av_tbl.va == NULL) + if (!dev->av_tbl.va) return; cmd = ocrdma_init_emb_mqe(OCRDMA_CMD_DELETE_AH_TBL, sizeof(*cmd));