From patchwork Mon May 21 17:18:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10415979 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EA41F6032C for ; Mon, 21 May 2018 17:18:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DA0E528501 for ; Mon, 21 May 2018 17:18:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CEBC228995; Mon, 21 May 2018 17:18:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AC4E428992 for ; Mon, 21 May 2018 17:18:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753132AbeEURSw (ORCPT ); Mon, 21 May 2018 13:18:52 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:63585 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752943AbeEURSu (ORCPT ); Mon, 21 May 2018 13:18:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1526923130; x=1558459130; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=/S2/jwYV5D5J7vHM3ej38lFkS8n5w7RW6daaTWN51Yo=; b=qGYwvlchR7LXoQe9fInFMIpvM++mb90wmtpzz6SxZBBJEozVcAlx+Jlw 9OCXBAvaz9/v0LdTLxw4UFRSI/eCv/hfGgjOAf5C74T+Q/Q+2dli8PpLb xysST8Na0yKhYs61/gTki0b4csXUJh2czqLyC9pl8ZWXgSxeq8fP60aFq HwHNavgYTOp971Kx6xN2n6WuEaIp6iFDnbn2TdoREWgWAgHo7Qvdebj8o Xn11aZB1WVuwFwn+Hw3RDHqvlDa/161RyKi/5QH7yY4z0P1xHnGcAitVw 0+uoHkbk6521H3VBdyO2GtpnNMr4b981PWPAc4glzPf97Xbx++0K+QXd9 Q==; X-IronPort-AV: E=Sophos;i="5.49,426,1520870400"; d="scan'208";a="78474419" Received: from mail-by2nam03lp0053.outbound.protection.outlook.com (HELO NAM03-BY2-obe.outbound.protection.outlook.com) ([216.32.180.53]) by ob1.hgst.iphmx.com with ESMTP; 22 May 2018 01:18:50 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/S2/jwYV5D5J7vHM3ej38lFkS8n5w7RW6daaTWN51Yo=; b=eYebuF05UIBya/kMZ2vA4zdZINXnt6PQY8v8rytcX7IpGyDRoEhW01d6H8GoB5HQMzrazyCtfBvUZ2Bz/DFvBpaW1fulmSRem93c4xw+OIbjv0WtJ3xLkbuotFjYyuq1EatF9AV4gdVZAl30sKFEtnmhPfSJO4Jy4hrVvMaOWU0= Received: from MWHPR04MB1198.namprd04.prod.outlook.com (10.173.48.151) by MWHPR04MB0959.namprd04.prod.outlook.com (10.174.249.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.16; Mon, 21 May 2018 17:18:47 +0000 Received: from MWHPR04MB1198.namprd04.prod.outlook.com ([fe80::b0a6:c7c1:fb97:eb04]) by MWHPR04MB1198.namprd04.prod.outlook.com ([fe80::b0a6:c7c1:fb97:eb04%14]) with mapi id 15.20.0776.015; Mon, 21 May 2018 17:18:47 +0000 From: Bart Van Assche To: "jess.calciano@intel.com" , "linux-rdma@vger.kernel.org" Subject: Re: Intermittent delay when attaching SCSI devices Thread-Topic: Intermittent delay when attaching SCSI devices Thread-Index: AdPtUfyJVkCVE23ATESdamQK5FkHtwAAXQCAAAnbkeAAs8AMsAA3ebmA Date: Mon, 21 May 2018 17:18:47 +0000 Message-ID: <98a6c588167c2cb1993eb7eeb4af01b4c89d1576.camel@wdc.com> References: <5d84b0edd52e2fd2842a82f3ffc6be866c45808d.camel@wdc.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [199.255.44.250] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MWHPR04MB0959; 7:l719nftgGffYx5zbcPMwDa/gZRpZW4LrkqfjGUPXGfMvM6OMIh3fstTvbMu6+PilDZWLkWwLOqNVnABVQuW++tqpA/Bhm+gapNDa94vUwiRKL7mgRQ5j7IeANAtnF6LmIoma6l4qW5d6Y1bSo7xQIdBObIFMbSvc/VYpIf7r+TpZoJmmcfCTaVc73grAnzVexwgkdOVEEKmglsjooB4XnwSz0iZXibdbTmNOACHIf4RJfHoJS2JZ3djc63NwhiTT; 20:9THlotrRruNqvSKu1pblR3HTcfQnuXC5PyRhLgnwwc0JwE+BDi3BW117w29yORyC/E9+2xWkBW3oyjFHAxq427QnZO77S26oH6SduxprVnUsl/SukJkmpuK9cbDZUxWAE1UsGW5SNEZodALtUSfv87chPflfEokIEaQ6XeNotoc= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:MWHPR04MB0959; x-ms-traffictypediagnostic: MWHPR04MB0959: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3002001)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:MWHPR04MB0959; BCL:0; PCL:0; RULEID:; SRVR:MWHPR04MB0959; x-forefront-prvs: 06793E740F x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(39380400002)(366004)(346002)(39860400002)(396003)(377424004)(189003)(199004)(7736002)(6486002)(486006)(25786009)(97736004)(446003)(11346002)(5660300001)(476003)(2616005)(8676002)(118296001)(81156014)(6436002)(68736007)(8936002)(3660700001)(66066001)(305945005)(81166006)(229853002)(3280700002)(6246003)(478600001)(2501003)(72206003)(110136005)(105586002)(6116002)(36756003)(59450400001)(86362001)(53936002)(6306002)(6512007)(76176011)(3846002)(26005)(2900100001)(316002)(14454004)(93886005)(99286004)(6506007)(106356001)(5250100002)(102836004)(186003)(2906002)(966005); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR04MB0959; H:MWHPR04MB1198.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-microsoft-antispam-message-info: yWiC/tKALLV8tGg5vF1eKEvhtqErOn76luR4ZUfYPl1FF0zaKIiDeR/lqILrc6PWJq6BxSdgXe7lWh3lVCuhcRXGoeUuxwJsXhzEhgmSchkNpbrRl9afmj3mD4e6z0DOER9elLMaMs9Hst1i7OLvjh0I2Urz7nAABre3plDJQOQNuKwl5cqv+K3+Ym+lbMn4 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <428E1556B5F4384192EB87F71284A936@namprd04.prod.outlook.com> MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 89e3d2c4-e4d7-468f-87b6-08d5bf3ee9dc X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89e3d2c4-e4d7-468f-87b6-08d5bf3ee9dc X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2018 17:18:47.4277 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR04MB0959 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, 2018-05-21 at 17:16 +0000, Calciano, Jess wrote: > > Does the following patch help: "[PATCH] sd: Increase SCSI disk probing concurrency" > > (https://www.spinics.net/lists/linux-scsi/msg115657.html)? > > The patch applied with no problems, but there's a compile error in scsi_pm.c. Is there maybe a prereq patch we need? > I tried it against the latest from https://github.com/torvalds/linux (4.17.0_rc5+) as well as one of our internal test kernels (based on 4.17.0_rc1+), and both resulted in the same failure. > > Here's the error: > > # make rpm > ...... > CC drivers/scsi/scsi.o > CC drivers/scsi/hosts.o > CC drivers/scsi/scsi_ioctl.o > CC drivers/scsi/scsicam.o > CC drivers/scsi/scsi_error.o > CC drivers/scsi/scsi_lib.o > CC drivers/scsi/scsi_common.o > CC drivers/scsi/constants.o > CC drivers/scsi/scsi_lib_dma.o > CC drivers/scsi/scsi_scan.o > CC drivers/scsi/scsi_sysfs.o > CC drivers/scsi/scsi_devinfo.o > CC drivers/scsi/scsi_netlink.o > CC drivers/scsi/scsi_sysctl.o > CC drivers/scsi/scsi_proc.o > CC drivers/scsi/scsi_debugfs.o > CC drivers/scsi/scsi_trace.o > CC drivers/scsi/scsi_logging.o > CC drivers/scsi/scsi_pm.o > drivers/scsi/scsi_pm.c: In function 'scsi_bus_prepare': > drivers/scsi/scsi_pm.c:177:10: error: 'struct scsi_driver' has no member named 'sync' > if (drv->sync) > ^ > drivers/scsi/scsi_pm.c:178:7: error: 'struct scsi_driver' has no member named 'sync' > drv->sync(dev); > ^ > make[4]: *** [drivers/scsi/scsi_pm.o] Error 1 > make[3]: *** [drivers/scsi] Error 2 > make[2]: *** [drivers] Error 2 > error: Bad exit status from /var/tmp/rpm-tmp.xdBh56 (%build) > > > RPM build errors: > Bad exit status from /var/tmp/rpm-tmp.xdBh56 (%build) > make[1]: *** [rpm-pkg] Error 1 > make: *** [rpm-pkg] Error 2 Hello Jess, Did you apply the entire patch? From the end of https://www.spinics.net/lists/linux-scsi/msg115657.html: Bart. diff --git a/include/scsi/scsi_driver.h b/include/scsi/scsi_driver.h index fae8b465233e..78173b6d305a 100644 --- a/include/scsi/scsi_driver.h +++ b/include/scsi/scsi_driver.h @@ -12,6 +12,7 @@ struct scsi_device; struct scsi_driver { struct device_driver gendrv; + void (*sync)(struct device *); void (*rescan)(struct device *); int (*init_command)(struct scsi_cmnd *); void (*uninit_command)(struct scsi_cmnd *);