From patchwork Wed Mar 7 20:00:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Schumaker, Anna" X-Patchwork-Id: 10265059 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E594B6016D for ; Wed, 7 Mar 2018 20:00:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D95EC28BEC for ; Wed, 7 Mar 2018 20:00:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CDC74295B9; Wed, 7 Mar 2018 20:00:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23FF328BEC for ; Wed, 7 Mar 2018 20:00:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754775AbeCGUAQ (ORCPT ); Wed, 7 Mar 2018 15:00:16 -0500 Received: from mx143.netapp.com ([216.240.21.24]:52971 "EHLO mx143.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934877AbeCGUAJ (ORCPT ); Wed, 7 Mar 2018 15:00:09 -0500 X-IronPort-AV: E=Sophos;i="5.47,437,1515484800"; d="scan'208";a="246845670" Received: from vmwexchts02-prd.hq.netapp.com ([10.122.105.23]) by mx143-out.netapp.com with ESMTP; 07 Mar 2018 12:00:08 -0800 Received: from VMWEXCCAS03-PRD.hq.netapp.com (10.122.105.19) by VMWEXCHTS02-PRD.hq.netapp.com (10.122.105.23) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Wed, 7 Mar 2018 12:00:08 -0800 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (10.120.60.153) by VMWEXCCAS03-PRD.hq.netapp.com (10.122.105.19) with Microsoft SMTP Server (TLS) id 15.0.1320.4 via Frontend Transport; Wed, 7 Mar 2018 12:00:08 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netapp.onmicrosoft.com; s=selector1-netapp-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UbJhAn8s4i03x0+uxvJCa9QukrOAwzRJQzaiXhsX4LQ=; b=CPCRMrG3ueZ3BYQayI8s1cO09s4rrUEVR59QREQ5A/o+APUmSyfoOJPhr13tUzKY4nYfD32cCEaHbI2k16Bw8yba5JUADTxQTnRVFyCkT7E/fLs1GEvs8sFFQuHILIrwtcrP5PNOex/npqblhFPq2tTVJ6M5nK3FMtkvgmITJls= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anna.Schumaker@netapp.com; Received: from gouda.nowheycreamery.com (68.40.188.1) by MWHPR06MB3166.namprd06.prod.outlook.com (2603:10b6:301:41::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Wed, 7 Mar 2018 20:00:06 +0000 Subject: Re: [PATCH 5/9] SUNRPC: Initialize rpc_rqst outside of xprt->reserve_lock To: Chuck Lever CC: linux-rdma , Linux NFS Mailing List References: <20180305200825.10904.40829.stgit@manet.1015granger.net> <20180305201318.10904.57825.stgit@manet.1015granger.net> <4dd8259a-e447-122b-c267-75e2e6b4714e@Netapp.com> <41538F44-115C-4F64-9BCA-0A6B8723A9F5@oracle.com> From: Anna Schumaker Message-ID: <9ac7ea34-d409-da6a-21cb-35fa6e09cd66@Netapp.com> Date: Wed, 7 Mar 2018 15:00:01 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <41538F44-115C-4F64-9BCA-0A6B8723A9F5@oracle.com> Content-Language: en-US X-Originating-IP: [68.40.188.1] X-ClientProxiedBy: DM5PR1401CA0018.namprd14.prod.outlook.com (2603:10b6:4:4a::28) To MWHPR06MB3166.namprd06.prod.outlook.com (2603:10b6:301:41::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 085fd912-e4b2-4c5c-6b4b-08d584660679 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:MWHPR06MB3166; X-Microsoft-Exchange-Diagnostics: 1; MWHPR06MB3166; 3:QmjmVgq/aJwFTZBfkXFNdBMLGOXCbQtY9bBdY2WqZ6N5UbFizN2UaMOxumQ7yiE+mFC5ge63uLwbsmif/KLWOWtkOl0RQBarUqZLa/SSAiwY/DBdaD0ZRuj+FsNQcQG6a6Yjn/Rt2H5Br4rFgzDhT/CbdMJsyWOKxNKY6KeYEE0rrpjpM8LfDpEdNkvfjREp/1x8Q+QTeOcixJ+MCskDHatlsHvXuubUF6OGnft+wSxpwkckuqQ+NLF63GwHS56y; 25:0c0QBnEoO2XxNgWCw8YH3BhRmZuYC0Bf9SESs/4XDYYkRXktZGKYqtzMuGau1T+cpxMhlf5zE+ZS21pYOG3ZeBvefvUtVsdrxLsIQTUZnz73n25xCbIqVvheVeojmK7e4SGBBK/nola4Cr5L1JrGAKnaMVaJQnZxCZO7hEYf4vDvL93GPk3PDCgr/EZKSA/XJImonvBA/C/vpnyV5ifNwl9+C2n3f3nRCxgzFx7mlN70DrNE6nCuMh6xo40LK4H+6Uyb8UYpQrGzhlMSgndD9l5VNV3Xhv9EKX9sXsruov4Dm+ScYbIpcZ+Rlk+/OB25GG/iNUKOaJdh0kqhi+DvNw==; 31:pphTkoF4LZN4t8zcpv4z3oZqDUA9SO85vAPwOAyWumFFr2NIT4hnMIvjsqKzUKH7DepJbJDDNRETWqGaT9Gnk51aXSFmyVI1DeyQAmOkynGWcoEB/gOVgr0LUN+VblpmBVgT1uUHvfr0Wp5Qlf3ZMYgZMW8aqFSvARP+VsExlSgSC7ZiFrd1XG1enRlBoOt3PUWPgCFfmOT7Pv9T6xH46ya4ihPCxzN0kmQniS/HU+M= X-MS-TrafficTypeDiagnostic: MWHPR06MB3166: X-Microsoft-Exchange-Diagnostics: 1; MWHPR06MB3166; 20:ZUG45A+ecaSpZxS+dl3ZVKjhP9WiWNU+P4NKWH2BzvZWYI0vCVfce3rW0KBf19r7J3SGogrb3I/P5EC0dRh/9ZxgTFnNy3ogXbv0Tz1tQ9u6wb5qG58zKpfRDxs0lw81ki7OQTfk5LGeigj+sBtFklfLT2FbXxhmMWCKhXtgKsq5AM5uxsiC5zPWr8N8QhhQt2B02+nAutdgjIanA8ksxKYkXZ2URDsgi+ioQcyLMR68v2VvZsoUJShu3tCgtsfVOepJHwM0NQHHRsf/9kCYLJxUId9oFWgCklBZRBPclHGuUPwg5c3uIHrVZAJveDnKhiTCQKJvqHa7fGPNGPRh30FSA5TyVb+SQiPcUyPFKRT8s3sF8IOZuRM480gpTm8Et/KA0si09xolU0uIsHUebxhw8JWwJ4M84DSuRWpCSHOx+RUDfY3al8WwwouhKBGf9dBdb2q8wj1sRuRrPGwQe//CMHF62Z8naSqfrfvIncRk4iOlBdaEICZ+cTR6XpQw; 4:S2WpGE4pnPh85lcoVb8GdZbS7G/y+Uo0V/I21d6Qfk8mViYBJx0Pou7vAeIrEzidK5Xn218qCrgeXyAuYIyoB8NPTftbC7oXj3hC8UM//DGIrusCvif5WPDtPE+OemaiZUpbdrawbYN3McRnMLAIY/RlNYDb9O3dN3FmgcYHJlXVFXFqJJ3jxJ1Io94p6+ulEOLNISbh7tBpEQRZZH8OCkm986jI5nPsvfs8T7TDyJXqjubxOXSPFQeYWPCDmFN686JgtmvGlceWACNN46nhVj1lI4ypMI0eImOx4MkKu/3PXdcIzgTlP/j+0+Jq4P2weV1bAbg1eap7UyKnILwqhyCTym0cxJzX84As2haaKg3dlOeteZGQ2l+hZf4nEiJb X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(21532816269658)(146099531331640); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(3002001)(3231220)(944501244)(52105095)(93006095)(93001095)(10201501046)(6055026)(6041288)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:MWHPR06MB3166; BCL:0; PCL:0; RULEID:; SRVR:MWHPR06MB3166; X-Forefront-PRVS: 0604AFA86B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(39860400002)(39380400002)(366004)(346002)(376002)(396003)(199004)(189003)(2486003)(52146003)(52116002)(31686004)(16526019)(76176011)(59450400001)(186003)(23676004)(106356001)(6486002)(386003)(8936002)(53546011)(36756003)(6506007)(575784001)(25786009)(86362001)(478600001)(26005)(50466002)(2906002)(6306002)(93886005)(6512007)(53416004)(64126003)(53936002)(305945005)(4326008)(54906003)(7736002)(6116002)(3846002)(58126008)(47776003)(81166006)(65956001)(229853002)(65806001)(105586002)(66066001)(81156014)(316002)(230700001)(65826007)(69596002)(8676002)(5660300001)(6666003)(72206003)(2950100002)(68736007)(966005)(6916009)(31696002)(97736004)(6246003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR06MB3166; H:gouda.nowheycreamery.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: netapp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjA2TUIzMTY2OzIzOm1tQkNWLzl1YUlIdmtqOTQ5SHhCa1FtQ2Ru?= =?utf-8?B?bmhBRStYSXJ6ZURjKyttRGE0Z09UUEpxSG11dkVrb1B0Qk5oT254MjhCb2hw?= =?utf-8?B?cTlFamQzMVVIRURUcnZ0cFlxZ1ZHM3VJMWhaSm9EeUNYMGorS0RHRmc4dmJC?= =?utf-8?B?S3JKMVlycWJuOXI3NkQ0RG9uaHJWbHdCT3drRCtwWTFuRzBQTjIvNzlXMjd2?= =?utf-8?B?WlNUYyttVEowbFU5bEFwZjhVb1orWVJoWTZJWC9jcjVOSkI3MGl6dFhka2d4?= =?utf-8?B?aEdrRHo1QkVHLy82cExrbkViK0JrQ2FSbUJON1F0dXErckEzcktMa2pxRzUv?= =?utf-8?B?Ry9UMVZLbFc0STY4L09JaEJsbU42YVdWb25KSXNoR24wWnZJMzFpL1ZJTk1S?= =?utf-8?B?N3JKZjJKaXRrV2FxQWlwdmhRYlNvRGpjRGFJdFBXU08xUk9DeWZzZGlIZmdE?= =?utf-8?B?clZtZmFDM1FrclZ1Y3VEMG9xMkZzK3NzaldPeTJjUHVtd1pCRkdUc21yb1dz?= =?utf-8?B?YVB5TTFZL3p3VDd1MlkrM0pJUVoyaVZsOGV5a1JwTjNZbHoyanlEMFF3ZUZV?= =?utf-8?B?SngzQ1FHc1A3dG9DY3JMRmVhYy96WXhQSnhYYjkwRFA3WVp5eDFpM0tsYXJa?= =?utf-8?B?TU1zTWFiNmFLS1YvRVB3OTlpVVg4a0psbkZKWk5Va1dJSnMvbkxZeU9mcUxE?= =?utf-8?B?SkczK1JHWmd5aGRHTDkxYkk3Uy9OM0NUSjArYjlrNVZKU2dDOFVKMjlVdEJi?= =?utf-8?B?eCs4R1g3S2Fvd1NXdU9taExaNm1EQmI2cEI2MHYwOG5uaWJVcCtJUFNEV09U?= =?utf-8?B?REpzQmxXS2E1UWJ2NW1jY2tJOHN1Mjh3bmJCVWRMV0poMFdmdVZXZE5nb1pk?= =?utf-8?B?T3NsK0s5SHNLa29LeTFCR2pjNHpSeTBBMUh6WUZsbjhoNGUxbWpvNyszRkor?= =?utf-8?B?T2Q2a3hmKzFjL1AyZFZLYWI1Znh6TVQzWWRyaXFPWGcyUWZ6VGcyeWZic1Fq?= =?utf-8?B?aWtudkZyT0p4bEZMOTlDSkdkdWFyc3R1TXdjN0JNZEhVVS9qV3h1Q0pxckhT?= =?utf-8?B?WUxJZGMyd0s2WWJYYms2emx6SjQxRjFIKy9QeDFGMSt4Qk9hZ3pOc01Wdnky?= =?utf-8?B?OUJXWkRWN2tjYkFKYzcwTDBuN1AzN1pON25PVTBhWmNxaVFuc1RNeEZpUzRT?= =?utf-8?B?ZFYwditUSVowYmVXYmQwVVdLMHdyY3VaazFtbzVIa3ZBSldURGt5eDU0QUYw?= =?utf-8?B?OU9vT3BkVHpPRkxqL2lzc1hoUUtGdzQzQTlBdnpSV3VpZkVUNXBVRit4a2xy?= =?utf-8?B?N1kxQVozVksrLzZqK2RCcGJUSTBxL2NuU3RaMkI0N2ZUeXJ2Ylo5dmFtckk0?= =?utf-8?B?ZGN1VnJmWU0xdVdqZy94M0U2QVZRdUlRcG5xTmlHeXRja3laT3hsY0IxTG5m?= =?utf-8?B?Qm1CNFF5em03WDVwblZ6aGRPNzJnY2c3bWh2NHlIRTBJcDhjbjVxU0w2ZWVw?= =?utf-8?B?VnB4NlNWbEFtYzhVMUJVSGJCR2ZTZU1HSWd1Q2FhMkU1WTBHSTlQSXFlcFNa?= =?utf-8?B?clE2cWpUd1hjVndwVWV1VHI4eGhmUDl1UnR2V1I3OXdPR1M2VXE3ZHV4aWpy?= =?utf-8?B?RWoxeDN0UEY3QkZLMWVzM3pYOHJlWVJiaWFYMTFvVm9HY25lMXlJMnIxTEhL?= =?utf-8?B?THZYdHNxMENVai9Jdkd5M1hLYmRkK2VwYk1rWWdkcWVGMU44NzNjSUQ1L1hN?= =?utf-8?B?M0ZlUURPSzlWeGFUb04zRWdYL2I2UEtzTDlZdmttS2ptOHdyVm9VdHFvcGhV?= =?utf-8?B?SEVhdmZ2c2d4Q2lwNHFOak01Zi8zWnlBZlp0UGdYaEoxR0FXUmdEd056anlC?= =?utf-8?B?T2J1aUxWdFZ1UUZpdWFDS2ZaL2tjRytlaFhPYUNwaUJNR1MydWZpcXdOVGZr?= =?utf-8?B?Yk8vK1FEK3hJRlNJRW1hVkx4dHBrQ293Qm81d1JqdXRGekNRQ2M3bTlmVm5L?= =?utf-8?B?TVVIZXJBQVRJck9mS0MzeE5MS1FoR3ZJd3dxRExYSFB4RCs1UE04bTVCK1Vk?= =?utf-8?B?T2xLdDlmWHpDa1hkdlFJM2VxYzVpNGFZaE02MUZwdjVWNk1GK1h5aSs5MVU5?= =?utf-8?Q?BBc0K659a8cwff4UiE6dF8QFC5lZeJyCx2tuMw3Kn6KH?= X-Microsoft-Antispam-Message-Info: APt9IAziDuObMz3TmRdXRB+ZFMe7uQ4zfIpZCFAqgIOjYdEeSUhk3rJ/H/TjstrRTzqVAzWFOFHragF/4dchMsdefpT7/BCRsfgyW0LY3rH2iET9ITWJglwvxX7UZJnk7ZRfNR1DSUHZpxdYTlvrQEdXtAXuwtiDAM1cjxqaeXBkPoVFCkuHvR62aYMpUriq X-Microsoft-Exchange-Diagnostics: 1; MWHPR06MB3166; 6:kkAbhftSVnrqCkAPuOXkf6ngb12y2fYljjq6UmqxU0SSyT+X4ORS98IO0cXN4BQKW1BvZOL18ghKo0DmHpkc5z3Fezapq3BtGht8z2iSyYKex61x+LWKmoet5s9wE993DONu/3P2sNPh/xSLtFMyVEYqv19piPs5vpqgqe4cD+dmE7KEKm4mz5Yx8eDj88ZHmedjS+ZTXwldJTH4yF+3r4CVJQdoL61KBrOHp0K4x8USbM46cXIovSi0q7ZSqHdbbcXPBXU5ccJkFXV3XRKCKV6BK31qn3Wkr8o3P2kzxlrDOnmbgxl8czoR8/Oev8PPDco99PNT7d2EmVPZ1tyFWfcTKcaS5rDEVCX6+svQMUM=; 5:0K0d5fRjkJl5TOz5AW5YZJ4Xws0olRPSF/pryO2J/V2YROVYjU2q7Wfyg5I1p/mNyUAVWQ311I0rhCcnNDWzjUojKT7PUNnXLfQGZCoLv4KUR88y6A0pV4QJyeaX19yXF4Xllq4CK/R7e9WLL8QAqCyZl10BEzBcDCJpLfSlkI8=; 24:kcE2KTdsHO/sGm1sDZEHvELnS67NT4TdNXdagv40L2h7iTqNT2Q4xrcrW88BbZBVbG0cf02TvkSFe/LMRbn8ZLY/BqUradjj1qwG96kFtmw=; 7:z4L6lGXRMlHYFOySriib9TK1yz+Mmi7BBt9ze8Duesf2I6UMdkHchMWFK/v6p5qnnc2vsYCLUuMptPcZpOWjF8brXNed8dafNBDswlM38nttnixVJJU81v7C8cMyI4CreAmaBvjWrr5pLdBZ0jJD8DGAsj5kleekF44gq5GTfQPToTUscwHiYJZM11y3TMqp8FKlSYzEWLZ31xRLwZmg721ums9Y19TxHJo5gHyb3uP+RwhJoveqbozT0Gf5xX6X SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2018 20:00:06.8100 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 085fd912-e4b2-4c5c-6b4b-08d584660679 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4b0911a0-929b-4715-944b-c03745165b3a X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR06MB3166 X-OriginatorOrg: netapp.com Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 03/06/2018 05:30 PM, Chuck Lever wrote: > > >> On Mar 6, 2018, at 5:07 PM, Chuck Lever wrote: >> >> >> >>> On Mar 6, 2018, at 5:02 PM, Anna Schumaker wrote: >>> >>> Hi Chuck, >>> >>> I'm seeing a huge performance hit with this patch. I'm just running cthon over TCP, and it goes from finishing in 22 seconds to taking well over 5 minutes. I seem to only see this on the read and write tests, such as basic test5 taking a minute to finish: >>> >>> ./test5: read and write >>> wrote 1048576 byte file 10 times in 60.35 seconds (173737 bytes/sec) >>> read 1048576 byte file 10 times in 0.0 seconds (-2147483648 bytes/sec) >>> ./test5 ok. >> >> OK. This looks like write is impacted, but this test doesn't >> actually perform any reads on the wire. Try iozone with -I, >> maybe? That would show results for both read and write. > > Hum. > > Stock v4.16-rc4: > > ./test5: read and write > wrote 1048576 byte file 10 times in 0.2 seconds (350811642 bytes/sec) > read 1048576 byte file 10 times in 0.0 seconds (-2147483648 bytes/sec) > ./test5 ok. > > > v4.16-rc4 with my full set of patches: > > ./test5: read and write > wrote 1048576 byte file 10 times in 0.2 seconds (354236681 bytes/sec) > read 1048576 byte file 10 times in 0.0 seconds (-2147483648 bytes/sec) > ./test5 ok. > > I don't see a regression here. Let me know how it goes! I'm using rc4 too, so maybe it's something different in my setup? Making this change fixes the issue for me: Anna > > >>> I haven't dug into this too deeply, but my best guess is that maybe it's due to adding a call to xprt_request_init() in net/sunrpc/clnt.c:call_reserveresult() >> >> It wasn't added there, it was moved from xprt_alloc_slot. So, >> it's not new work per-RPC. >> >> Any additional information would be appreciated! >> >> >>> Thoughts? >>> Anna >>> >>> On 03/05/2018 03:13 PM, Chuck Lever wrote: >>>> alloc_slot is a transport-specific op, but initializing an rpc_rqst >>>> is common to all transports. Move initialization to common code in >>>> preparation for adding a transport-specific alloc_slot to xprtrdma. >>>> >>>> Signed-off-by: Chuck Lever >>>> --- >>>> include/linux/sunrpc/xprt.h | 1 + >>>> net/sunrpc/clnt.c | 1 + >>>> net/sunrpc/xprt.c | 12 +++++++----- >>>> 3 files changed, 9 insertions(+), 5 deletions(-) >>>> >>>> diff --git a/include/linux/sunrpc/xprt.h b/include/linux/sunrpc/xprt.h >>>> index 5fea0fb..9784e28 100644 >>>> --- a/include/linux/sunrpc/xprt.h >>>> +++ b/include/linux/sunrpc/xprt.h >>>> @@ -324,6 +324,7 @@ struct xprt_class { >>>> struct rpc_xprt *xprt_create_transport(struct xprt_create *args); >>>> void xprt_connect(struct rpc_task *task); >>>> void xprt_reserve(struct rpc_task *task); >>>> +void xprt_request_init(struct rpc_task *task); >>>> void xprt_retry_reserve(struct rpc_task *task); >>>> int xprt_reserve_xprt(struct rpc_xprt *xprt, struct rpc_task *task); >>>> int xprt_reserve_xprt_cong(struct rpc_xprt *xprt, struct rpc_task *task); >>>> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c >>>> index 6e432ec..226f558 100644 >>>> --- a/net/sunrpc/clnt.c >>>> +++ b/net/sunrpc/clnt.c >>>> @@ -1546,6 +1546,7 @@ void rpc_force_rebind(struct rpc_clnt *clnt) >>>> task->tk_status = 0; >>>> if (status >= 0) { >>>> if (task->tk_rqstp) { >>>> + xprt_request_init(task); >>>> task->tk_action = call_refresh; >>>> return; >>>> } >>>> diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c >>>> index 70f0050..a394b46 100644 >>>> --- a/net/sunrpc/xprt.c >>>> +++ b/net/sunrpc/xprt.c >>>> @@ -66,7 +66,7 @@ >>>> * Local functions >>>> */ >>>> static void xprt_init(struct rpc_xprt *xprt, struct net *net); >>>> -static void xprt_request_init(struct rpc_task *, struct rpc_xprt *); >>>> +static __be32 xprt_alloc_xid(struct rpc_xprt *xprt); >>>> static void xprt_connect_status(struct rpc_task *task); >>>> static int __xprt_get_cong(struct rpc_xprt *, struct rpc_task *); >>>> static void __xprt_put_cong(struct rpc_xprt *, struct rpc_rqst *); >>>> @@ -987,6 +987,8 @@ bool xprt_prepare_transmit(struct rpc_task *task) >>>> task->tk_status = -EAGAIN; >>>> goto out_unlock; >>>> } >>>> + if (likely(!bc_prealloc(req))) >>>> + req->rq_xid = xprt_alloc_xid(xprt); >>>> ret = true; >>>> out_unlock: >>>> spin_unlock_bh(&xprt->transport_lock); >>>> @@ -1163,10 +1165,10 @@ void xprt_alloc_slot(struct rpc_xprt *xprt, struct rpc_task *task) >>>> out_init_req: >>>> xprt->stat.max_slots = max_t(unsigned int, xprt->stat.max_slots, >>>> xprt->num_reqs); >>>> + spin_unlock(&xprt->reserve_lock); >>>> + >>>> task->tk_status = 0; >>>> task->tk_rqstp = req; >>>> - xprt_request_init(task, xprt); >>>> - spin_unlock(&xprt->reserve_lock); >>>> } >>>> EXPORT_SYMBOL_GPL(xprt_alloc_slot); >>>> >>>> @@ -1303,8 +1305,9 @@ static inline void xprt_init_xid(struct rpc_xprt *xprt) >>>> xprt->xid = prandom_u32(); >>>> } >>>> >>>> -static void xprt_request_init(struct rpc_task *task, struct rpc_xprt *xprt) >>>> +void xprt_request_init(struct rpc_task *task) >>>> { >>>> + struct rpc_xprt *xprt = task->tk_xprt; >>>> struct rpc_rqst *req = task->tk_rqstp; >>>> >>>> INIT_LIST_HEAD(&req->rq_list); >>>> @@ -1312,7 +1315,6 @@ static void xprt_request_init(struct rpc_task *task, struct rpc_xprt *xprt) >>>> req->rq_task = task; >>>> req->rq_xprt = xprt; >>>> req->rq_buffer = NULL; >>>> - req->rq_xid = xprt_alloc_xid(xprt); >>>> req->rq_connect_cookie = xprt->connect_cookie - 1; >>>> req->rq_bytes_sent = 0; >>>> req->rq_snd_buf.len = 0; >>>> >> >> -- >> Chuck Lever >> >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > Chuck Lever > > > --- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c index a394b4635f8e..273847f7e455 100644 --- a/net/sunrpc/xprt.c +++ b/net/sunrpc/xprt.c @@ -987,8 +987,6 @@ bool xprt_prepare_transmit(struct rpc_task *task) task->tk_status = -EAGAIN; goto out_unlock; } - if (likely(!bc_prealloc(req))) - req->rq_xid = xprt_alloc_xid(xprt); ret = true; out_unlock: spin_unlock_bh(&xprt->transport_lock); @@ -1315,6 +1313,7 @@ void xprt_request_init(struct rpc_task *task) req->rq_task = task; req->rq_xprt = xprt; req->rq_buffer = NULL; + req->rq_xid = xprt_alloc_xid(xprt); req->rq_connect_cookie = xprt->connect_cookie - 1; req->rq_bytes_sent = 0; req->rq_snd_buf.len = 0;