From patchwork Tue Jan 3 20:07:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert LeBlanc X-Patchwork-Id: 9495541 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EB17260413 for ; Tue, 3 Jan 2017 20:07:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DBCBA269E2 for ; Tue, 3 Jan 2017 20:07:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D058F27CAF; Tue, 3 Jan 2017 20:07:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E7FCD27C7A for ; Tue, 3 Jan 2017 20:07:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933004AbdACUHR (ORCPT ); Tue, 3 Jan 2017 15:07:17 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:33040 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761113AbdACUHO (ORCPT ); Tue, 3 Jan 2017 15:07:14 -0500 Received: by mail-oi0-f67.google.com with SMTP id f201so71848774oib.0 for ; Tue, 03 Jan 2017 12:07:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leblancnet-us.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IOHqS/ye17mLMNFrqL/dZ7gg3A2+xNOx3WekP5C/IC4=; b=p0tKFca4IsCjG4Kch/dxMtla5gP//bksje5q3hjwZDJW50xfyR53TqkciphXtL1fMw /HH2xgtVIJUihsrwqlBTxErsVGFwneXzD8PROXmQNbSrDRhnaArc3P2/1BfZNlpYy83w QsUQWjtHkcgOc/sZG3JmgSLsxLtJUhCuRPX9gQFrM7aGhLtn2AH9TTyL8kMmRoq2l0so QC3QHa7RnMhuKksnKdfJK+GmtQbrM7irS5MSmu0XLLTUKooXq1LTHlcXUoN7xWsDKRno xWQ6nEteR2YJmdbNQXdqD+SKl0QYeGSlwD2eCSNQynIO5cUFFk1vdxfElbjhR3C8oz+P VLog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IOHqS/ye17mLMNFrqL/dZ7gg3A2+xNOx3WekP5C/IC4=; b=OdaFlwnOEkHwyGaaatYtM2r0xcd7aj2460R2ZKu6FU2FBd5vSdWDmlhbmLvgihLNeu MwLrxJ/zLwSpLQ0gVOnuWro85i/ZgDXIfi/WB8rpB4l3C5WoRfy44uhIprHGYr6C6s0r +Kr9Drbr8nxjy727bxrPdAIzmEPG2dhtJawpeiBjbwhjgQHZKV3D4BwHAc2JnStOuDMQ sDuogMNq//y/OklnRuRJZIz98hCLzWKnt2iYlmvWZCgQoHGfowMMBxIBlGFQwe7I8QGo uNbqd/MeMoTEVAKyKyv2EjHaiS7v4x42UOnF4zWEvbWKBVxapU4RDRn//RnexKyVkaIu 1G+g== X-Gm-Message-State: AIkVDXK6tKi8X+iPUQe7iqK9fq292vU2aVme+SYkAYZa0j2cKtvJxqdzViiZpxcAU16FLaV+YiYpJ4jZl+H8qQ== X-Received: by 10.202.59.138 with SMTP id i132mr26825612oia.182.1483474032797; Tue, 03 Jan 2017 12:07:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.103.104 with HTTP; Tue, 3 Jan 2017 12:07:11 -0800 (PST) X-Originating-IP: [2001:470:40ba:21:3ac4:8ae4:383f:9873] In-Reply-To: References: <4fc72e32-26fb-96bd-8a0d-814eef712b43@suse.com> <1476774332.8490.43.camel@haakon3.risingtidesystems.com> <1476858359.8490.97.camel@haakon3.risingtidesystems.com> <1477780190.22703.47.camel@haakon3.risingtidesystems.com> <6beeb461-0391-cb29-8cf7-74f4c8feda34@redhat.com> From: Robert LeBlanc Date: Tue, 3 Jan 2017 13:07:11 -0700 Message-ID: Subject: Re: iscsi_trx going into D state To: Doug Ledford Cc: "Nicholas A. Bellinger" , Zhu Lingshan , linux-rdma , linux-scsi@vger.kernel.org, Sagi Grimberg , Christoph Hellwig Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP With this patch I'm not seeing the __ib_drain_sq backtraces, but I'm still seeing the previous backtraces. I was thinking that if the connection was brought down uncleanly then there may be messages(??) it the send queue that would never be consumed by the application, so it would never drain and would have to be forcibly emptied. Maybe there is something stuck in the command queue as well? [(support-1.0) root@prv-0-13-roberttest ~]# ps aux | grep " D " root 15426 0.0 0.0 0 0 ? D 12:48 0:00 [iscsi_np] root 15429 0.0 0.0 0 0 ? D 12:48 0:00 [iscsi_ttx] root 16077 0.0 0.0 112656 2216 pts/0 S+ 12:55 0:00 grep --color=auto D [(support-1.0) root@prv-0-13-roberttest ~]# cat /proc/15426/stack [] iscsit_stop_session+0x1b1/0x1c0 [] iscsi_check_for_session_reinstatement+0x1e2/0x270 [] iscsi_target_check_for_existing_instances+0x30/0x40 [] iscsi_target_do_login+0x138/0x630 [] iscsi_target_start_negotiation+0x4e/0xa0 [] __iscsi_target_login_thread+0x83e/0xf20 [] iscsi_target_login_thread+0x24/0x30 [] kthread+0xd9/0xf0 [] ret_from_fork+0x25/0x30 [] 0xffffffffffffffff [(support-1.0) root@prv-0-13-roberttest ~]# cat /proc/15429/stack [] target_wait_for_sess_cmds+0x49/0x190 [] isert_wait_conn+0x1a4/0x2d0 [ib_isert] [] iscsit_close_connection+0x157/0x860 [] iscsit_take_action_for_connection_exit+0x7b/0xf0 [] iscsi_target_tx_thread+0x150/0x1d0 [] kthread+0xd9/0xf0 [] ret_from_fork+0x25/0x30 [] 0xffffffffffffffff ---------------- Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Fri, Dec 30, 2016 at 4:07 PM, Robert LeBlanc wrote: > I decided to try something completely different... Running the stock > CentOS 3.10 kernel and OFED 3.4 on both hosts, I'm not seeing the hung > processes and the tests complete successfully. The same seems to be > true for the target on 4.9 and the initiator on 3.10. > > However, with the target on 3.10 and the initiator on 4.9, I get this > on the target: > > [(support-1.0) root@prv-0-13-roberttest ~]# ps aux | grep " D " > root 14791 0.0 0.0 0 0 ? D 15:08 0:00 [iscsi_np] > root 14795 0.0 0.0 0 0 ? D 15:08 0:00 [iscsi_trx] > root 14852 0.0 0.0 112648 976 pts/0 S+ 15:11 0:00 grep > --color=auto D > [(support-1.0) root@prv-0-13-roberttest ~]# uname -a > Linux prv-0-13-roberttest.betterservers.com 3.10.0-327.36.3.el7.x86_64 > #1 SMP Mon Oct 24 16:09:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux > [(support-1.0) root@prv-0-13-roberttest ~]# cat /proc/14791/stack > [] iscsit_stop_session+0x1c8/0x1e0 [iscsi_target_mod] > [] iscsi_check_for_session_reinstatement+0x1ea/0x280 > [iscsi_target_mod] > [] > iscsi_target_check_for_existing_instances+0x35/0x40 [iscsi_target_mod] > [] iscsi_target_do_login+0x141/0x670 [iscsi_target_mod] > [] iscsi_target_start_negotiation+0x1c/0xb0 [iscsi_target_mod] > [] iscsi_target_login_thread+0xadf/0x1050 [iscsi_target_mod] > [] kthread+0xcf/0xe0 > [] ret_from_fork+0x58/0x90 > [] 0xffffffffffffffff > [(support-1.0) root@prv-0-13-roberttest ~]# cat /proc/14795/stack > [] isert_wait4flush+0x79/0xc0 [ib_isert] > [] isert_wait_conn+0x5b/0x2d0 [ib_isert] > [] iscsit_close_connection+0x15d/0x820 [iscsi_target_mod] > [] iscsit_take_action_for_connection_exit+0x83/0x110 > [iscsi_target_mod] > [] iscsi_target_rx_thread+0x1e7/0xf80 [iscsi_target_mod] > [] kthread+0xcf/0xe0 > [] ret_from_fork+0x58/0x90 > [] 0xffffffffffffffff > > [ 345.970157] iSCSI Login timeout on Network Portal 0.0.0.0:3260 > [ 483.850714] INFO: task iscsi_np:14791 blocked for more than 120 seconds. > [ 483.857467] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" > disables this message. > [ 483.865326] iscsi_np D 0000000000000000 0 14791 2 0x00000004 > [ 483.872460] ffff886e3b117be0 0000000000000046 ffff887ede579700 > ffff886e3b117fd8 > [ 483.879983] ffff886e3b117fd8 ffff886e3b117fd8 ffff887ede579700 > ffff883ef7898160 > [ 483.887500] ffff883ef7898168 7fffffffffffffff ffff887ede579700 > 0000000000000000 > [ 483.895025] Call Trace: > [ 483.897505] [] schedule+0x29/0x70 > [ 483.902496] [] schedule_timeout+0x209/0x2d0 > [ 483.908355] [] ? simple_strtoull+0x3b/0x70 > [ 483.914128] [] wait_for_completion+0x116/0x170 > [ 483.920253] [] ? wake_up_state+0x20/0x20 > [ 483.925847] [] iscsit_stop_session+0x1c8/0x1e0 > [iscsi_target_mod] > [ 483.933612] [] > iscsi_check_for_session_reinstatement+0x1ea/0x280 [iscsi_target_mod] > [ 483.942944] [] > iscsi_target_check_for_existing_instances+0x35/0x40 [iscsi_target_mod] > [ 483.953304] [] iscsi_target_do_login+0x141/0x670 > [iscsi_target_mod] > [ 483.961988] [] > iscsi_target_start_negotiation+0x1c/0xb0 [iscsi_target_mod] > [ 483.971278] [] > iscsi_target_login_thread+0xadf/0x1050 [iscsi_target_mod] > [ 483.980346] [] ? __schedule+0x1f1/0x900 > [ 483.986525] [] ? > iscsi_target_login_sess_out+0x250/0x250 [iscsi_target_mod] > [ 483.995816] [] kthread+0xcf/0xe0 > [ 484.001403] [] ? kthread_create_on_node+0x140/0x140 > [ 484.008608] [] ret_from_fork+0x58/0x90 > [ 484.014672] [] ? kthread_create_on_node+0x140/0x140 > [ 484.021896] INFO: task iscsi_trx:14795 blocked for more than 120 seconds. > [ 484.029349] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" > disables this message. > [ 484.037849] iscsi_trx D ffff887ee64f8000 0 14795 2 0x00000004 > [ 484.045598] ffff886e391bfbe0 0000000000000046 ffff887ed715c500 > ffff886e391bffd8 > [ 484.053753] ffff886e391bffd8 ffff886e391bffd8 ffff887ed715c500 > ffff887ee64f91d0 > [ 484.061891] ffff887ee64f91d8 7fffffffffffffff ffff887ed715c500 > ffff887ee64f8000 > [ 484.070049] Call Trace: > [ 484.073174] [] schedule+0x29/0x70 > [ 484.078797] [] schedule_timeout+0x209/0x2d0 > [ 484.085290] [] ? cm_alloc_msg+0x115/0x180 [ib_cm] > [ 484.092252] [] wait_for_completion+0x116/0x170 > [ 484.098960] [] ? wake_up_state+0x20/0x20 > [ 484.105132] [] isert_wait4flush+0x79/0xc0 [ib_isert] > [ 484.112369] [] isert_wait_conn+0x5b/0x2d0 [ib_isert] > [ 484.119566] [] > iscsit_close_connection+0x15d/0x820 [iscsi_target_mod] > [ 484.128239] [] ? > wait_for_completion_interruptible+0x167/0x1d0 > [ 484.136341] [] ? > iscsi_target_tx_thread+0x200/0x200 [iscsi_target_mod] > [ 484.145135] [] > iscsit_take_action_for_connection_exit+0x83/0x110 [iscsi_target_mod] > [ 484.155067] [] > iscsi_target_rx_thread+0x1e7/0xf80 [iscsi_target_mod] > [ 484.163700] [] ? __switch_to+0xf8/0x4b0 > [ 484.169774] [] ? > iscsi_target_tx_thread+0x200/0x200 [iscsi_target_mod] > [ 484.178530] [] kthread+0xcf/0xe0 > [ 484.183991] [] ? kthread_create_on_node+0x140/0x140 > [ 484.191106] [] ret_from_fork+0x58/0x90 > [ 484.197096] [] ? kthread_create_on_node+0x140/0x140 > > I think there are two bugs here. Something in 4.9 iser (initiator) is > causing a shutdown of the session when limited to 10 Gb. This second > is in isert (target) where when a session isn't cleanly closed, it > gets hung on cleaning up the session. It seems that bug #1 triggers > bug #2 much easier than on Infiniband. > > I hope this is useful. > > ---------------- > Robert LeBlanc > PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 > > > On Thu, Dec 29, 2016 at 4:57 PM, Robert LeBlanc wrote: >> OK, I've drilled down a little more and >> >> timeout = action(timeout); >> >> in do_wait_for_common() in kernel/sched/completion.c is not returning. >> I'll have to see if I can make more progress tomorrow. >> ---------------- >> Robert LeBlanc >> PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 >> >> >> On Thu, Dec 29, 2016 at 2:23 PM, Robert LeBlanc wrote: >>> I know most people are ignoring this thread by now, but I hope someone >>> is still reading and can offer some ideas. >>> >>> It looks like ib_drain_qp_done() is not being called the first time >>> that __ib_drain_sq() is called from iscsit_close_connection(). I tried >>> to debug wait_for_completion() and friends, but they are called by too >>> many things and I don't know how to filter out what I'm looking for. >>> My next idea is to copy the completion functions here so that I can >>> add debug to only that path. I feel like I'm inching closer to the >>> problem, stumbling around in the dark. >>> >>> [Thu Dec 29 14:02:03 2016] Starting iscsit_close_connection. >>> [Thu Dec 29 14:02:03 2016] isert_wait_conn calling ib_drain_qp. >>> [Thu Dec 29 14:02:03 2016] ib_drain_qp calling ib_drain_sq. >>> [Thu Dec 29 14:02:03 2016] ib_drain_sq calling __ib_drain_sq. >>> [Thu Dec 29 14:02:03 2016] Setting up drain callback. >>> [Thu Dec 29 14:02:03 2016] Starting init_completion. >>> [Thu Dec 29 14:02:03 2016] Calling ib_modify_qp. >>> [Thu Dec 29 14:02:03 2016] Calling ib_post_send. >>> [Thu Dec 29 14:02:03 2016] Calling wait_for_completion. >>> [Thu Dec 29 14:02:03 2016] &sdrain.done->done = 0. >>> >>> Gets "stuck" here... >>> >>> [Thu Dec 29 14:02:20 2016] iSCSI Login timeout on Network Portal 0.0.0.0:3260 >>> [Thu Dec 29 14:02:37 2016] ib_drain_qp calling ib_drain_sq. >>> [Thu Dec 29 14:02:37 2016] ib_drain_sq calling __ib_drain_sq. >>> [Thu Dec 29 14:02:37 2016] Setting up drain callback. >>> [Thu Dec 29 14:02:37 2016] Starting init_completion. >>> [Thu Dec 29 14:02:37 2016] Calling ib_modify_qp. >>> [Thu Dec 29 14:02:37 2016] Calling ib_post_send. >>> [Thu Dec 29 14:02:37 2016] Calling wait_for_completion. >>> [Thu Dec 29 14:02:37 2016] ib_drain_qp_done going to call complete. >>> [Thu Dec 29 14:02:38 2016] &sdrain.done->done = 1. >>> [Thu Dec 29 14:02:38 2016] Returned from wait_for_completion. >>> [Thu Dec 29 14:02:38 2016] ib_drain_qp_done going to call complete. >>> >>> Next time ib_drain_qp is called, ib_drain_qp_done gets called... >>> >>> [Thu Dec 29 14:02:55 2016] ib_drain_qp calling ib_drain_sq. >>> [Thu Dec 29 14:02:55 2016] ib_drain_sq calling __ib_drain_sq. >>> [Thu Dec 29 14:02:55 2016] Setting up drain callback. >>> [Thu Dec 29 14:02:55 2016] Starting init_completion. >>> [Thu Dec 29 14:02:55 2016] Calling ib_modify_qp. >>> [Thu Dec 29 14:02:55 2016] Calling ib_post_send. >>> [Thu Dec 29 14:02:55 2016] Calling wait_for_completion. >>> [Thu Dec 29 14:02:55 2016] ib_drain_qp_done going to call complete. >>> [Thu Dec 29 14:02:55 2016] &sdrain.done->done = 1. >>> [Thu Dec 29 14:02:55 2016] Returned from wait_for_completion. >>> [Thu Dec 29 14:02:55 2016] ib_drain_qp_done going to call complete. >>> ---------------- >>> Robert LeBlanc >>> PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 >>> >>> >>> On Wed, Dec 28, 2016 at 1:58 PM, Robert LeBlanc wrote: >>>> Good news! I found a 10 Gb switch laying around and put it in place of >>>> the Linux router. I'm getting the same failure with the switch, so it >>>> is not something funky with the Linux router and easier to replicate. >>>> ---------------- >>>> Robert LeBlanc >>>> PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 >>>> >>>> >>>> On Wed, Dec 28, 2016 at 1:39 PM, Robert LeBlanc wrote: >>>>> OK, here is some more info. This is a diagram of my current set up. >>>>> >>>>> +----------------+ >>>>> | Linux Router | >>>>> | ConnectX-3 | >>>>> | port 1 port 2 | >>>>> +----------------+ >>>>> / \ >>>>> +---------------+ / \ +---------------+ >>>>> | Host 1 | / A A \ | Host 2 | >>>>> | ConnectX-4-LX | / \ | ConnectX-4-LX | >>>>> | Port 1 |- -| Port 1 | >>>>> | Port 2 |----------------| Port 2 | >>>>> +---------------+ B +---------------+ >>>>> >>>>> The Linux router has the ConnectX-3 (not PRO) card in Ethernet mode >>>>> and is using a breakout cable (port 1 only) to connect to the >>>>> ConnectX-4-LX cards at 10 Gb as path 'A'. The second port of the >>>>> ConnectX-4-LX cards are connected directly at 25 Gb as path 'B'. >>>>> >>>>> Running Iser and RoCE on path 'B' seems to run just fine. >>>>> >>>>> Running Iser and RoCE on path 'A' has issues when the Linux router is >>>>> operating as a bridge or a router. Some small operations like mkfs >>>>> seem to work just fine, but fio causes iser to want to log out and we >>>>> get D state. I can run ib_send_bw 'all' tests through path 'A' and >>>>> don't see a problem. It does seem to be load related, though. I have >>>>> been trying to run >>>>> >>>>> echo "3" > /proc/sys/vm/drop_caches; fio --rw=read --bs=4K --size=1G >>>>> --numjobs=40 --name=worker.matt --group_reporting >>>>> >>>>> If I reduce the number of jobs to 10 or less, it seems to work >>>>> although I may see some of the debug messages I added in, it doesn't >>>>> seem to completely hang and cause the logout lockup. >>>>> >>>>> Steps to reproduce: >>>>> 1. 4.9 kernel >>>>> 2. Bridge ports 1 & 2 on the Linux router >>>>> 3. Configure port 1 on Host 1 & 2 on the same subnet >>>>> 4. Create large ramdisk in targetcli and export from Host 1 >>>>> 5. Login from Host 2 >>>>> 6. Create EXT4 file system on imported disk >>>>> 7. Mount and cd into mount >>>>> 8. Run fio: echo "3" > /proc/sys/vm/drop_caches; fio --rw=read --bs=4K >>>>> --size=1G --numjobs=40 --name=worker.matt --group_reporting >>>>> 9. After some time, the fio process will report the file system is >>>>> read only and the iscsi processes will be in D state on Host 1 >>>>> >>>>> It does seem the problem is in iser and not specific to the generic RDMA stack. >>>>> >>>>> I'll keep digging and reporting back. >>>>> ---------------- >>>>> Robert LeBlanc >>>>> PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 >>>>> >>>>> >>>>> On Tue, Dec 27, 2016 at 1:58 PM, Robert LeBlanc wrote: >>>>>> I realized that I did not set the default RoCE mode to v2 and the >>>>>> client is on a different subnet, probably why I'm seeing the -110 >>>>>> error. Iser should not go into D state because of this and should >>>>>> handle this gracefully, but may provide an easy way to replicate the >>>>>> issue. >>>>>> ---------------- >>>>>> Robert LeBlanc >>>>>> PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 >>>>>> >>>>>> >>>>>> On Tue, Dec 27, 2016 at 1:22 PM, Robert LeBlanc wrote: >>>>>>> I looked at this code and it is quiet above my ability. I created this >>>>>>> patch, but I don't know how to interrogate the queue to see how many >>>>>>> items there are. If you can give me some more direction on what to >>>>>>> try, I can keep fumbling around with this until someone smarter than >>>>>>> me can figure it out. This is now a blocker for me so I'm going to >>>>>>> beat my head on this until it is fixed. >>>>>>> >>>>>>> Thanks for being patient with me. >>>>>>> >>>>>>> diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c >>>>>>> index 8368764..9e5bd4b 100644 >>>>>>> --- a/drivers/infiniband/core/verbs.c >>>>>>> +++ b/drivers/infiniband/core/verbs.c >>>>>>> @@ -1954,22 +1954,27 @@ static void __ib_drain_sq(struct ib_qp *qp) >>>>>>> return; >>>>>>> } >>>>>>> >>>>>>> + printk("Setting up drain callback."); >>>>>>> swr.wr_cqe = &sdrain.cqe; >>>>>>> sdrain.cqe.done = ib_drain_qp_done; >>>>>>> + printk("Starting init_completion."); >>>>>>> init_completion(&sdrain.done); >>>>>>> >>>>>>> + printk("Calling ib_modify_qp."); >>>>>>> ret = ib_modify_qp(qp, &attr, IB_QP_STATE); >>>>>>> if (ret) { >>>>>>> WARN_ONCE(ret, "failed to drain send queue: %d\n", ret); >>>>>>> return; >>>>>>> } >>>>>>> >>>>>>> + printk("Calling ib_post_send."); >>>>>>> ret = ib_post_send(qp, &swr, &bad_swr); >>>>>>> if (ret) { >>>>>>> WARN_ONCE(ret, "failed to drain send queue: %d\n", ret); >>>>>>> return; >>>>>>> } >>>>>>> >>>>>>> + printk("Starting wait_for_completion."); >>>>>>> wait_for_completion(&sdrain.done); >>>>>>> } >>>>>>> >>>>>>> I get the same processes in D state (and same backtrace) and this is >>>>>>> what shows up in dmesg: >>>>>>> >>>>>>> [ 920.317401] isert: isert_rdma_accept: rdma_accept() failed with: -110 >>>>>>> [ 920.325554] ------------[ cut here ]------------ >>>>>>> [ 920.330188] WARNING: CPU: 11 PID: 705 at >>>>>>> drivers/infiniband/core/verbs.c:303 ib_dealloc_pd+0x58/0xa0 [ib_core] >>>>>>> [ 920.340210] Modules linked in: target_core_user target_core_pscsi >>>>>>> target_core_file target_core_iblock 8021q garp mrp rpcrdma sunrpc >>>>>>> ib_isert ib_iser ib_srpt ib_srp scsi_transport_srp ib_ipoib >>>>>>> iptable_filter rdma_ucm i >>>>>>> b_ucm ib_uverbs ib_umad rdma_cm ib_cm iw_cm sb_edac edac_core >>>>>>> x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm ext4 >>>>>>> ipmi_devintf irqbypass crct10dif_pclmul crc32_pclmul >>>>>>> ghash_clmulni_intel aesni_intel jbd2 lr >>>>>>> w gf128mul glue_helper mbcache iTCO_wdt ablk_helper mei_me >>>>>>> iTCO_vendor_support cryptd joydev sg mei i2c_i801 lpc_ich pcspkr >>>>>>> mfd_core ioatdma shpchp i2c_smbus ipmi_si wmi ipmi_msghandler >>>>>>> acpi_power_meter acpi_pad ip_table >>>>>>> s xfs libcrc32c raid1 mlx4_en mlx4_ib mlx5_ib sd_mod ib_core ast >>>>>>> drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm >>>>>>> mlx5_core igb mlx4_core >>>>>>> [ 920.412347] ahci ptp drm libahci pps_core libata dca i2c_algo_bit >>>>>>> be2iscsi bnx2i cnic uio qla4xxx iscsi_boot_sysfs >>>>>>> [ 920.421744] CPU: 11 PID: 705 Comm: kworker/11:2 Not tainted 4.9.0+ #3 >>>>>>> [ 920.428199] Hardware name: Supermicro SYS-6028TP-HTFR/X10DRT-PIBF, >>>>>>> BIOS 1.1 08/03/2015 >>>>>>> [ 920.436126] Workqueue: ib_cm cm_work_handler [ib_cm] >>>>>>> [ 920.441113] ffffc90032a03a40 ffffffff8134d45f 0000000000000000 >>>>>>> 0000000000000000 >>>>>>> [ 920.448583] ffffc90032a03a80 ffffffff81083371 0000012fa04a1c4a >>>>>>> ffff883f5e886e80 >>>>>>> [ 920.456073] ffff887f1eaa4400 ffff887f1eaa5800 ffffc90032a03b08 >>>>>>> 00000000ffffff92 >>>>>>> [ 920.463535] Call Trace: >>>>>>> [ 920.465993] [] dump_stack+0x63/0x84 >>>>>>> [ 920.471144] [] __warn+0xd1/0xf0 >>>>>>> [ 920.475941] [] warn_slowpath_null+0x1d/0x20 >>>>>>> [ 920.481790] [] ib_dealloc_pd+0x58/0xa0 [ib_core] >>>>>>> [ 920.488072] [] isert_device_put+0x50/0xc0 [ib_isert] >>>>>>> [ 920.494693] [] isert_connect_request+0x68e/0xd40 >>>>>>> [ib_isert] >>>>>>> [ 920.501924] [] isert_cma_handler+0xe3/0x3b0 [ib_isert] >>>>>>> [ 920.508725] [] ? cma_new_conn_id+0x276/0x4b0 [rdma_cm] >>>>>>> [ 920.515521] [] cma_listen_handler+0x20/0x30 [rdma_cm] >>>>>>> [ 920.522227] [] cma_req_handler+0x1f5/0x4c0 [rdma_cm] >>>>>>> [ 920.528851] [] cm_process_work+0x25/0xf0 [ib_cm] >>>>>>> [ 920.535125] [] cm_req_handler+0x8d4/0xc70 [ib_cm] >>>>>>> [ 920.541485] [] cm_work_handler+0x1ce/0x1648 [ib_cm] >>>>>>> [ 920.548021] [] process_one_work+0x152/0x400 >>>>>>> [ 920.553861] [] worker_thread+0x125/0x4b0 >>>>>>> [ 920.559443] [] ? rescuer_thread+0x380/0x380 >>>>>>> [ 920.565284] [] kthread+0xd9/0xf0 >>>>>>> [ 920.570178] [] ? kthread_park+0x60/0x60 >>>>>>> [ 920.576389] [] ret_from_fork+0x25/0x30 >>>>>>> [ 920.582473] ---[ end trace 1f5a1831f9d2d964 ]--- >>>>>>> [ 920.587907] ------------[ cut here ]------------ >>>>>>> [ 920.593213] WARNING: CPU: 11 PID: 705 at >>>>>>> drivers/infiniband/core/cq.c:189 ib_free_cq+0x97/0xc0 [ib_core] >>>>>>> [ 920.603383] Modules linked in: target_core_user target_core_pscsi >>>>>>> target_core_file target_core_iblock 8021q garp mrp rpcrdma sunrpc >>>>>>> ib_isert ib_iser ib_srpt ib_srp scsi_transport_srp ib_ipoib >>>>>>> iptable_filter rdma_ucm i >>>>>>> b_ucm ib_uverbs ib_umad rdma_cm ib_cm iw_cm sb_edac edac_core >>>>>>> x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm ext4 >>>>>>> ipmi_devintf irqbypass crct10dif_pclmul crc32_pclmul >>>>>>> ghash_clmulni_intel aesni_intel jbd2 lr >>>>>>> w gf128mul glue_helper mbcache iTCO_wdt ablk_helper mei_me >>>>>>> iTCO_vendor_support cryptd joydev sg mei i2c_i801 lpc_ich pcspkr >>>>>>> mfd_core ioatdma shpchp i2c_smbus ipmi_si wmi ipmi_msghandler >>>>>>> acpi_power_meter acpi_pad ip_table >>>>>>> s xfs libcrc32c raid1 mlx4_en mlx4_ib mlx5_ib sd_mod ib_core ast >>>>>>> drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm >>>>>>> mlx5_core igb mlx4_core >>>>>>> [ 920.679694] ahci ptp drm libahci pps_core libata dca i2c_algo_bit >>>>>>> be2iscsi bnx2i cnic uio qla4xxx iscsi_boot_sysfs >>>>>>> [ 920.690579] CPU: 11 PID: 705 Comm: kworker/11:2 Tainted: G W >>>>>>> 4.9.0+ #3 >>>>>>> [ 920.699008] Hardware name: Supermicro SYS-6028TP-HTFR/X10DRT-PIBF, >>>>>>> BIOS 1.1 08/03/2015 >>>>>>> [ 920.707701] Workqueue: ib_cm cm_work_handler [ib_cm] >>>>>>> [ 920.713438] ffffc90032a03a18 ffffffff8134d45f 0000000000000000 >>>>>>> 0000000000000000 >>>>>>> [ 920.721648] ffffc90032a03a58 ffffffff81083371 000000bd5e886e80 >>>>>>> ffff887f1eaa6800 >>>>>>> [ 920.729850] ffff883f5e886e20 ffff883f5e886e18 ffffc90032a03b08 >>>>>>> 00000000ffffff92 >>>>>>> [ 920.738026] Call Trace: >>>>>>> [ 920.741188] [] dump_stack+0x63/0x84 >>>>>>> [ 920.747027] [] __warn+0xd1/0xf0 >>>>>>> [ 920.752488] [] warn_slowpath_null+0x1d/0x20 >>>>>>> [ 920.758989] [] ib_free_cq+0x97/0xc0 [ib_core] >>>>>>> [ 920.765649] [] >>>>>>> isert_free_comps.isra.26+0x38/0x60 [ib_isert] >>>>>>> [ 920.773609] [] isert_device_put+0x5d/0xc0 [ib_isert] >>>>>>> [ 920.780868] [] isert_connect_request+0x68e/0xd40 >>>>>>> [ib_isert] >>>>>>> [ 920.788734] [] isert_cma_handler+0xe3/0x3b0 [ib_isert] >>>>>>> [ 920.796157] [] ? cma_new_conn_id+0x276/0x4b0 [rdma_cm] >>>>>>> [ 920.803586] [] cma_listen_handler+0x20/0x30 [rdma_cm] >>>>>>> [ 920.810916] [] cma_req_handler+0x1f5/0x4c0 [rdma_cm] >>>>>>> [ 920.818167] [] cm_process_work+0x25/0xf0 [ib_cm] >>>>>>> [ 920.825063] [] cm_req_handler+0x8d4/0xc70 [ib_cm] >>>>>>> [ 920.832051] [] cm_work_handler+0x1ce/0x1648 [ib_cm] >>>>>>> [ 920.839208] [] process_one_work+0x152/0x400 >>>>>>> [ 920.845669] [] worker_thread+0x125/0x4b0 >>>>>>> [ 920.851880] [] ? rescuer_thread+0x380/0x380 >>>>>>> [ 920.858352] [] kthread+0xd9/0xf0 >>>>>>> [ 920.863857] [] ? kthread_park+0x60/0x60 >>>>>>> [ 920.869975] [] ret_from_fork+0x25/0x30 >>>>>>> [ 920.876006] ---[ end trace 1f5a1831f9d2d965 ]--- >>>>>>> [ 920.884335] isert: isert_cma_handler: failed handle connect request -110 >>>>>>> [ 1639.592451] Setting up drain callback. >>>>>>> [ 1639.596073] Starting init_completion. >>>>>>> [ 1639.600683] Calling ib_modify_qp. >>>>>>> [ 1639.602616] Calling ib_post_send. >>>>>>> [ 1639.606550] Starting wait_for_completion. >>>>>>> [ 1656.976015] iSCSI Login timeout on Network Portal 0.0.0.0:3260 >>>>>>> [ 1674.254027] Setting up drain callback. >>>>>>> [ 1674.257634] Starting init_completion. >>>>>>> [ 1674.262107] Calling ib_modify_qp. >>>>>>> [ 1674.264011] Calling ib_post_send. >>>>>>> [ 1674.267969] Starting wait_for_completion. >>>>>>> [ 1691.583888] Setting up drain callback. >>>>>>> [ 1691.588490] Starting init_completion. >>>>>>> [ 1691.590677] Calling ib_modify_qp. >>>>>>> [ 1691.594766] Calling ib_post_send. >>>>>>> [ 1691.596607] Starting wait_for_completion. >>>>>>> [ 1708.913356] Setting up drain callback. >>>>>>> [ 1708.915658] Starting init_completion. >>>>>>> [ 1708.920152] Calling ib_modify_qp. >>>>>>> [ 1708.922041] Calling ib_post_send. >>>>>>> [ 1708.926048] Starting wait_for_completion. >>>>>>> [ 1726.244365] Setting up drain callback. >>>>>>> [ 1726.248973] Starting init_completion. >>>>>>> [ 1726.251165] Calling ib_modify_qp. >>>>>>> [ 1726.255189] Calling ib_post_send. >>>>>>> [ 1726.257031] Starting wait_for_completion. >>>>>>> [ 1743.574751] Setting up drain callback. >>>>>>> [ 1743.577044] Starting init_completion. >>>>>>> [ 1743.581496] Calling ib_modify_qp. >>>>>>> [ 1743.583404] Calling ib_post_send. >>>>>>> [ 1743.587346] Starting wait_for_completion. >>>>>>> [ 1760.904470] Setting up drain callback. >>>>>>> [ 1760.908991] Starting init_completion. >>>>>>> [ 1760.911206] Calling ib_modify_qp. >>>>>>> [ 1760.915214] Calling ib_post_send. >>>>>>> [ 1760.917062] Starting wait_for_completion. >>>>>>> [ 1778.230821] Setting up drain callback. >>>>>>> [ 1778.233116] Starting init_completion. >>>>>>> [ 1778.237510] Calling ib_modify_qp. >>>>>>> [ 1778.239413] Calling ib_post_send. >>>>>>> .... [keeps repeating] >>>>>>> ---------------- >>>>>>> Robert LeBlanc >>>>>>> PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 >>>>>>> >>>>>>> >>>>>>> On Thu, Dec 22, 2016 at 12:15 PM, Doug Ledford wrote: >>>>>>>> On 12/21/2016 6:39 PM, Robert LeBlanc wrote: >>>>>>>>> I hit a new backtrace today, hopefully it adds something. >>>>>>>>> >>>>>>>>> # cat /proc/19659/stack >>>>>>>>> [] iscsit_stop_session+0x1b1/0x1c0 >>>>>>>>> [] iscsi_check_for_session_reinstatement+0x1e2/0x270 >>>>>>>>> [] iscsi_target_check_for_existing_instances+0x30/0x40 >>>>>>>>> [] iscsi_target_do_login+0x138/0x630 >>>>>>>>> [] iscsi_target_start_negotiation+0x4e/0xa0 >>>>>>>>> [] __iscsi_target_login_thread+0x83e/0xf20 >>>>>>>>> [] iscsi_target_login_thread+0x24/0x30 >>>>>>>>> [] kthread+0xd9/0xf0 >>>>>>>>> [] ret_from_fork+0x25/0x30 >>>>>>>>> [] 0xffffffffffffffff >>>>>>>>> >>>>>>>>> # cat /proc/21342/stack >>>>>>>>> [] __ib_drain_sq+0x190/0x1c0 [ib_core] >>>>>>>>> [] ib_drain_sq+0x25/0x30 [ib_core] >>>>>>>>> [] ib_drain_qp+0x12/0x30 [ib_core] >>>>>>>>> [] isert_wait_conn+0x5f/0x2d0 [ib_isert] >>>>>>>>> [] iscsit_close_connection+0x157/0x860 >>>>>>>>> [] iscsit_take_action_for_connection_exit+0x7b/0xf0 >>>>>>>>> [] iscsi_target_rx_thread+0x95/0xa0 >>>>>>>>> [] kthread+0xd9/0xf0 >>>>>>>>> [] ret_from_fork+0x25/0x30 >>>>>>>>> [] 0xffffffffffffffff >>>>>>>>> >>>>>>>>> # ps aux | grep iscsi | grep D >>>>>>>>> root 19659 0.0 0.0 0 0 ? D 16:12 0:00 [iscsi_np] >>>>>>>>> root 21342 0.0 0.0 0 0 ? D 16:29 0:00 [iscsi_trx] >>>>>>>>> ---------------- >>>>>>>>> Robert LeBlanc >>>>>>>>> PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 >>>>>>>> >>>>>>>> That looks suspiciously like the __ib_drain_sq is stuck forever waiting >>>>>>>> on a completion that never comes. >>>>>>>> >>>>>>>>> >>>>>>>>> On Thu, Dec 15, 2016 at 1:38 PM, Robert LeBlanc wrote: >>>>>>>>>> Nicholas, >>>>>>>>>> >>>>>>>>>> I've found that the kernels I used were not able to be inspected using >>>>>>>>>> crash and I could not build the debug info for them. So I built a new >>>>>>>>>> 4.9 kernel and verified that I could inspect the crash. It is located >>>>>>>>>> at [1]. >>>>>>>>>> >>>>>>>>>> [1] http://mirrors.betterservers.com/trace/crash2.tar.xz >>>>>>>>>> ---------------- >>>>>>>>>> Robert LeBlanc >>>>>>>>>> PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Mon, Dec 12, 2016 at 4:57 PM, Robert LeBlanc wrote: >>>>>>>>>>> Nicholas, >>>>>>>>>>> >>>>>>>>>>> After lots of set backs and having to give up trying to get kernel >>>>>>>>>>> dumps on our "production" systems, I've been able to work out the >>>>>>>>>>> issues we had with kdump and replicate the issue on my dev boxes. I >>>>>>>>>>> have dumps from 4.4.30 and 4.9-rc8 (makedumpfile would not dump, so it >>>>>>>>>>> is a straight copy of /proc/vmcore from the crash kernel). In each >>>>>>>>>>> crash directory, I put a details.txt file that has the process IDs >>>>>>>>>>> that were having problems and a brief description of the set-up at the >>>>>>>>>>> time. This was mostly replicated by starting fio and pulling the >>>>>>>>>>> Infiniband cable until fio gave up. This hardware also has Mellanox >>>>>>>>>>> ConnectX4-LX cards and I also replicated the issue over RoCE using 4.9 >>>>>>>>>>> since it has the drivers in-box. Please let me know if you need more >>>>>>>>>>> info, I can test much faster now. The cores/kernels/modules are >>>>>>>>>>> located at [1]. >>>>>>>>>>> >>>>>>>>>>> [1] http://mirrors.betterservers.com/trace/crash.tar.xz >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Robert >>>>>>>>>>> ---------------- >>>>>>>>>>> Robert LeBlanc >>>>>>>>>>> PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Fri, Nov 4, 2016 at 3:57 PM, Robert LeBlanc wrote: >>>>>>>>>>>> We hit this yesterday, this time it was on the tx thread (the other >>>>>>>>>>>> ones before seem to be on the rx thread). We weren't able to get a >>>>>>>>>>>> kernel dump on this. We'll try to get one next time. >>>>>>>>>>>> >>>>>>>>>>>> # ps axuw | grep "D.*iscs[i]" >>>>>>>>>>>> root 12383 0.0 0.0 0 0 ? D Nov03 0:04 [iscsi_np] >>>>>>>>>>>> root 23016 0.0 0.0 0 0 ? D Nov03 0:00 [iscsi_ttx] >>>>>>>>>>>> root 23018 0.0 0.0 0 0 ? D Nov03 0:00 [iscsi_ttx] >>>>>>>>>>>> # cat /proc/12383/stack >>>>>>>>>>>> [] iscsit_stop_session+0x19f/0x1d0 >>>>>>>>>>>> [] iscsi_check_for_session_reinstatement+0x1e6/0x270 >>>>>>>>>>>> [] iscsi_target_check_for_existing_instances+0x30/0x40 >>>>>>>>>>>> [] iscsi_target_do_login+0x140/0x640 >>>>>>>>>>>> [] iscsi_target_start_negotiation+0x1c/0xb0 >>>>>>>>>>>> [] iscsi_target_login_thread+0xa9b/0xfc0 >>>>>>>>>>>> [] kthread+0xd8/0xf0 >>>>>>>>>>>> [] ret_from_fork+0x3f/0x70 >>>>>>>>>>>> [] 0xffffffffffffffff >>>>>>>>>>>> # cat /proc/23016/stack >>>>>>>>>>>> [] target_wait_for_sess_cmds+0x49/0x1a0 >>>>>>>>>>>> [] isert_wait_conn+0x1ab/0x2f0 [ib_isert] >>>>>>>>>>>> [] iscsit_close_connection+0x162/0x870 >>>>>>>>>>>> [] iscsit_take_action_for_connection_exit+0x7f/0x100 >>>>>>>>>>>> [] iscsi_target_tx_thread+0x1aa/0x1d0 >>>>>>>>>>>> [] kthread+0xd8/0xf0 >>>>>>>>>>>> [] ret_from_fork+0x3f/0x70 >>>>>>>>>>>> [] 0xffffffffffffffff >>>>>>>>>>>> # cat /proc/23018/stack >>>>>>>>>>>> [] target_wait_for_sess_cmds+0x49/0x1a0 >>>>>>>>>>>> [] isert_wait_conn+0x1ab/0x2f0 [ib_isert] >>>>>>>>>>>> [] iscsit_close_connection+0x162/0x870 >>>>>>>>>>>> [] iscsit_take_action_for_connection_exit+0x7f/0x100 >>>>>>>>>>>> [] iscsi_target_tx_thread+0x1aa/0x1d0 >>>>>>>>>>>> [] kthread+0xd8/0xf0 >>>>>>>>>>>> [] ret_from_fork+0x3f/0x70 >>>>>>>>>>>> [] 0xffffffffffffffff >>>>>>>>>>>> >>>>>>>>>>>> From dmesg: >>>>>>>>>>>> [ 394.476332] INFO: rcu_sched self-detected stall on CPU >>>>>>>>>>>> [ 394.476334] 20-...: (23976 ticks this GP) >>>>>>>>>>>> idle=edd/140000000000001/0 softirq=292/292 fqs=18788 >>>>>>>>>>>> [ 394.476336] (t=24003 jiffies g=3146 c=3145 q=0) >>>>>>>>>>>> [ 394.476337] Task dump for CPU 20: >>>>>>>>>>>> [ 394.476338] kworker/u68:2 R running task 0 12906 2 0x00000008 >>>>>>>>>>>> [ 394.476345] Workqueue: isert_comp_wq isert_cq_work [ib_isert] >>>>>>>>>>>> [ 394.476346] ffff883f2fe38000 00000000f805705e ffff883f7fd03da8 >>>>>>>>>>>> ffffffff810ac8ff >>>>>>>>>>>> [ 394.476347] 0000000000000014 ffffffff81adb680 ffff883f7fd03dc0 >>>>>>>>>>>> ffffffff810af239 >>>>>>>>>>>> [ 394.476348] 0000000000000015 ffff883f7fd03df0 ffffffff810e1cd0 >>>>>>>>>>>> ffff883f7fd17b80 >>>>>>>>>>>> [ 394.476348] Call Trace: >>>>>>>>>>>> [ 394.476354] [] sched_show_task+0xaf/0x110 >>>>>>>>>>>> [ 394.476355] [] dump_cpu_task+0x39/0x40 >>>>>>>>>>>> [ 394.476357] [] rcu_dump_cpu_stacks+0x80/0xb0 >>>>>>>>>>>> [ 394.476359] [] rcu_check_callbacks+0x540/0x820 >>>>>>>>>>>> [ 394.476360] [] ? account_system_time+0x81/0x110 >>>>>>>>>>>> [ 394.476363] [] ? tick_sched_do_timer+0x50/0x50 >>>>>>>>>>>> [ 394.476364] [] update_process_times+0x39/0x60 >>>>>>>>>>>> [ 394.476365] [] tick_sched_handle.isra.17+0x25/0x60 >>>>>>>>>>>> [ 394.476366] [] tick_sched_timer+0x3d/0x70 >>>>>>>>>>>> [ 394.476368] [] __hrtimer_run_queues+0x102/0x290 >>>>>>>>>>>> [ 394.476369] [] hrtimer_interrupt+0xa8/0x1a0 >>>>>>>>>>>> [ 394.476372] [] local_apic_timer_interrupt+0x35/0x60 >>>>>>>>>>>> [ 394.476374] [] smp_apic_timer_interrupt+0x3d/0x50 >>>>>>>>>>>> [ 394.476376] [] apic_timer_interrupt+0x87/0x90 >>>>>>>>>>>> [ 394.476379] [] ? console_unlock+0x41e/0x4e0 >>>>>>>>>>>> [ 394.476380] [] vprintk_emit+0x2fc/0x500 >>>>>>>>>>>> [ 394.476382] [] vprintk_default+0x1f/0x30 >>>>>>>>>>>> [ 394.476384] [] printk+0x5d/0x74 >>>>>>>>>>>> [ 394.476388] [] transport_lookup_cmd_lun+0x1d1/0x200 >>>>>>>>>>>> [ 394.476390] [] iscsit_setup_scsi_cmd+0x230/0x540 >>>>>>>>>>>> [ 394.476392] [] isert_rx_do_work+0x3f3/0x7f0 [ib_isert] >>>>>>>>>>>> [ 394.476394] [] isert_cq_work+0x184/0x770 [ib_isert] >>>>>>>>>>>> [ 394.476396] [] process_one_work+0x14f/0x400 >>>>>>>>>>>> [ 394.476397] [] worker_thread+0x114/0x470 >>>>>>>>>>>> [ 394.476398] [] ? __schedule+0x34a/0x7f0 >>>>>>>>>>>> [ 394.476399] [] ? rescuer_thread+0x310/0x310 >>>>>>>>>>>> [ 394.476400] [] kthread+0xd8/0xf0 >>>>>>>>>>>> [ 394.476402] [] ? kthread_park+0x60/0x60 >>>>>>>>>>>> [ 394.476403] [] ret_from_fork+0x3f/0x70 >>>>>>>>>>>> [ 394.476404] [] ? kthread_park+0x60/0x60 >>>>>>>>>>>> [ 405.716632] Unexpected ret: -104 send data 360 >>>>>>>>>>>> [ 405.721711] tx_data returned -32, expecting 360. >>>>>>>>>>>> ---------------- >>>>>>>>>>>> Robert LeBlanc >>>>>>>>>>>> PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 >>>>>>>> >>>>>>>> When you combine this trace with the newest one, it really makes me >>>>>>>> thing there is something of a bad interaction between the new drain cq >>>>>>>> API and the iser/isert implementation to use said API. Sagi, Christoph? >>>>>>>> >>>>>>>> -- >>>>>>>> Doug Ledford >>>>>>>> GPG Key ID: B826A3330E572FDD >>>>>>>> Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD >>>>>>>> --- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c index 6dd43f6..1e53502 100644 --- a/drivers/infiniband/ulp/isert/ib_isert.c +++ b/drivers/infiniband/ulp/isert/ib_isert.c @@ -2595,7 +2595,7 @@ static void isert_wait_conn(struct iscsi_conn *conn) isert_conn_terminate(isert_conn); mutex_unlock(&isert_conn->mutex); - ib_drain_qp(isert_conn->qp); + ib_close_qp(isert_conn->qp); isert_put_unsol_pending_cmds(conn); isert_wait4cmds(conn); isert_wait4logout(isert_conn);