| Message ID | CAG53R5WnJy1cLdEZOpzk03aAE2L6v86n_-qEBpoaG+arymCxPw@mail.gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Tue, 2017-01-03 at 12:39 -0600, Parav Pandit wrote: > Additionally, since struct rxe_send_wqe is not used in get_mtu() function, > Can you please update signature to just have rxe_qp* as input argument? Thanks for the feedback Leon and Parav. BTW, feedback for the other patches of this series would also be welcome. Bart.-- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 04, 2017 at 10:37:07AM +0000, Bart Van Assche wrote: > On Tue, 2017-01-03 at 12:39 -0600, Parav Pandit wrote: > > Additionally, since struct rxe_send_wqe is not used in get_mtu() function, > > Can you please update signature to just have rxe_qp* as input argument? > > Thanks for the feedback Leon and Parav. BTW, feedback for the other patches > of this series would also be welcome. I will try to do my best. Thanks > > Bart.-- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c index 73d4a97603a1..b95b6035e988 100644 --- a/drivers/infiniband/sw/rxe/rxe_req.c +++ b/drivers/infiniband/sw/rxe/rxe_req.c @@ -364,16 +364,11 @@ static inline int check_init_depth(struct rxe_qp *qp, struct rxe_send_wqe *wqe) static inline int get_mtu(struct rxe_qp *qp, struct rxe_send_wqe *wqe) { struct rxe_dev *rxe = to_rdev(qp->ibqp.device); - struct rxe_port *port; - struct rxe_av *av; if ((qp_type(qp) == IB_QPT_RC) || (qp_type(qp) == IB_QPT_UC)) return qp->mtu; - av = &wqe->av; - port = &rxe->port; - - return port->mtu_cap; + return rxe->port.mtu_cap; }
Hi Bart, Additionally, since struct rxe_send_wqe is not used in get_mtu() function, Can you please update signature to just have rxe_qp* as input argument? Parav On Jan 2, 2017 5:05 AM, "Bart Van Assche" <Bart.VanAssche@sandisk.com> wrote: The variable 'av' is not used so remove it. Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Cc: Moni Shoua <monis@mellanox.com> Cc: Andrew Boyer <andrew.boyer@dell.com> --- drivers/infiniband/sw/rxe/rxe_req.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) static struct sk_buff *init_req_packet(struct rxe_qp *qp,