From patchwork Tue Jan 3 18:39:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Parav Pandit X-Patchwork-Id: 9495449 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 42247606B4 for ; Tue, 3 Jan 2017 18:40:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 399F626CFC for ; Tue, 3 Jan 2017 18:40:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2E4EE271FD; Tue, 3 Jan 2017 18:40:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D4EE271E0 for ; Tue, 3 Jan 2017 18:40:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760635AbdACSkD (ORCPT ); Tue, 3 Jan 2017 13:40:03 -0500 Received: from mail-yw0-f193.google.com ([209.85.161.193]:36389 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760622AbdACSjy (ORCPT ); Tue, 3 Jan 2017 13:39:54 -0500 Received: by mail-yw0-f193.google.com with SMTP id r204so39339145ywb.3 for ; Tue, 03 Jan 2017 10:39:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Fsbv9SEsM+hjVLDV6nft3cqn8M+6lYyp6bq81Hib/f0=; b=tmaimanxdwg/8Odwvy4WP+wuchU9PYetoSEq+PdWeQv8XCIMcIzOzLjnSopsFhVsE/ iXOCY7Ye0d2qTh89WwKfDkPttEHuJM9vekIT/9aOqzRcE+5oXnE5FgJ6wu+9mqS9ywSh rdqG8c/ZIyCL5MejDMBcirN+ALHHwnCNQ3BGBSRnlZjN65sSx6WWi9dk9pQ/PkHifLRk wwiBWWNIxgOR6T4BC3yh2C/syDxD+xAav+2shDENW7j+RX2tUQ3v3sNZvIW63fqC+6aP LZhG79IBoFZPMz2b0YsrILH9QaWv4YW8JrYR0kMFcYEv1Vdw2q0+wp1bDZfSXtooRc6u aXFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Fsbv9SEsM+hjVLDV6nft3cqn8M+6lYyp6bq81Hib/f0=; b=REwITpb9o9i7WzxeK4t51w2rvxzvKj+a6lhWAFDPRtVhgibtiOesdLnXirV3+ia/VZ 2DFGuC5/uohiLHvTwpp9S8cMZjnH93JNhCfY68yK3ROSWVZiz1XOZQmiOioJkFvrP31/ Ez+eJXilSdevwyme2jJtOs2zP3J1UvEDm+/4rZdh8PMGHGUQ+j7Sgyn+/qm+Aw5FzcMp Sg6uTJ8HXBcRmJ0cL+5nQ2152nMFHIBZooRgG0N0EnLDAqRyPFA8tFCtfkBSZMNFRGZs 5qMkqFe99pk97rU3F3fyt3S4cF29eYDNgPFLgR1WhZIrYPSdxB9Vuz19yKknUgKCixYg ZCsA== X-Gm-Message-State: AIkVDXI459zVr37ujxHju/54EZB9gLnBfI9z6IZvGi2QWURp6UvBUCyVl2uwu7Bh0fsoQlmjsSNZmhFv1LMxqg== X-Received: by 10.13.199.193 with SMTP id j184mr58354922ywd.339.1483468793264; Tue, 03 Jan 2017 10:39:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.181.65 with HTTP; Tue, 3 Jan 2017 10:39:52 -0800 (PST) In-Reply-To: <1483353498.3592.20.camel@sandisk.com> References: <1483353316.3592.14.camel@sandisk.com> <1483353498.3592.20.camel@sandisk.com> From: Parav Pandit Date: Tue, 3 Jan 2017 12:39:52 -0600 Message-ID: Subject: Re: [PATCH 04/15] IB/rxe: Remove an unused variable To: Bart Van Assche Cc: Moni Shoua , Doug Ledford , "linux-rdma@vger.kernel.org" , "andrew.boyer@dell.com" Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Bart, Additionally, since struct rxe_send_wqe is not used in get_mtu() function, Can you please update signature to just have rxe_qp* as input argument? Parav On Jan 2, 2017 5:05 AM, "Bart Van Assche" wrote: The variable 'av' is not used so remove it. Signed-off-by: Bart Van Assche Cc: Moni Shoua Cc: Andrew Boyer --- drivers/infiniband/sw/rxe/rxe_req.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) static struct sk_buff *init_req_packet(struct rxe_qp *qp, diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c index 73d4a97603a1..b95b6035e988 100644 --- a/drivers/infiniband/sw/rxe/rxe_req.c +++ b/drivers/infiniband/sw/rxe/rxe_req.c @@ -364,16 +364,11 @@ static inline int check_init_depth(struct rxe_qp *qp, struct rxe_send_wqe *wqe) static inline int get_mtu(struct rxe_qp *qp, struct rxe_send_wqe *wqe) { struct rxe_dev *rxe = to_rdev(qp->ibqp.device); - struct rxe_port *port; - struct rxe_av *av; if ((qp_type(qp) == IB_QPT_RC) || (qp_type(qp) == IB_QPT_UC)) return qp->mtu; - av = &wqe->av; - port = &rxe->port; - - return port->mtu_cap; + return rxe->port.mtu_cap; }