| Message ID | SN1PR07MB220763908ED050AAFE840CEAF8B70@SN1PR07MB2207.namprd07.prod.outlook.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 11/23/2016 3:03 AM, Amrani, Ram wrote: > The recent introduction of qedr driver support in qede causes a GPF when probing the driver in a server without a RoCE enabled QLogic NIC. This fix avoids using an uninitialized pointer in such a case. Caught by the kernel test robot. > > Signed-off-by: Ram Amrani <Ram.Amrani@cavium.com> > --- > drivers/net/ethernet/qlogic/qede/qede_roce.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/qlogic/qede/qede_roce.c b/drivers/net/ethernet/qlogic/qede/qede_roce.c > index 9867f96..4927271 100644 > --- a/drivers/net/ethernet/qlogic/qede/qede_roce.c > +++ b/drivers/net/ethernet/qlogic/qede/qede_roce.c > @@ -191,8 +191,8 @@ int qede_roce_register_driver(struct qedr_driver *drv) > } > mutex_unlock(&qedr_dev_list_lock); > > - DP_INFO(edev, "qedr: discovered and registered %d RoCE funcs\n", > - qedr_counter); > + pr_notice("qedr: discovered and registered %d RoCE funcs\n", > + qedr_counter); > > return 0; > } > -- > 1.8.3.1 > This patch was seriously malformed (spaces instead of tabs, no space beginning the line that ends the patch, etc). I redid it by hand, it's now applied.
> This patch was seriously malformed (spaces instead of tabs, no space > beginning the line that ends the patch, etc). I redid it by hand, it's now > applied. > Hmmm, probably resending it via Outlook and not via git was the cause. Sorry for that. I'll avoid this in the future. I appreciate this, thank you. Ram -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/qlogic/qede/qede_roce.c b/drivers/net/ethernet/qlogic/qede/qede_roce.c index 9867f96..4927271 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_roce.c +++ b/drivers/net/ethernet/qlogic/qede/qede_roce.c @@ -191,8 +191,8 @@ int qede_roce_register_driver(struct qedr_driver *drv) } mutex_unlock(&qedr_dev_list_lock); - DP_INFO(edev, "qedr: discovered and registered %d RoCE funcs\n", - qedr_counter); + pr_notice("qedr: discovered and registered %d RoCE funcs\n", + qedr_counter); return 0; }
The recent introduction of qedr driver support in qede causes a GPF when probing the driver in a server without a RoCE enabled QLogic NIC. This fix avoids using an uninitialized pointer in such a case. Caught by the kernel test robot. Signed-off-by: Ram Amrani <Ram.Amrani@cavium.com> --- drivers/net/ethernet/qlogic/qede/qede_roce.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html