diff mbox series

RDMA/core: Clean up a variable name in ib_create_srq_user()

Message ID YyxFe3Pm0uzRuBkQ@kili (mailing list archive)
State Accepted
Headers show
Series RDMA/core: Clean up a variable name in ib_create_srq_user() | expand

Commit Message

Dan Carpenter Sept. 22, 2022, 11:22 a.m. UTC 
"&srq->pd->usecnt" and "&pd->usecnt" are different names for the same
reference count.  Use "&pd->usecnt" consistently for both the increment
and decrement.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/infiniband/core/verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Leon Romanovsky Sept. 22, 2022, 11:34 a.m. UTC | #1 
On Thu, 22 Sep 2022 14:22:35 +0300, Dan Carpenter wrote:
> "&srq->pd->usecnt" and "&pd->usecnt" are different names for the same
> reference count.  Use "&pd->usecnt" consistently for both the increment
> and decrement.
> 
> 

Applied, thanks!

[1/1] RDMA/core: Clean up a variable name in ib_create_srq_user()
      https://git.kernel.org/rdma/rdma/c/b300729b77b0b7

Best regards,
diff mbox series

Patch

diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index e54b3f1b730e..e36368a4728d 100644
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -1038,7 +1038,7 @@  struct ib_srq *ib_create_srq_user(struct ib_pd *pd,
 	ret = pd->device->ops.create_srq(srq, srq_init_attr, udata);
 	if (ret) {
 		rdma_restrack_put(&srq->res);
-		atomic_dec(&srq->pd->usecnt);
+		atomic_dec(&pd->usecnt);
 		if (srq->srq_type == IB_SRQT_XRC && srq->ext.xrc.xrcd)
 			atomic_dec(&srq->ext.xrc.xrcd->usecnt);
 		if (ib_srq_has_cq(srq->srq_type))