From patchwork Wed Dec 7 23:33:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jonathan Toppins X-Patchwork-Id: 9465459 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 816D760512 for ; Wed, 7 Dec 2016 23:33:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 703832855A for ; Wed, 7 Dec 2016 23:33:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 611EE28575; Wed, 7 Dec 2016 23:33:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 867FF2855A for ; Wed, 7 Dec 2016 23:33:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933397AbcLGXdw (ORCPT ); Wed, 7 Dec 2016 18:33:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50792 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933179AbcLGXdv (ORCPT ); Wed, 7 Dec 2016 18:33:51 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6D0C6C0567B3; Wed, 7 Dec 2016 23:33:51 +0000 (UTC) Received: from jtoppins.rdu.csb (vpn-61-216.rdu2.redhat.com [10.10.61.216]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB7NXoXT013069; Wed, 7 Dec 2016 18:33:51 -0500 Reply-To: jtoppins@redhat.com Subject: Re: [PATCH 00/28] Broadcom RoCE Driver (bnxt_re) References: <1480919912-1079-1-git-send-email-selvin.xavier@broadcom.com> To: Selvin Xavier , dledford@redhat.com Cc: linux-rdma@vger.kernel.org From: Jonathan Toppins Organization: Red Hat Message-ID: Date: Wed, 7 Dec 2016 18:33:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1480919912-1079-1-git-send-email-selvin.xavier@broadcom.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 07 Dec 2016 23:33:51 +0000 (UTC) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 12/05/2016 01:38 AM, Selvin Xavier wrote: > Hi Doug, > > This series introduces the RoCE driver for the Broadcom > NetXtreme-C/E 10/25/40/50 gigabit RoCE HCAs. This driver > is dependent on the bnxt_en NIC driver. > > This patch series is based on the "bnxt_re" branch on Doug's > repository + four pending bnxt_en NIC driver patches that are > yet to be pulled into net-next tree. > > Please review and consider applying this to linux-rdma repository. > > Thanks, > Selvin Xavier Compiling this series seems to have problems... The fix appears to be: jtoppins@jtoppins:~/projects/linux-rhel7$ git log -1 --oneline net-next/master 25e3e84b183a dummy: expend mtu range for dummy device jtoppins@jtoppins:~/projects/linux-rhel7$ git merge-base net-next/master HEAD 25e3e84b183a2c25b1e8303f815a6aa5bf78358a jtoppins@jtoppins:~/projects/linux-rhel7$ make defconfig *** Default configuration is based on 'x86_64_defconfig' # # configuration written to .config # jtoppins@jtoppins:~/projects/linux-rhel7$ make menuconfig HOSTCC scripts/kconfig/mconf.o HOSTCC scripts/kconfig/lxdialog/checklist.o HOSTCC scripts/kconfig/lxdialog/util.o HOSTCC scripts/kconfig/lxdialog/inputbox.o HOSTCC scripts/kconfig/lxdialog/textbox.o HOSTCC scripts/kconfig/lxdialog/yesno.o HOSTCC scripts/kconfig/lxdialog/menubox.o HOSTLD scripts/kconfig/mconf scripts/kconfig/mconf Kconfig configuration written to .config *** End of the configuration. *** Execute 'make' to start the build or try 'make help'. jtoppins@jtoppins:~/projects/linux-rhel7$ grep "BNXTRE" .config CONFIG_INFINIBAND_BNXTRE=m jtoppins@jtoppins:~/projects/linux-rhel7$ make drivers/infiniband/hw/bnxtre/bnxt_re.ko SYSTBL arch/x86/entry/syscalls/../../include/generated/asm/syscalls_32.h SYSHDR arch/x86/entry/syscalls/../../include/generated/asm/unistd_32_ia32.h SYSHDR arch/x86/entry/syscalls/../../include/generated/asm/unistd_64_x32.h SYSTBL arch/x86/entry/syscalls/../../include/generated/asm/syscalls_64.h SYSHDR arch/x86/entry/syscalls/../../include/generated/uapi/asm/unistd_32.h SYSHDR arch/x86/entry/syscalls/../../include/generated/uapi/asm/unistd_64.h SYSHDR arch/x86/entry/syscalls/../../include/generated/uapi/asm/unistd_x32.h HOSTCC arch/x86/tools/relocs_32.o HOSTCC arch/x86/tools/relocs_64.o HOSTCC arch/x86/tools/relocs_common.o HOSTLD arch/x86/tools/relocs CHK include/config/kernel.release UPD include/config/kernel.release WRAP arch/x86/include/generated/asm/clkdev.h WRAP arch/x86/include/generated/asm/cputime.h WRAP arch/x86/include/generated/asm/dma-contiguous.h WRAP arch/x86/include/generated/asm/early_ioremap.h WRAP arch/x86/include/generated/asm/mcs_spinlock.h WRAP arch/x86/include/generated/asm/mm-arch-hooks.h CHK include/generated/uapi/linux/version.h UPD include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h UPD include/generated/utsrelease.h CC kernel/bounds.s CHK include/generated/bounds.h UPD include/generated/bounds.h CHK include/generated/timeconst.h UPD include/generated/timeconst.h CC arch/x86/kernel/asm-offsets.s CHK include/generated/asm-offsets.h UPD include/generated/asm-offsets.h CALL scripts/checksyscalls.sh CC scripts/mod/empty.o HOSTCC scripts/mod/mk_elfconfig MKELF scripts/mod/elfconfig.h HOSTCC scripts/mod/modpost.o CC scripts/mod/devicetable-offsets.s GEN scripts/mod/devicetable-offsets.h HOSTCC scripts/mod/file2alias.o HOSTCC scripts/mod/sumversion.o HOSTLD scripts/mod/modpost HOSTCC scripts/selinux/genheaders/genheaders HOSTCC scripts/selinux/mdp/mdp HOSTCC scripts/kallsyms HOSTCC scripts/pnmtologo HOSTCC scripts/conmakehash HOSTCC scripts/sortextable CC [M] drivers/infiniband/hw/bnxtre/bnxt_re_main.o drivers/infiniband/hw/bnxtre/bnxt_re_main.c: In function ‘bnxt_re_get_priority_mask’: drivers/infiniband/hw/bnxtre/bnxt_re_main.c:850:17: error: storage size of ‘app’ isn’t known struct dcb_app app; ^ drivers/infiniband/hw/bnxtre/bnxt_re_main.c:855:17: error: ‘IEEE_8021QAZ_APP_SEL_ETHERTYPE’ undeclared (first use in this function) app.selector = IEEE_8021QAZ_APP_SEL_ETHERTYPE; ^ drivers/infiniband/hw/bnxtre/bnxt_re_main.c:855:17: note: each undeclared identifier is reported only once for each function it appears in drivers/infiniband/hw/bnxtre/bnxt_re_main.c:857:2: error: implicit declaration of function ‘dcb_ieee_getapp_mask’ [-Werror=implicit-function-declaration] tmp_map = dcb_ieee_getapp_mask(netdev, &app); ^ drivers/infiniband/hw/bnxtre/bnxt_re_main.c:860:17: error: ‘IEEE_8021QAZ_APP_SEL_DGRAM’ undeclared (first use in this function) app.selector = IEEE_8021QAZ_APP_SEL_DGRAM; ^ drivers/infiniband/hw/bnxtre/bnxt_re_main.c:850:17: warning: unused variable ‘app’ [-Wunused-variable] struct dcb_app app; ^ cc1: some warnings being treated as errors make[1]: *** [drivers/infiniband/hw/bnxtre/bnxt_re_main.o] Error 1 make: *** [drivers/infiniband/hw/bnxtre/bnxt_re.ko] Error 2 jtoppins@jtoppins:~/projects/linux-rhel7$ It seems this is the patch that has the problem: Author: Selvin Xavier Date: Sun Dec 4 22:38:29 2016 -0800 bnxt_re: Support for DCB This patch queries the configured RoCE APP Priority on the host using the dcbnl API and programs the RoCE FW with the corresponding Traffic Class(es) for the priority. Running this also fails: $ make M=drivers/infiniband/hw/bnxtre bnxt_re.ko CC [M] drivers/infiniband/hw/bnxtre/bnxt_re_main.o drivers/infiniband/hw/bnxtre/bnxt_re_main.c: In function ‘bnxt_re_get_priority_mask’: drivers/infiniband/hw/bnxtre/bnxt_re_main.c:850:17: error: storage size of ‘app’ isn’t known struct dcb_app app; ^ drivers/infiniband/hw/bnxtre/bnxt_re_main.c:855:17: error: ‘IEEE_8021QAZ_APP_SEL_ETHERTYPE’ undeclared (first use in this function) app.selector = IEEE_8021QAZ_APP_SEL_ETHERTYPE; ^ drivers/infiniband/hw/bnxtre/bnxt_re_main.c:855:17: note: each undeclared identifier is reported only once for each function it appears in drivers/infiniband/hw/bnxtre/bnxt_re_main.c:857:2: error: implicit declaration of function ‘dcb_ieee_getapp_mask’ [-Werror=implicit-function-declaration] tmp_map = dcb_ieee_getapp_mask(netdev, &app); ^ drivers/infiniband/hw/bnxtre/bnxt_re_main.c:860:17: error: ‘IEEE_8021QAZ_APP_SEL_DGRAM’ undeclared (first use in this function) app.selector = IEEE_8021QAZ_APP_SEL_DGRAM; ^ drivers/infiniband/hw/bnxtre/bnxt_re_main.c:850:17: warning: unused variable ‘app’ [-Wunused-variable] struct dcb_app app; ^ cc1: some warnings being treated as errors make[1]: *** [drivers/infiniband/hw/bnxtre/bnxt_re_main.o] Error 1 make: *** [bnxt_re.ko] Error 2 v2? --- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html === $ git diff diff --git i/drivers/infiniband/hw/bnxtre/bnxt_re_main.c w/drivers/infiniband/hw/bnxtre/bnxt_re_main.c index 9f3960037931..1bd67887a23c 100644 --- i/drivers/infiniband/hw/bnxtre/bnxt_re_main.c +++ w/drivers/infiniband/hw/bnxtre/bnxt_re_main.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include ===