From patchwork Fri Nov 10 16:28:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Christoph Lameter (Ampere)" X-Patchwork-Id: 10053437 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B20B160631 for ; Fri, 10 Nov 2017 16:28:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A51ED28A9C for ; Fri, 10 Nov 2017 16:28:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 99CB42B3C6; Fri, 10 Nov 2017 16:28:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3A74428A9C for ; Fri, 10 Nov 2017 16:28:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753292AbdKJQ2m (ORCPT ); Fri, 10 Nov 2017 11:28:42 -0500 Received: from resqmta-ch2-06v.sys.comcast.net ([69.252.207.38]:43654 "EHLO resqmta-ch2-06v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbdKJQ2k (ORCPT ); Fri, 10 Nov 2017 11:28:40 -0500 Received: from resomta-ch2-17v.sys.comcast.net ([69.252.207.113]) by resqmta-ch2-06v.sys.comcast.net with ESMTP id DC9Ue8y3zHwSMDCAaeMSBo; Fri, 10 Nov 2017 16:28:40 +0000 Received: from gentwo.org ([98.222.162.64]) by resomta-ch2-17v.sys.comcast.net with SMTP id DCAZeQ2A9RomNDCAZe9Bx2; Fri, 10 Nov 2017 16:28:40 +0000 Received: by gentwo.org (Postfix, from userid 1001) id 03EFD116024F; Fri, 10 Nov 2017 10:28:38 -0600 (CST) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 00B1F116002F; Fri, 10 Nov 2017 10:28:39 -0600 (CST) Date: Fri, 10 Nov 2017 10:28:38 -0600 (CST) From: Christopher Lameter X-X-Sender: cl@nuc-kabylake To: Hal Rosenstock cc: Jason Gunthorpe , linux-rdma@vger.kernel.org, Doug Ledford , Alex Vesker , Sean Hefty Subject: Re: [PATCH 1/2] librdmacm: Add support for extended join multicast API In-Reply-To: <79363650-6aca-111c-4b8c-b1c620be5cde@dev.mellanox.co.il> Message-ID: References: <20171109171609.169281977@linux.com> <20171109171618.882248508@linux.com> <79363650-6aca-111c-4b8c-b1c620be5cde@dev.mellanox.co.il> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 X-CMAE-Envelope: MS4wfOVEmuTnsrPJFPwme33LMNKkUtsYsTXGXMPtqT42s+XM18mlz1otc6Av0oq251Vt1lGmEIrd4dKQTl3OZqTCn8XzLd8HNqNxApHgiSfq0FdfutDeuYLa CXOwV0gvQFYVG99ZILRqvsDlLQTSVE0LftJO0xbt3yv0RHaFhlY9YLN5uA5RXElVqVClpEqwbnDq0fRKECFTLxrZjDd+CBDbakI3KfUKrVZrxoTHszjjRCLm ef1zq0i7no0Ws5Xsu2Q5mKHAHbTCBmvY1/0EIWCD/QwAMWDKKbz6YwH4rKNtq/9Vw4jMkfXiYUDKTvh1GEWsFw== Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Subject: rdma-core: Fixup comments in librdmacm Fix up the two comments that Hal showed were incorrect. Signed-off-by: Christoph Lameter --- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: rdma-core/librdmacm/cma.c =================================================================== --- rdma-core.orig/librdmacm/cma.c +++ rdma-core/librdmacm/cma.c @@ -2040,7 +2040,7 @@ static int ucma_process_join(struct cma_ if (!evt->id_priv->id.qp) return 0; - /* Don't attach QP to multicast if joined as send only */ + /* Don't attach QP to multicast if joined as send only full member */ if (evt->mc->join_flags == RDMA_MC_JOIN_FLAG_SENDONLY_FULLMEMBER) return 0; Index: rdma-core/librdmacm/rdma_cma.h =================================================================== --- rdma-core.orig/librdmacm/rdma_cma.h +++ rdma-core/librdmacm/rdma_cma.h @@ -578,7 +578,7 @@ int rdma_join_multicast(struct rdma_cm_i int rdma_leave_multicast(struct rdma_cm_id *id, struct sockaddr *addr); /** - * in_multicast_ex - Joins a multicast group with options. + * rdma_join_multicast_ex - Joins a multicast group with options. * @id: Communication identifier associated with the request. * @mc_join_attr: Extensive struct containing multicast join parameters. * @context: User-defined context associated with the join request.