From patchwork Sun Nov 6 08:51:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagi Grimberg X-Patchwork-Id: 9413889 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 99FC76022E for ; Sun, 6 Nov 2016 08:51:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 88E3A2915C for ; Sun, 6 Nov 2016 08:51:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7A6402915E; Sun, 6 Nov 2016 08:51:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F27082915C for ; Sun, 6 Nov 2016 08:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751474AbcKFIvH (ORCPT ); Sun, 6 Nov 2016 03:51:07 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:35620 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbcKFIvG (ORCPT ); Sun, 6 Nov 2016 03:51:06 -0500 Received: by mail-wm0-f42.google.com with SMTP id a197so127326640wmd.0 for ; Sun, 06 Nov 2016 01:51:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=TM/9L2lkJdq+HGPPeBzL9MNEitTmL+FLdtilh7k3cAE=; b=GI8tA//VZrIqO5imz1SmPeXaaykGbpelu6bxh0JyAe18k/ARUWHw87BpWX10JEKKnS 9gf/b1bEOAFnvqFtHSy9kbxGoS1jMJDrn+DONJoF/xkauM0Yz6JMSNPMFeRwFWwdIKPY Zs4hLE4usgjjJ5m2v2MgwXLYH9Afvh709UtWlOPQPqUEHAHXJSDnug+qAdkxEkzKAONi 65gGdQA3Pvmkr96r4YHzAaJSCmDViEYlEGFv4pQiLOcceE6TyiwgI1RF4zhYFlzrbB7W kYeuqhgV1yH0eZ+7YaKt6VRoiCJEHEKMo4dtqxHApk4nY0RaPjHre3Vgd/zCe2pAhq+N O5TQ== X-Gm-Message-State: ABUngvdqA0y1oXCCFUmlWOW17/ZzLhfLf523iwUDz/IFyofFuFPy81T47Ag/MQ9bSlPqfQ== X-Received: by 10.28.199.71 with SMTP id x68mr1735565wmf.34.1478422265041; Sun, 06 Nov 2016 01:51:05 -0700 (PDT) Received: from [192.168.1.177] ([31.154.55.94]) by smtp.gmail.com with ESMTPSA id y3sm23994645wjg.3.2016.11.06.01.51.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Nov 2016 01:51:03 -0700 (PDT) Subject: Re: nvmet_rdma crash - DISCONNECT event with NULL queue To: Steve Wise , 'Christoph Hellwig' References: <01b401d23458$af277210$0d765630$@opengridcomputing.com> <6f42d056-284d-00fc-2b98-189f54957980@grimberg.me> <01cc01d2345b$d445acd0$7cd10670$@opengridcomputing.com> <4cc25277-429a-4ab9-470c-b3af1428ce93@grimberg.me> <01d101d2345e$2f054390$8d0fcab0$@opengridcomputing.com> <01d901d2345f$da0d2e00$8e278a00$@opengridcomputing.com> <1d09c064-1cbe-7e6e-43d2-cfa6cf0c19ea@grimberg.me> <024e01d23476$6668b890$333a29b0$@opengridcomputing.com> <3512b8bb-4d29-b90a-49e1-ebf1085c47d7@grimberg.me> <004701d2351a$d9e4ad70$8dae0850$@opengridcomputing.com> <01d601d2353d$e3d10810$ab731830$@opengridcomputing.com> Cc: linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org From: Sagi Grimberg Message-ID: Date: Sun, 6 Nov 2016 10:51:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <01d601d2353d$e3d10810$ab731830$@opengridcomputing.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP >> I'll also try and reproduce this on mlx4 to rule out >> iwarp and cxgb4 anomolies. > > Running the same test over mlx4/roce, I hit a warning in list_debug, and then a > stuck CPU... Steve, Does this patch help? --- } @@ -1247,7 +1248,6 @@ static void __nvmet_rdma_queue_disconnect(struct nvmet_rdma_queue *queue) if (disconnect) { rdma_disconnect(queue->cm_id); - ib_drain_qp(queue->cm_id->qp); schedule_work(&queue->release_work); } } -- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c index bafd9898b5f6..5946dac9564f 100644 --- a/drivers/nvme/target/rdma.c +++ b/drivers/nvme/target/rdma.c @@ -951,6 +951,7 @@ static int nvmet_rdma_create_queue_ib(struct nvmet_rdma_queue *queue) static void nvmet_rdma_destroy_queue_ib(struct nvmet_rdma_queue *queue) { + ib_drain_qp(queue->cm_id->qp); rdma_destroy_qp(queue->cm_id); ib_free_cq(queue->cq);