From patchwork Mon Jul 2 04:40:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Hubbard X-Patchwork-Id: 10500429 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3216660362 for ; Mon, 2 Jul 2018 04:41:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1ECE6285B3 for ; Mon, 2 Jul 2018 04:41:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1260E2861D; Mon, 2 Jul 2018 04:41:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B35FB285B3 for ; Mon, 2 Jul 2018 04:41:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753124AbeGBEla (ORCPT ); Mon, 2 Jul 2018 00:41:30 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:12058 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753118AbeGBElZ (ORCPT ); Mon, 2 Jul 2018 00:41:25 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1, AES128-SHA) id ; Sun, 01 Jul 2018 21:41:22 -0700 Received: from HQMAIL107.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Sun, 01 Jul 2018 21:41:24 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Sun, 01 Jul 2018 21:41:24 -0700 Received: from [10.110.48.28] (10.110.48.28) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 2 Jul 2018 04:41:23 +0000 Subject: Re: [PATCH v2 4/6] mm/fs: add a sync_mode param for clear_page_dirty_for_io() To: kbuild test robot , CC: , Matthew Wilcox , Michal Hocko , Christopher Lameter , Jason Gunthorpe , Dan Williams , Jan Kara , , LKML , linux-rdma , References: <20180702005654.20369-5-jhubbard@nvidia.com> <201807020900.J6omiRbx%fengguang.wu@intel.com> X-Nvconfidentiality: public From: John Hubbard Message-ID: Date: Sun, 1 Jul 2018 21:40:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201807020900.J6omiRbx%fengguang.wu@intel.com> X-Originating-IP: [10.110.48.28] X-ClientProxiedBy: HQMAIL103.nvidia.com (172.20.187.11) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 07/01/2018 07:47 PM, kbuild test robot wrote: > Hi John, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.18-rc3] > [cannot apply to next-20180629] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/john-hubbard-gmail-com/mm-fs-gup-don-t-unmap-or-drop-filesystem-buffers/20180702-090125 > config: i386-randconfig-x075-201826 (attached as .config) > compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones prefixed by >>): > > fs/f2fs/dir.c: In function 'f2fs_delete_entry': >>> fs/f2fs/dir.c:734:33: error: 'WB_SYNC_ALL' undeclared (first use in this function); did you mean 'FS_SYNC_FL'? > clear_page_dirty_for_io(page, WB_SYNC_ALL); > ^~~~~~~~~~~ > FS_SYNC_FL Fixed locally, via: thanks, diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index 258f9dc117f4..ca20c1262582 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -16,6 +16,7 @@ #include "acl.h" #include "xattr.h" #include +#include static unsigned long dir_blocks(struct inode *inode) {