From patchwork Fri Apr 7 21:00:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9670403 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4153B602B3 for ; Fri, 7 Apr 2017 21:00:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 345E028652 for ; Fri, 7 Apr 2017 21:00:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 28DDC28665; Fri, 7 Apr 2017 21:00:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AAE5328652 for ; Fri, 7 Apr 2017 21:00:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754895AbdDGVAg (ORCPT ); Fri, 7 Apr 2017 17:00:36 -0400 Received: from mout.web.de ([212.227.17.12]:57699 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbdDGVAf (ORCPT ); Fri, 7 Apr 2017 17:00:35 -0400 Received: from [192.168.1.2] ([77.181.117.94]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M7KZO-1c8K350qKk-00x0eI; Fri, 07 Apr 2017 23:00:09 +0200 Subject: [PATCH 2/9] IB/IPoIB: Delete an error message for a failed memory allocation From: SF Markus Elfring To: linux-rdma@vger.kernel.org, target-devel@vger.kernel.org, David Ahern , Doug Ledford , Erez Shitrit , Feras Daoud , Hal Rosenstock , Leon Romanovsky , Mark Bloch , Or Gerlitz , Paolo Abeni , Roi Dayan , Sagi Grimberg , Sean Hefty , Yuval Shaia , Zhu Yanjun Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Fri, 7 Apr 2017 23:00:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Provags-ID: V03:K0:iRJ2e+YVgR1hO7nqliLysPRx8Kr1A0hqv7ff8tcc+t8aTtsVdcH 5bReLTap+whU5wayCx8g6AmuehZX05yIbD2Drde3LyKWlm+2J9/zdc1GU4GJDrcCQGuPIUF aMH/oD57XfR6tER+tBuT2upV3V0hrAkld1SklCXUFGFg4F37/i1K5lOGLw6RTeNRboTMvlW R5fkzEdaMDvlm5f/g2qSg== X-UI-Out-Filterresults: notjunk:1; V01:K0:xXQPba8mido=:NSo8KyC+KeZBRHHdJHsf3i HLIBvkHgmlq36GPBzyp+r7fEzGaVYndISU5u/ApJ5c842QaqcuO3QMYblF5kpP4MfRvA9XFF9 Mnoq9ODGOw74+x/SHLkOQyseepuwhyTgv/iae5DqA5NogQAW7mk1Y4qBj7uHd03G+S8ldo446 DEUYcGuobUyZy1IlStuHfoVVZcQI7fC3oqPjRSne1ceWmbaPcidkjD4HyUZ6rHQc9WN4wbsq7 j1ugNVanH6mPgPzodX/8AFfF5XTNol/8QAzJL4HNH6/IH5wnj+OqUy1HOF+sEV76lR7YWdmXf URGx3AnoB77XkdwFLpnulVHH6S/PwMA4Jq1pjtSa2fIadHyR1immbxYIEGP5QybuFdtNYJS4V 26TqdVltbzLdMPMNNBH1T9YS/RXX6smzM/TIhtnv9wqvaWmg9cOpne23VDvFro5mxm2IL1KWs HFQD0scLtMEAsNlb6FJfCHlHTimVoS/9b9sh5cUEy8aJU1QOsI47QBsvSX4APDLwtHREHbGnk hHDrQhos8iBPUNf16Clad01WzXaZCFwidl51zw3/4MwzD0oJUyrAJQz5NqIgSxos8EJOj5Gd5 7mDA7ShBQsttKx+zS68u8zb8SeRTrpFfCGVUIORg6ic/DFTF1NAVD9rW7lFMpexrYYQ04abfV FecqWFC9bxnxnHLLAv10eS6jDDh49sw4ziV6rKH2RsKR63xZyn/cSDr3WbfUrO6sew4lT4SXy x4SZoHumvD6MRvO03xBS2ywv4JGioh/bDUU8NIlTjjai0dEddXCDwuyRuOpOtYpNKxmJaGEbo VY4JSys Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Fri, 7 Apr 2017 19:23:55 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus remove such a statement here. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring Reviewed-by: Sagi Grimberg --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index 3d3e49fb15b7..c5024c6d38e7 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c @@ -1634,11 +1634,8 @@ int ipoib_dev_init(struct net_device *dev, struct ib_device *ca, int port) goto out; priv->tx_ring = vzalloc(ipoib_sendq_size * sizeof *priv->tx_ring); - if (!priv->tx_ring) { - printk(KERN_WARNING "%s: failed to allocate TX ring (%d entries)\n", - ca->name, ipoib_sendq_size); + if (!priv->tx_ring) goto out_rx_ring_cleanup; - } /* priv->tx_head, tx_tail & tx_outstanding are already 0 */