From patchwork Mon Nov 26 13:27:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hal Rosenstock X-Patchwork-Id: 10698385 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0D98D17D5 for ; Mon, 26 Nov 2018 13:27:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F0DC829869 for ; Mon, 26 Nov 2018 13:27:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E53F12986D; Mon, 26 Nov 2018 13:27:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8EA3A29869 for ; Mon, 26 Nov 2018 13:27:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726206AbeK0AVS (ORCPT ); Mon, 26 Nov 2018 19:21:18 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:45657 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725966AbeK0AVS (ORCPT ); Mon, 26 Nov 2018 19:21:18 -0500 Received: by mail-qt1-f195.google.com with SMTP id e5so17453826qtr.12 for ; Mon, 26 Nov 2018 05:27:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev-mellanox-co-il.20150623.gappssmtp.com; s=20150623; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=KFWMw6ytIlfOLXx02bKib5NjG6qHK64ghd2adIGtK7I=; b=1afeAPYuc0IQtDyWJTbPiD4bx6RAzg3QxgT5VLb3Su3U+LhEz+S92C2KgFmqUt2VqV OdsQZxNfdZxOKSvRrRwhw7FS3mpBJEfR08cCjCWwtrrwnhyKQOtasvAEkImcOyfdemVd 0KQcuEapIusu9z7OJxz3Q00dCcK9/ZyrgfS96as/6XhQTVX3XxBKUZqF6TL/SwbI51j+ xxTJwwLa71hUe7GJ8WVM6URbFH1MqJ6Pbn2UZSuaIcCN/ITO4Ut6dm8+aZgSBBii9m2n Fq4sv+i//sZ4axHqkxdVN/yudTrWCL3GbJ5dDdsASItJF2xw6TyLw3g0+o+16Id17+jf vgTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=KFWMw6ytIlfOLXx02bKib5NjG6qHK64ghd2adIGtK7I=; b=e32L9E7dtQBIhT2XtV/5mc1ittUEAT+IO/WSNWorZaGrfYyX0Z9KX4VQL8XbzVhcQz KPvXDo989YwQO/BzN2aIS+ll6hnD8BasoaFfZxrlbvnFKatE0UQqCN3cuwF5YEhmgbIl u/KEMpST2kFiQVhAMneDvXi3JNEVT9ejStRAt6at+ogpeDCgqbG4EfEaDSLoYisIxId7 RinBHadOrjxb6WsvmZCGTE6FxtuQJbBTqGXVE22pF0wXPNk+h+upnUAm1xfTaRnQANBk jcyFXhGlHlKYAJF5TnvuBbf82ZJHcvdKdXPaWhmuIOdTf5keYXun/ofLHbnDbkOuBfq5 7v8Q== X-Gm-Message-State: AGRZ1gItHlU0zVuPaKX+ucRAWOGvHpPl2e+N52H/yfbYqy7zeNKstLvv 6D15vZVei/27D/lVfA+/7h6/CCFNECU= X-Google-Smtp-Source: AFSGD/V2t4ttEFVohZdpdX54v9TZCkSi8cBfH9uPxeHSLAghmgWHF1JPdJcrJN1Y4t5IFPCq3p4SEA== X-Received: by 2002:aed:3bd7:: with SMTP id s23mr25614493qte.207.1543238829526; Mon, 26 Nov 2018 05:27:09 -0800 (PST) Received: from [192.168.1.119] (c-73-142-227-196.hsd1.ma.comcast.net. [73.142.227.196]) by smtp.googlemail.com with ESMTPSA id l33sm146922qta.57.2018.11.26.05.27.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Nov 2018 05:27:08 -0800 (PST) To: Honggang LI Cc: "linux-rdma@vger.kernel.org" From: Hal Rosenstock Subject: [PATCH opensm] osm_resp.c: No need to swap DR [D/S]LIDs in resp_make_resp_smp Message-ID: Date: Mon, 26 Nov 2018 08:27:07 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 Content-Language: en-US Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP C14-10.1.1 states that the DrSLID and DrDLID in the directed route response SMP shall be copied as is from the request SMP. Pointed-out-by: Honggang Li Signed-off-by: Hal Rosenstock Reviewed-by: Håkon Bugge Signed-off-by: Hal Rosenstock --- opensm/osm_resp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/opensm/osm_resp.c b/opensm/osm_resp.c index 3f270e6..9a98df9 100644 --- a/opensm/osm_resp.c +++ b/opensm/osm_resp.c @@ -85,8 +85,6 @@ static void resp_make_resp_smp(IN osm_sm_t * sm, IN const ib_smp_t * p_src_smp, if (p_src_smp->mgmt_class == IB_MCLASS_SUBN_DIR) p_dest_smp->status |= IB_SMP_DIRECTION; - p_dest_smp->dr_dlid = p_dest_smp->dr_slid; - p_dest_smp->dr_slid = p_dest_smp->dr_dlid; memcpy(&p_dest_smp->data, p_payload, IB_SMP_DATA_SIZE); Exit: