| Message ID | ef7f1f80-68c4-b8d5-f40b-9bcef5b95e21@sandisk.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
T24gTW9uLCAyMDE2LTA3LTE4IGF0IDA3OjE4IC0wNzAwLCBCYXJ0IFZhbiBBc3NjaGUgd3JvdGU6 DQo+IFRoZXJlIGlzIGEgc3RyaWN0IHBvbGljeSBpbiB0aGUgTGludXgga2VybmVsIHRoYXQgbmV3 IGRyaXZlcnMgbXVzdCBiZQ0KPiBkaXNhYmxlZCBieSBkZWZhdWx0LiBIZW5jZSBjaGFuZ2UgImRl ZmF1bHQgbSIgaW50byAiZGVmYXVsdCBuIiBmb3INCj4gdGhlDQo+IHJkbWF2dCBhbmQgdGhlIGhm aTEgZHJpdmVycy4NCj7CoA0KDQpMb29raW5nIGF0IHRoZSBvdGhlciBkcml2ZXJzIGluIHRoZSBy ZG1hIHRyZWUgdGhleSBkb24ndCBzZWVtIHRvDQpzcGVjaWZ5IGEgZGVmYXVsdCwgaXMgdGhhdCB0 aGUgc2FtZSBhcyAnbic/DQoNCi1EZW5ueQ0K -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/18/2016 07:44 AM, Dalessandro, Dennis wrote: > On Mon, 2016-07-18 at 07:18 -0700, Bart Van Assche wrote: >> There is a strict policy in the Linux kernel that new drivers must be >> disabled by default. Hence change "default m" into "default n" for >> the rdmavt and the hfi1 drivers. > > Looking at the other drivers in the rdma tree they don't seem to > specify a default, is that the same as 'n'? Hello Denny, Although I haven't found any information about this in https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt, I assume that leaving out "default n" is the same as "default n". Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jul 18, 2016 at 02:44:53PM +0000, Dalessandro, Dennis wrote: > Looking at the other drivers in the rdma tree they don't seem to > specify a default, is that the same as 'n'? Its is, and no default line is exactly what new drivers should default to. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2016-07-18 at 21:10 -0700, Christoph Hellwig wrote: > On Mon, Jul 18, 2016 at 02:44:53PM +0000, Dalessandro, Dennis wrote: > > Looking at the other drivers in the rdma tree they don't seem to > > specify a default, is that the same as 'n'? > > Its is, and no default line is exactly what new drivers should > default > to. Bart do you want to spin a v2 of your patch and just leave the default lines out? -Denny
On 07/19/2016 08:46 AM, Dalessandro, Dennis wrote: > On Mon, 2016-07-18 at 21:10 -0700, Christoph Hellwig wrote: >> On Mon, Jul 18, 2016 at 02:44:53PM +0000, Dalessandro, Dennis wrote: >>> Looking at the other drivers in the rdma tree they don't seem to >>> specify a default, is that the same as 'n'? >> >> Its is, and no default line is exactly what new drivers should >> default >> to. > > Bart do you want to spin a v2 of your patch and just leave the default > lines out? I'll post a v2. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/hfi1/Kconfig b/drivers/infiniband/hw/hfi1/Kconfig index a925fb0..6a2e83c 100644 --- a/drivers/infiniband/hw/hfi1/Kconfig +++ b/drivers/infiniband/hw/hfi1/Kconfig @@ -3,7 +3,7 @@ config INFINIBAND_HFI1 depends on X86_64 && INFINIBAND_RDMAVT select MMU_NOTIFIER select CRC32 - default m + default n ---help--- This is a low-level driver for Intel OPA Gen1 adapter. config HFI1_DEBUG_SDMA_ORDER diff --git a/drivers/infiniband/sw/rdmavt/Kconfig b/drivers/infiniband/sw/rdmavt/Kconfig index 11aa6a3..3426b44 100644 --- a/drivers/infiniband/sw/rdmavt/Kconfig +++ b/drivers/infiniband/sw/rdmavt/Kconfig @@ -1,6 +1,6 @@ config INFINIBAND_RDMAVT tristate "RDMA verbs transport library" depends on 64BIT - default m + default n ---help--- This is a common software verbs provider for RDMA networks.
There is a strict policy in the Linux kernel that new drivers must be disabled by default. Hence change "default m" into "default n" for the rdmavt and the hfi1 drivers. Fixes: 0194621b2253 ("IB/rdmavt: Create module framework and handle driver registration") Fixes: f48ad614c100 ("IB/hfi1: Move driver out of staging") Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Cc: Jubin John <jubin.john@intel.com> Cc: Dennis Dalessandro <dennis.dalessandro@intel.com> Cc: Ira Weiny <ira.weiny@intel.com> Cc: Mike Marciniszyn <mike.marciniszyn@intel.com> --- drivers/infiniband/hw/hfi1/Kconfig | 2 +- drivers/infiniband/sw/rdmavt/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)