diff mbox

IB/rxe: Fix a memory leak in rxe_qp_cleanup()

Message ID f38a99cc-5643-f4dc-adfa-b81c67cae4e7@acm.org (mailing list archive)
State Accepted
Headers show

Commit Message

Bart Van Assche Dec. 15, 2016, 4:15 p.m. UTC 
From: Bart Van Assche <bart.vanassche@sandisk.com>

A socket is associated with every QP by the rxe driver but sock_release()
is never called. Add a call to sock_release() in rxe_qp_cleanup().

Fixes: commit 8700e3e7c48A5 ("Add Soft RoCE driver")
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Moni Shoua <monis@mellanox.com>
Cc: Kamal Heib <kamalh@mellanox.com>
Cc: Amir Vadai <amirv@mellanox.com>
Cc: Haggai Eran <haggaie@mellanox.com>
Cc: <stable@vger.kernel.org>
---
 drivers/infiniband/sw/rxe/rxe_qp.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Moni Shoua Dec. 18, 2016, 7:38 a.m. UTC | #1 
On Thu, Dec 15, 2016 at 6:15 PM, Bart Van Assche
<bart.vanassche@gmail.com> wrote:
> From: Bart Van Assche <bart.vanassche@sandisk.com>
>
> A socket is associated with every QP by the rxe driver but sock_release()
> is never called. Add a call to sock_release() in rxe_qp_cleanup().
>
> Fixes: commit 8700e3e7c48A5 ("Add Soft RoCE driver")
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Moni Shoua <monis@mellanox.com>
> Cc: Kamal Heib <kamalh@mellanox.com>
> Cc: Amir Vadai <amirv@mellanox.com>
> Cc: Haggai Eran <haggaie@mellanox.com>
> Cc: <stable@vger.kernel.org>
> ---
>  drivers/infiniband/sw/rxe/rxe_qp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c
> index c3e60e4bde6e..486d576e55bc 100644
> --- a/drivers/infiniband/sw/rxe/rxe_qp.c
> +++ b/drivers/infiniband/sw/rxe/rxe_qp.c
> @@ -855,4 +855,5 @@ void rxe_qp_cleanup(void *arg)
>         free_rd_atomic_resources(qp);
>
>         kernel_sock_shutdown(qp->sk, SHUT_RDWR);
> +       sock_release(qp->sk);
>  }
> --
> 2.11.0
>
Reviewed-by: Moni Shoua <monis@mellanox.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Doug Ledford Dec. 18, 2016, 6:36 p.m. UTC | #2 
On 12/15/2016 11:15 AM, Bart Van Assche wrote:
> From: Bart Van Assche <bart.vanassche@sandisk.com>
> 
> A socket is associated with every QP by the rxe driver but sock_release()
> is never called. Add a call to sock_release() in rxe_qp_cleanup().
> 
> Fixes: commit 8700e3e7c48A5 ("Add Soft RoCE driver")
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Moni Shoua <monis@mellanox.com>
> Cc: Kamal Heib <kamalh@mellanox.com>
> Cc: Amir Vadai <amirv@mellanox.com>
> Cc: Haggai Eran <haggaie@mellanox.com>
> Cc: <stable@vger.kernel.org>

Thanks, queued for -rc.
diff mbox

Patch

diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c
index c3e60e4bde6e..486d576e55bc 100644
--- a/drivers/infiniband/sw/rxe/rxe_qp.c
+++ b/drivers/infiniband/sw/rxe/rxe_qp.c
@@ -855,4 +855,5 @@  void rxe_qp_cleanup(void *arg)
 	free_rd_atomic_resources(qp);
 
 	kernel_sock_shutdown(qp->sk, SHUT_RDWR);
+	sock_release(qp->sk);
 }