From patchwork Sun Apr 18 13:55:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 12210135 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47DEFC433B4 for ; Sun, 18 Apr 2021 13:56:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2931F61278 for ; Sun, 18 Apr 2021 13:56:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231434AbhDRN4j (ORCPT ); Sun, 18 Apr 2021 09:56:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:47266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231460AbhDRN4h (ORCPT ); Sun, 18 Apr 2021 09:56:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AB2EA61278; Sun, 18 Apr 2021 13:56:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618754169; bh=LzjajMkmrKzNp+lPlzX93b5lQw7lfFXlvRIpwzMrtsA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oNG21P5OQ+R7LvXlQDVNShfFCoNXsxmTG7h54pNEOqRVa7ZlFzkkjSoZcFrtTSqCq k2+nnXe5rL3kOgw0ioslqFhzOmwcttSnK0oxWW7Yv5EX4/FrhUm9dGNGL8wPhR3RD+ Xzz/6kkvs4CfGKDNOUDDaijzdwWiH5TZ7WT2unNPcq13p4+W5wbfNVxkp48i2mn6PR bKTr1HowanscVqJQkWo2KTXS3XajREmTueL4DeOsNDyn9PypsZstRyp/LYMoKrMaMe /SDYUkvJnNRa9nt1LIVQFBLeUR9Sr7uBthWxicfLPaJhLPlSk+xpWCbi/xgRGAH5Bq 0hlTpkAaQtlOw== From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Parav Pandit , linux-rdma@vger.kernel.org Subject: [PATCH rdma-next 1/3] RDMA/cma: Skip device which doesn't support CM Date: Sun, 18 Apr 2021 16:55:52 +0300 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Parav Pandit A switchdev RDMA device do not support IB CM. When such device is added to the RDMA CM's device list, when application invokes rdma_listen(), cma attempts to listen to such device, however it has IB CM attribute disabled . Due to this, rdma_listen() call fails to listen for other non switchdev devices as well. A below error message can be seen. infiniband mlx5_0: RDMA CMA: cma_listen_on_dev, error -38 A failing call flow is below. rdma_listen() cma_listen_on_all() cma_listen_on_dev() _cma_attach_to_dev() rdma_listen() <- fails on a specific switchdev device Hence, when a IB device doesn't support IB CM or IW CM, avoid adding such device to the cma list. Signed-off-by: Parav Pandit Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/cma.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index bb7bd024f3bd..2dc302a83014 100644 --- a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c @@ -4900,6 +4900,17 @@ static void cma_process_remove(struct cma_device *cma_dev) wait_for_completion(&cma_dev->comp); } +static bool cma_supported(struct ib_device *device) +{ + u32 i; + + rdma_for_each_port(device, i) { + if (rdma_cap_ib_cm(device, i) || rdma_cap_iw_cm(device, i)) + return true; + } + return false; +} + static int cma_add_one(struct ib_device *device) { struct rdma_id_private *to_destroy; @@ -4909,6 +4920,9 @@ static int cma_add_one(struct ib_device *device) int ret; u32 i; + if (!cma_supported(device)) + return -EOPNOTSUPP; + cma_dev = kmalloc(sizeof(*cma_dev), GFP_KERNEL); if (!cma_dev) return -ENOMEM;