From patchwork Sun Apr 3 18:37:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12799721 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42498C43219 for ; Sun, 3 Apr 2022 18:38:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359782AbiDCSkL (ORCPT ); Sun, 3 Apr 2022 14:40:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359781AbiDCSkK (ORCPT ); Sun, 3 Apr 2022 14:40:10 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8033A3981C for ; Sun, 3 Apr 2022 11:38:14 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id u3so11436785wrg.3 for ; Sun, 03 Apr 2022 11:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Kxqaf3TiGle251IHR+W8OduAC7eH2bI0V+n//ywc2q0=; b=bej3OVicq9DY5TCT2cI7ey2WWKHYhcAr7fhv3UuCFjeGcXJDDZTPWVq+EayQy9ze12 jsEJnM6dsX0e3QzWXu25VHBqZTCdemUTJrbw0NAz0wCSFTAUnwvw5m+Yg8biTjM1fr2D SpB0ymL0QHm5n1bmwUM5+H/hvJWZYZlkCgg3zD+w7DZqRmwq0owPfCCF3w7JOAbk6ifR 8sKN0GxNXwv2GvF3rSb/IOc+QtRscLK3JSaZCuJxZ5CjJ8rAAI9khU2fNh2Ss9Po5phb ABV1QhFL97r6UF4ZMkWT5RdCcO0kLq7mq2cLL8xalHjs+1tWdeOhGzyGG9twdTsBXm6a T4wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Kxqaf3TiGle251IHR+W8OduAC7eH2bI0V+n//ywc2q0=; b=Ns926C0qTNZOe9ZfZ7vBJpJ/F2yFdVmf5L+dfIfdzYP3gq7UeL2qAHjvnRzJpKj0rH nJcxtK9EhaEUa7Uk4H1Qrbs3I+qjO8KvhKMSHjXqjQvNaVIMhZabmWXWI/Dneim7bFg2 gmtrCWSJPGgmsVk+zqdveaP6NslaIbHxoH1NZ2UOoCSK6EpDZiRwxz116ftVrOHJIAHB GWEldTlusj0cQnkFjsO/T2ngN9zqm0iymhzhkUen7/7gpGAQuXAK6afFAOVrjdwqi/vm NTPy8jwojjEpyUzWeVOlFyCt22DEn+zZdjEioLNtYKize0hl3UFjwlPZUkPcenS/M2Sn RdXA== X-Gm-Message-State: AOAM530u+XLv1flXFSwst6vUnmsz3TuDH2q+DZLmWQAp3w3wDuqLBj8s YEka7JVOGORhAVV5fBj59cRpYw== X-Google-Smtp-Source: ABdhPJzwOmkUD3wtuS6zRZWKpIbJ3MPBJRHjMlHTewzlbxOzA4pzE12JGAjPygYxkE6daXiIyTlumQ== X-Received: by 2002:adf:df05:0:b0:206:d4a:a6ba with SMTP id y5-20020adfdf05000000b002060d4aa6bamr2949367wrl.302.1649011092845; Sun, 03 Apr 2022 11:38:12 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id l28-20020a05600c1d1c00b0038e72a95ec4sm593851wms.13.2022.04.03.11.38.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Apr 2022 11:38:12 -0700 (PDT) From: Krzysztof Kozlowski To: Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: Stuart Yoder , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds , Rasmus Villemoes , Andy Shevchenko , Krzysztof Kozlowski Subject: [PATCH v6 00/12] Fix broken usage of driver_override (and kfree of static memory) Date: Sun, 3 Apr 2022 20:37:46 +0200 Message-Id: <20220403183758.192236-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Hi, This is a continuation of my old patchset from 2019. [1] Back then, few drivers set driver_override wrong. I fixed Exynos in a different way after discussions. QCOM NGD was not fixed and a new user appeared - IMX SCU. It seems "char *" in driver_override looks too consty, so we tend to make a mistake of storing there string literals. Changes since latest v6 ======================= 1. Patch #1: Don't check for !dev and handle len==0 (Andy). 2. New patch #11 (rpmsg): split constifying of local variable to a new patch. Changes since latest v5 ======================= 1. Patch 11 (rpmsg): split from previous patch 11 - easier to understand the need of it. 2. Fix build issue in patch 12 (rpmsg). Changes since latest v4 ======================= 1. Correct commit msgs and comments after Andy's review. 2. Re-order code in new helper (patch #1) (Andy). 3. Add tags. Changes since latest v3 ======================= 1. Wrap comments, extend comment in driver_set_override() about newline. 2. Minor commit msg fixes. 3. Add tags. Changes since latest v2 ======================= 1. Make all driver_override fields as "const char *", just like SPI and VDPA. (Mark) 2. Move "count" check to the new helper and add "count" argument. (Michael) 3. Fix typos in docs, patch subject. Extend doc. (Michael, Bjorn) 4. Compare pointers to reduce number of string readings in the helper. 5. Fix clk-imx return value. Changes since latest v1 (not the old 2019 solution): ==================================================== https://lore.kernel.org/all/708eabb1-7b35-d525-d4c3-451d4a3de84f@rasmusvillemoes.dk/ 1. Add helper for setting driver_override. 2. Use the helper. Dependencies (and stable): ========================== 1. All patches, including last three fixes, depend on the first patch introducing the helper. 2. The last three commits - fixes - are probably not backportable directly, because of this dependency. I don't know how to express this dependency here, since stable-kernel-rules.rst mentions only commits as possible dependencies. [1] https://lore.kernel.org/all/1550484960-2392-3-git-send-email-krzk@kernel.org/ Best regards, Krzysztof Krzysztof Kozlowski (12): driver: platform: Add helper for safer setting of driver_override amba: Use driver_set_override() instead of open-coding fsl-mc: Use driver_set_override() instead of open-coding hv: Use driver_set_override() instead of open-coding PCI: Use driver_set_override() instead of open-coding s390/cio: Use driver_set_override() instead of open-coding spi: Use helper for safer setting of driver_override vdpa: Use helper for safer setting of driver_override clk: imx: scu: Fix kfree() of static memory on setting driver_override slimbus: qcom-ngd: Fix kfree() of static memory on setting driver_override rpmsg: Constify local variable in field store macro rpmsg: Fix kfree() of static memory on setting driver_override drivers/amba/bus.c | 28 ++------------ drivers/base/driver.c | 65 +++++++++++++++++++++++++++++++++ drivers/base/platform.c | 28 ++------------ drivers/bus/fsl-mc/fsl-mc-bus.c | 25 ++----------- drivers/clk/imx/clk-scu.c | 7 +++- drivers/hv/vmbus_drv.c | 28 ++------------ drivers/pci/pci-sysfs.c | 28 ++------------ drivers/rpmsg/rpmsg_core.c | 3 +- drivers/rpmsg/rpmsg_internal.h | 13 ++++++- drivers/rpmsg/rpmsg_ns.c | 14 ++++++- drivers/s390/cio/cio.h | 6 ++- drivers/s390/cio/css.c | 28 ++------------ drivers/slimbus/qcom-ngd-ctrl.c | 13 ++++++- drivers/spi/spi.c | 26 ++----------- drivers/vdpa/vdpa.c | 29 ++------------- include/linux/amba/bus.h | 6 ++- include/linux/device/driver.h | 2 + include/linux/fsl/mc.h | 6 ++- include/linux/hyperv.h | 6 ++- include/linux/pci.h | 6 ++- include/linux/platform_device.h | 6 ++- include/linux/rpmsg.h | 6 ++- include/linux/spi/spi.h | 2 + include/linux/vdpa.h | 4 +- 24 files changed, 180 insertions(+), 205 deletions(-)