diff mbox

[v3,11/20] remoteproc: core: Correction carveout name comparison in rproc_update_resource_table_entry

Message ID 1476288038-24909-12-git-send-email-loic.pallardy@st.com (mailing list archive)
State Superseded
Headers show

Commit Message

Loic PALLARDY Oct. 12, 2016, 4 p.m. UTC
As old and new carveout name length may be different and the two
names may have a common part, name comparison must cover the complete
name field.
Limit strncmp to carveout name length, i.e. 32 Bytes.

Signed-off-by: Loic Pallardy <loic.pallardy@st.com>
 drivers/remoteproc/remoteproc_core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff mbox


diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 4a61dc1..96692c2 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -956,8 +956,7 @@  static int rproc_update_resource_table_entry(struct rproc *rproc,
 			tblc = rsc;
 			newc = request->resource;
-			if (strncmp(newc->name, tblc->name,
-				    sizeof(*tblc->name)))
+			if (strncmp(newc->name, tblc->name, 32))
 			memcpy(tblc, newc, request->size);