| Message ID | 1496403382-32374-1-git-send-email-henri.roosen@ginzinger.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 06/02/2017 06:36 AM, Henri Roosen wrote: > Trivial cleanup: the .ops pointer is assigned twice. This patch removes the > first assignment. > > Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com> Acked-by: Suman Anna <s-anna@ti.com> > --- > drivers/rpmsg/virtio_rpmsg_bus.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index 3c582f2..35b8379 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp, > /* Link the channel to our vrp */ > vch->vrp = vrp; > > - /* Assign callbacks for rpmsg_channel */ > - vch->rpdev.ops = &virtio_rpmsg_ops; > - > /* Assign public information to the rpmsg_device */ > rpdev = &vch->rpdev; > rpdev->src = chinfo->src; > -- To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri 02 Jun 04:36 PDT 2017, Henri Roosen wrote: > Trivial cleanup: the .ops pointer is assigned twice. This patch removes the > first assignment. > > Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com> Applied, thanks > --- > drivers/rpmsg/virtio_rpmsg_bus.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index 3c582f2..35b8379 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp, > /* Link the channel to our vrp */ > vch->vrp = vrp; > > - /* Assign callbacks for rpmsg_channel */ > - vch->rpdev.ops = &virtio_rpmsg_ops; > - > /* Assign public information to the rpmsg_device */ > rpdev = &vch->rpdev; > rpdev->src = chinfo->src; > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c index 3c582f2..35b8379 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp, /* Link the channel to our vrp */ vch->vrp = vrp; - /* Assign callbacks for rpmsg_channel */ - vch->rpdev.ops = &virtio_rpmsg_ops; - /* Assign public information to the rpmsg_device */ rpdev = &vch->rpdev; rpdev->src = chinfo->src;
Trivial cleanup: the .ops pointer is assigned twice. This patch removes the first assignment. Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com> --- drivers/rpmsg/virtio_rpmsg_bus.c | 3 --- 1 file changed, 3 deletions(-)