diff mbox

[v2,06/20] rpmsg: glink: Return -EAGAIN when there is no FIFO space

Message ID 1503559302-3744-7-git-send-email-sricharan@codeaurora.org (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Sricharan Ramabadhran Aug. 24, 2017, 7:21 a.m. UTC
The TX FIFO can be full, if the remote client has
not read enough data (or) reading it slowly. So its
nessecary to return -EAGAIN to the local client to
enable retry.

Signed-off-by: Sricharan R <sricharan@codeaurora.org>
---
 drivers/rpmsg/qcom_glink_native.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arun Kumar Neelakantam Aug. 28, 2017, 11:47 a.m. UTC | #1
On 8/24/2017 12:51 PM, Sricharan R wrote:
> The TX FIFO can be full, if the remote client has
> not read enough data (or) reading it slowly. So its
> nessecary to return -EAGAIN to the local client to
> enable retry.
>
> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
Acked-by: Arun Kumar Neelakantam <aneela@codeaurora.org>

Regards,
Arun N
> ---
>   drivers/rpmsg/qcom_glink_native.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
> index a6394cd..94b79e8 100644
> --- a/drivers/rpmsg/qcom_glink_native.c
> +++ b/drivers/rpmsg/qcom_glink_native.c
> @@ -233,7 +233,7 @@ static int qcom_glink_tx(struct qcom_glink *glink,
>   
>   	while (qcom_glink_tx_avail(glink) < tlen) {
>   		if (!wait) {
> -			ret = -ENOMEM;
> +			ret = -EAGAIN;
>   			goto out;
>   		}
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index a6394cd..94b79e8 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -233,7 +233,7 @@  static int qcom_glink_tx(struct qcom_glink *glink,
 
 	while (qcom_glink_tx_avail(glink) < tlen) {
 		if (!wait) {
-			ret = -ENOMEM;
+			ret = -EAGAIN;
 			goto out;
 		}