diff mbox series

remoteproc/mediatek: Fix kernel test robot warning

Message ID 1606513855-21130-1-git-send-email-jrdr.linux@gmail.com (mailing list archive)
State Accepted
Commit 8c09e5fdf31b5d1bc01d800158f71c22e5e04578
Headers show
Series remoteproc/mediatek: Fix kernel test robot warning | expand

Commit Message

Souptick Joarder Nov. 27, 2020, 9:50 p.m. UTC 
Kernel test robot throws below warning ->

>> drivers/remoteproc/mtk_scp.c:755:37: warning: unused variable
>> 'mt8183_of_data' [-Wunused-const-variable]
   static const struct mtk_scp_of_data mt8183_of_data = {
                                       ^
>> drivers/remoteproc/mtk_scp.c:765:37: warning: unused variable
>> 'mt8192_of_data' [-Wunused-const-variable]
   static const struct mtk_scp_of_data mt8192_of_data = {
                                       ^
As suggested by Bjorn, there's no harm in just dropping the
of_match_ptr() wrapping of mtk_scp_of_match in the definition of
mtk_scp_driver and we avoid this whole problem.

Reported-by: kernel test robot <lkp@intel.com>
Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 drivers/remoteproc/mtk_scp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

patchwork-bot+linux-remoteproc@kernel.org Nov. 28, 2020, 3:40 a.m. UTC | #1 
Hello:

This patch was applied to andersson/remoteproc.git (refs/heads/for-next):

On Sat, 28 Nov 2020 03:20:55 +0530 you wrote:
> Kernel test robot throws below warning ->
> 
> >> drivers/remoteproc/mtk_scp.c:755:37: warning: unused variable
> >> 'mt8183_of_data' [-Wunused-const-variable]
>    static const struct mtk_scp_of_data mt8183_of_data = {
>                                        ^
> >> drivers/remoteproc/mtk_scp.c:765:37: warning: unused variable
> >> 'mt8192_of_data' [-Wunused-const-variable]
>    static const struct mtk_scp_of_data mt8192_of_data = {
>                                        ^
> As suggested by Bjorn, there's no harm in just dropping the
> of_match_ptr() wrapping of mtk_scp_of_match in the definition of
> mtk_scp_driver and we avoid this whole problem.
> 
> [...]

Here is the summary with links:
  - remoteproc/mediatek: Fix kernel test robot warning
    https://git.kernel.org/andersson/remoteproc/c/8c09e5fdf31b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
index 7e0f1e1..5f42b9c 100644
--- a/drivers/remoteproc/mtk_scp.c
+++ b/drivers/remoteproc/mtk_scp.c
@@ -772,21 +772,19 @@  static int scp_remove(struct platform_device *pdev)
 	.host_to_scp_int_bit = MT8192_HOST_IPC_INT_BIT,
 };
 
-#if defined(CONFIG_OF)
 static const struct of_device_id mtk_scp_of_match[] = {
 	{ .compatible = "mediatek,mt8183-scp", .data = &mt8183_of_data },
 	{ .compatible = "mediatek,mt8192-scp", .data = &mt8192_of_data },
 	{},
 };
 MODULE_DEVICE_TABLE(of, mtk_scp_of_match);
-#endif
 
 static struct platform_driver mtk_scp_driver = {
 	.probe = scp_probe,
 	.remove = scp_remove,
 	.driver = {
 		.name = "mtk-scp",
-		.of_match_table = of_match_ptr(mtk_scp_of_match),
+		.of_match_table = mtk_scp_of_match,
 	},
 };