diff mbox series

[v2] remoteproc: sysfs: Use sysfs_emit instead of sprintf

Message ID 1614808022-26062-1-git-send-email-sidgup@codeaurora.org (mailing list archive)
State Accepted
Commit 145e1da374bcba14c9ca069646f68b76c422612a
Headers show
Series [v2] remoteproc: sysfs: Use sysfs_emit instead of sprintf | expand

Commit Message

Siddharth Gupta March 3, 2021, 9:47 p.m. UTC 
From: Raghavendra Rao Ananta <rananta@codeaurora.org>

For security reasons sysfs_emit() is preferred over sprintf().
Hence, convert the remoteproc's sysfs show functions accordingly.

Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>
Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
---
 drivers/remoteproc/remoteproc_sysfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

patchwork-bot+linux-remoteproc@kernel.org March 11, 2021, 11:32 p.m. UTC | #1 
Hello:

This patch was applied to andersson/remoteproc.git (refs/heads/for-next):

On Wed,  3 Mar 2021 13:47:02 -0800 you wrote:
> From: Raghavendra Rao Ananta <rananta@codeaurora.org>
> 
> For security reasons sysfs_emit() is preferred over sprintf().
> Hence, convert the remoteproc's sysfs show functions accordingly.
> 
> Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>
> Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
> 
> [...]

Here is the summary with links:
  - [v2] remoteproc: sysfs: Use sysfs_emit instead of sprintf
    https://git.kernel.org/andersson/remoteproc/c/145e1da374bc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c
index 1dbef89..6840dad 100644
--- a/drivers/remoteproc/remoteproc_sysfs.c
+++ b/drivers/remoteproc/remoteproc_sysfs.c
@@ -15,7 +15,7 @@  static ssize_t recovery_show(struct device *dev,
 {
 	struct rproc *rproc = to_rproc(dev);
 
-	return sprintf(buf, "%s", rproc->recovery_disabled ? "disabled\n" : "enabled\n");
+	return sysfs_emit(buf, "%s", rproc->recovery_disabled ? "disabled\n" : "enabled\n");
 }
 
 /*
@@ -82,7 +82,7 @@  static ssize_t coredump_show(struct device *dev,
 {
 	struct rproc *rproc = to_rproc(dev);
 
-	return sprintf(buf, "%s\n", rproc_coredump_str[rproc->dump_conf]);
+	return sysfs_emit(buf, "%s\n", rproc_coredump_str[rproc->dump_conf]);
 }
 
 /*