From patchwork Fri Mar 23 09:36:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 10303133 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EB0DB60386 for ; Fri, 23 Mar 2018 09:38:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DAD5A28952 for ; Fri, 23 Mar 2018 09:38:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CEEAD28BF7; Fri, 23 Mar 2018 09:38:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2FEE928952 for ; Fri, 23 Mar 2018 09:38:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751861AbeCWJil (ORCPT ); Fri, 23 Mar 2018 05:38:41 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:53059 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847AbeCWJgR (ORCPT ); Fri, 23 Mar 2018 05:36:17 -0400 Received: by mail-wm0-f67.google.com with SMTP id l9so2346238wmh.2 for ; Fri, 23 Mar 2018 02:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Q1G+VWjRAg8MmH0POYq0VvvthGxnpZtMQzOyxoKM1dU=; b=NP9yKh1tb6Mfq6JxfUmYy553UMPmmRbRcw9C7bm6jp6+4pNoeIjS+TBOfEolvQxp6a 6e2TOLxLU0oWf8L6trlsoH3AwKULcQ7og/Fad0jGsY95BNw5890imJpN6cre3bTKOiqa SM0jdSb1mi7otEDpCJMbbKJzm5ixLydUs8uKb0ZhvaCArvE0ddiKMIkVGlnZGSeTGEYS jHLjJarjLdlf3HXthC+PKHeA7sXo/KJgszi20JvIyuLMnRjJOTQrhP5NW8Qhggb7TWpK yxBYqmdmEX/Pm7D56lvT/XChwV+45bebL6Qmg6MM3SeCyzIqnvdGRcxaUJZG0zjalcI0 iBlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Q1G+VWjRAg8MmH0POYq0VvvthGxnpZtMQzOyxoKM1dU=; b=VT8oZb0UwlBAhgRz8zhfsp5xhMbnQ8Z4ntOW9rgjg3Ls+aTkgkhO3xquzdYMkVWmZs H93wxLhGiDKqNgfm8azx2Ghx6X419bZBuXe7dsZi3vIzMFnaxqafskE2XEUHYF7nHF8J MiVCBorYEwYrWj+KtubIFimpNYAieRMz8rrU4vJSJh2QhwuvEqFyL4xPoB6cVWmy17Zr HZjXocVlR/qKw7eZaTzf079z0UORrTqA3Bmfy+Zjapf6JzWrHd3GIR89DPMZ+Iv0TMkZ clJWn6jONPHHkDjhVKWrQz5wESFDYMxz1c1oRuP1+5hh3uxnTvU+lAmXz4uWsQ7kNFY1 +G2Q== X-Gm-Message-State: AElRT7GFFE2lBdh1vomyLfiCxX37EDVnhsDEgSl04qaDfKBAPYpada8P JOGcm4kv6V0pGmQbZw3F4AlQpg== X-Google-Smtp-Source: AG47ELvljEfaunVqgoY9OiK9p0haQ8aiRvH84WmbF3fSqCG/4VyvNWA3g7el8StSbPNq7iCr3N39yg== X-Received: by 10.28.174.11 with SMTP id x11mr7990924wme.124.1521797775751; Fri, 23 Mar 2018 02:36:15 -0700 (PDT) Received: from brgl-bgdev.lan (LFbn-NIC-1-208-99.w2-15.abo.wanadoo.fr. [2.15.55.99]) by smtp.gmail.com with ESMTPSA id s125sm8045203wmf.4.2018.03.23.02.36.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Mar 2018 02:36:14 -0700 (PDT) From: Bartosz Golaszewski To: Sekhar Nori , Kevin Hilman , Rob Herring , Mark Rutland , Russell King , David Lechner , Michael Turquette , Stephen Boyd , Ohad Ben-Cohen , Bjorn Andersson , Philipp Zabel Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-remoteproc@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v2 1/8] reset: modify the way reset lookup works for board files Date: Fri, 23 Mar 2018 10:36:02 +0100 Message-Id: <20180323093609.24576-2-brgl@bgdev.pl> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180323093609.24576-1-brgl@bgdev.pl> References: <20180323093609.24576-1-brgl@bgdev.pl> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Bartosz Golaszewski Commit 7af1bb19f1d7 ("reset: add support for non-DT systems") introduced reset control lookup mechanism for boards that still use board files. The routine used to register lookup entries takes the corresponding reset_controlled_dev structure as argument. It's been determined however that for the first user of this new interface - davinci psc driver - it will be easier to register the lookup entries using the reset controller device name. This patch changes the way lookup entries are added. Signed-off-by: Bartosz Golaszewski --- drivers/reset/core.c | 33 +++++++++++++++++++++++++++++---- include/linux/reset-controller.h | 8 +++++--- 2 files changed, 34 insertions(+), 7 deletions(-) diff --git a/drivers/reset/core.c b/drivers/reset/core.c index 06fa4907afc4..f37048e55336 100644 --- a/drivers/reset/core.c +++ b/drivers/reset/core.c @@ -153,11 +153,11 @@ EXPORT_SYMBOL_GPL(devm_reset_controller_register); /** * reset_controller_add_lookup - register a set of lookup entries - * @rcdev: initialized reset controller device owning the reset line + * @provider: name of the reset controller provider * @lookup: array of reset lookup entries * @num_entries: number of entries in the lookup array */ -void reset_controller_add_lookup(struct reset_controller_dev *rcdev, +void reset_controller_add_lookup(const char *provider, struct reset_control_lookup *lookup, unsigned int num_entries) { @@ -174,7 +174,7 @@ void reset_controller_add_lookup(struct reset_controller_dev *rcdev, continue; } - entry->rcdev = rcdev; + entry->provider = provider; list_add_tail(&entry->list, &reset_lookup_list); } mutex_unlock(&reset_lookup_mutex); @@ -526,11 +526,30 @@ struct reset_control *__of_reset_control_get(struct device_node *node, } EXPORT_SYMBOL_GPL(__of_reset_control_get); +static struct reset_controller_dev * +__reset_controller_by_name(const char *name) +{ + struct reset_controller_dev *rcdev; + + lockdep_assert_held(&reset_list_mutex); + + list_for_each_entry(rcdev, &reset_controller_list, list) { + if (!rcdev->dev) + continue; + + if (!strcmp(name, dev_name(rcdev->dev))) + return rcdev; + } + + return NULL; +} + static struct reset_control * __reset_control_get_from_lookup(struct device *dev, const char *con_id, bool shared, bool optional) { const struct reset_control_lookup *lookup; + struct reset_controller_dev *rcdev; const char *dev_id = dev_name(dev); struct reset_control *rstc = NULL; @@ -547,7 +566,13 @@ __reset_control_get_from_lookup(struct device *dev, const char *con_id, ((con_id && lookup->con_id) && !strcmp(con_id, lookup->con_id))) { mutex_lock(&reset_list_mutex); - rstc = __reset_control_get_internal(lookup->rcdev, + rcdev = __reset_controller_by_name(lookup->provider); + if (!rcdev) { + mutex_unlock(&reset_list_mutex); + continue; + } + + rstc = __reset_control_get_internal(rcdev, lookup->index, shared); mutex_unlock(&reset_list_mutex); diff --git a/include/linux/reset-controller.h b/include/linux/reset-controller.h index 25698f6c1fae..1a6c25d825d3 100644 --- a/include/linux/reset-controller.h +++ b/include/linux/reset-controller.h @@ -30,14 +30,14 @@ struct of_phandle_args; * struct reset_control_lookup - represents a single lookup entry * * @list: internal list of all reset lookup entries - * @rcdev: reset controller device controlling this reset line + * @provider: name of the reset controller device controlling this reset line * @index: ID of the reset controller in the reset controller device * @dev_id: name of the device associated with this reset line * @con_id name of the reset line (can be NULL) */ struct reset_control_lookup { struct list_head list; - struct reset_controller_dev *rcdev; + const char *provider; unsigned int index; const char *dev_id; const char *con_id; @@ -57,6 +57,7 @@ struct reset_control_lookup { * @owner: kernel module of the reset controller driver * @list: internal list of reset controller devices * @reset_control_head: head of internal list of requested reset controls + * @dev: corresponding driver model device struct * @of_node: corresponding device tree node as phandle target * @of_reset_n_cells: number of cells in reset line specifiers * @of_xlate: translation function to translate from specifier as found in the @@ -68,6 +69,7 @@ struct reset_controller_dev { struct module *owner; struct list_head list; struct list_head reset_control_head; + struct device *dev; struct device_node *of_node; int of_reset_n_cells; int (*of_xlate)(struct reset_controller_dev *rcdev, @@ -82,7 +84,7 @@ struct device; int devm_reset_controller_register(struct device *dev, struct reset_controller_dev *rcdev); -void reset_controller_add_lookup(struct reset_controller_dev *rcdev, +void reset_controller_add_lookup(const char *provider, struct reset_control_lookup *lookup, unsigned int num_entries);