From patchwork Mon Jan 7 11:38:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pi-Hsun Shih X-Patchwork-Id: 10750371 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ABB3091E for ; Mon, 7 Jan 2019 11:38:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 95A652896D for ; Mon, 7 Jan 2019 11:38:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8825B2889E; Mon, 7 Jan 2019 11:38:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2D0932624D for ; Mon, 7 Jan 2019 11:38:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727164AbfAGLip (ORCPT ); Mon, 7 Jan 2019 06:38:45 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:44397 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726893AbfAGLip (ORCPT ); Mon, 7 Jan 2019 06:38:45 -0500 Received: by mail-pl1-f195.google.com with SMTP id e11so12210plt.11 for ; Mon, 07 Jan 2019 03:38:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ePJe8cVSRqtlaGA7V9EgMDTzK24IvCXYylFk83HfJes=; b=CdBHya0xIV2o7rasb5t+gJ++qxMpDpd9XQOHA4HVSq2yhLq1m3OKjDgFWqproXlg2B 57Dozefo2H/3agSacTurbXzfemDjZSNVS27uIumyFWd/OSpyPcq/YLbutddlsan4dOgf A88dn/pmXnqA3BNlDUmkhps6E4PBlyiSLxS/w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ePJe8cVSRqtlaGA7V9EgMDTzK24IvCXYylFk83HfJes=; b=fDBZTFNu79Ss7OTP6JWJB/NxA7sgFvS64v8ZIbFnNNk0vNXJ43oOYctQV7SC2TBNOu g/EwhAx61b7lYa8Zqi/lBPxlxZwvoWAurjIDHKIOTzv/ihU7PIMdAwEPaljS52pUUu3t oSq8PRca35XPmouSoViTZs+Lrpj24m7Milf8peqQqtuAn74dPEWJgc/FxsrHPSnk6uF4 Ch0RHAU4ev8l0mVeFVQex1627ppoKh2aKglFkG+JrjfklG4UeyMLgSj2rIZ46F/dbDIH AW4W+qozR1UqVkeuXlk+PqfkHvCAdxC+KZ4SNi6mUmn+etAaKwe+bJkZz7hDFomxYb4F dCjA== X-Gm-Message-State: AJcUukd3yVdH7LXG//VOkltUdKCI+/Z7iyr7Bhv0nmKd5qRqGqtJS2LW OZWDYyzxXYcynbjLYFjDvQWVSQ== X-Google-Smtp-Source: ALg8bN4X15OWjP5RmXnsZlO2WWFXs1xpmK/dF6kMe3mQa8vwxbBbhyx7nPAgh/ASeVp2+Mf4V9P9kA== X-Received: by 2002:a17:902:20b:: with SMTP id 11mr61093325plc.57.1546861123595; Mon, 07 Jan 2019 03:38:43 -0800 (PST) Received: from pihsun-z840.tpe.corp.google.com ([2401:fa00:1:10:7889:7a43:f899:134c]) by smtp.googlemail.com with ESMTPSA id m3sm109338783pff.173.2019.01.07.03.38.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Jan 2019 03:38:42 -0800 (PST) From: Pi-Hsun Shih Cc: Pi-Hsun Shih , Ohad Ben-Cohen , Bjorn Andersson , linux-remoteproc@vger.kernel.org (open list:REMOTE PROCESSOR MESSAGING (RPMSG) SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] rpmsg: core: Make remove handler for rpmsg driver optional. Date: Mon, 7 Jan 2019 19:38:32 +0800 Message-Id: <20190107113833.243672-1-pihsun@chromium.org> X-Mailer: git-send-email 2.20.1.97.g81188d93c3-goog MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Most other bus (for example, SPI, i2c) have the remove handler for driver optional. Make remove handler for rpmsg driver optional too. Signed-off-by: Pi-Hsun Shih --- drivers/rpmsg/rpmsg_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index 8122807db38094..ea88fd4e2a6ecf 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -493,7 +493,8 @@ static int rpmsg_dev_remove(struct device *dev) if (rpdev->ops->announce_destroy) err = rpdev->ops->announce_destroy(rpdev); - rpdrv->remove(rpdev); + if (rpdrv->remove) + rpdrv->remove(rpdev); dev_pm_domain_detach(dev, true);