Message ID | 20191008120018.12439-1-colin.king@canonical.com (mailing list archive) |
---|---|
State | Mainlined |
Commit | bbe692e349e2a1edf3fe0a29a0e05899c9c94d51 |
Headers | show |
Series | rpmsg: char: fix resource leak on kbuf on copy_from_iter_full failure | expand |
diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 507bfe163883..7db28643db43 100644 --- a/drivers/rpmsg/rpmsg_char.c +++ b/drivers/rpmsg/rpmsg_char.c @@ -227,8 +227,10 @@ static ssize_t rpmsg_eptdev_write_iter(struct kiocb *iocb, if (!kbuf) return -ENOMEM; - if (!copy_from_iter_full(kbuf, len, from)) - return -EFAULT; + if (!copy_from_iter_full(kbuf, len, from)) { + ret = -EFAULT; + goto free_kbuf; + } if (mutex_lock_interruptible(&eptdev->ept_lock)) { ret = -ERESTARTSYS;