| Message ID | 20200509084237.36293-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 8096f80a5c09b716be207eb042c4e40d6cdefbd2 |
| Headers | show |
| Series | [-next] remoteproc/mediatek: fix invalid use of sizeof in scp_ipi_init() | expand |
On Sat, 9 May 2020 at 02:38, Wei Yongjun <weiyongjun1@huawei.com> wrote: > > sizeof() when applied to a pointer typed expression gives the > size of the pointer, not that of the pointed data. > > Fixes: 63c13d61eafe ("remoteproc/mediatek: add SCP support for mt8183") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/remoteproc/mtk_scp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 2bead57c9cf9..ac13e7b046a6 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -132,8 +132,8 @@ static int scp_ipi_init(struct mtk_scp *scp) > (struct mtk_share_obj __iomem *)(scp->sram_base + recv_offset); > scp->send_buf = > (struct mtk_share_obj __iomem *)(scp->sram_base + send_offset); > - memset_io(scp->recv_buf, 0, sizeof(scp->recv_buf)); > - memset_io(scp->send_buf, 0, sizeof(scp->send_buf)); > + memset_io(scp->recv_buf, 0, sizeof(*scp->recv_buf)); > + memset_io(scp->send_buf, 0, sizeof(*scp->send_buf)); Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > return 0; > } > > >
Hello: This patch was applied to andersson/remoteproc.git (refs/heads/for-next). On Sat, 9 May 2020 08:42:37 +0000 you wrote: > sizeof() when applied to a pointer typed expression gives the > size of the pointer, not that of the pointed data. > > Fixes: 63c13d61eafe ("remoteproc/mediatek: add SCP support for mt8183") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > > [...] Here is a summary with links: - [-next] remoteproc/mediatek: fix invalid use of sizeof in scp_ipi_init() https://git.kernel.org/andersson/remoteproc/c/8096f80a5c09b716be207eb042c4e40d6cdefbd2 You are awesome, thank you!
diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c index 2bead57c9cf9..ac13e7b046a6 100644 --- a/drivers/remoteproc/mtk_scp.c +++ b/drivers/remoteproc/mtk_scp.c @@ -132,8 +132,8 @@ static int scp_ipi_init(struct mtk_scp *scp) (struct mtk_share_obj __iomem *)(scp->sram_base + recv_offset); scp->send_buf = (struct mtk_share_obj __iomem *)(scp->sram_base + send_offset); - memset_io(scp->recv_buf, 0, sizeof(scp->recv_buf)); - memset_io(scp->send_buf, 0, sizeof(scp->send_buf)); + memset_io(scp->recv_buf, 0, sizeof(*scp->recv_buf)); + memset_io(scp->send_buf, 0, sizeof(*scp->send_buf)); return 0; }
sizeof() when applied to a pointer typed expression gives the size of the pointer, not that of the pointed data. Fixes: 63c13d61eafe ("remoteproc/mediatek: add SCP support for mt8183") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/remoteproc/mtk_scp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)