diff mbox series

[v6,04/11] remoteproc: stm32: Remove memory translation from DT parsing

Message ID 20200714200445.1427257-5-mathieu.poirier@linaro.org
State Mainlined
Commit 95e32f868aa67cb0d581ca8ced456dc2fac5edf7
Headers show
Series remoteproc: stm32: Add support for attaching to M4 | expand

Commit Message

Mathieu Poirier July 14, 2020, 8:04 p.m. UTC
Other than one has to be done after the other, there is no correlation
between memory translation and DT parsing.  As such move function
stm32_rproc_of_memory_translations() to stm32_rproc_probe() so that
stm32_rproc_parse_dt() can be extended to look for attach bindings
in a clean way.

Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Loic Pallardy <loic.pallardy@st.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
 drivers/remoteproc/stm32_rproc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
index cbba995a80a2..986f34a336a7 100644
--- a/drivers/remoteproc/stm32_rproc.c
+++ b/drivers/remoteproc/stm32_rproc.c
@@ -607,7 +607,7 @@  static int stm32_rproc_parse_dt(struct platform_device *pdev,
 	*auto_boot = of_property_read_bool(np, "st,auto-boot");
-	return stm32_rproc_of_memory_translations(pdev, ddata);
+	return 0;
 static int stm32_rproc_probe(struct platform_device *pdev)
@@ -634,6 +634,10 @@  static int stm32_rproc_probe(struct platform_device *pdev)
 	if (ret)
 		goto free_rproc;
+	ret = stm32_rproc_of_memory_translations(pdev, ddata);
+	if (ret)
+		goto free_rproc;
 	rproc->has_iommu = false;
 	ddata->workqueue = create_workqueue(dev_name(dev));
 	if (!ddata->workqueue) {