| Message ID | 20200731114732.12815-3-arnaud.pouliquen@st.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | introduce name service announcement rpmsg driver | expand |
Hi Arnaud, On Fri, Jul 31, 2020 at 01:47:25PM +0200, Arnaud Pouliquen wrote: > Add the channel creation API as a first step to be able to define the > name service announcement as a rpmsg driver independent from the RPMsg > virtio bus. > > Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> > --- > drivers/rpmsg/rpmsg_core.c | 37 ++++++++++++++++++++++++++++++++++ > drivers/rpmsg/rpmsg_internal.h | 12 +++++++++++ > 2 files changed, 49 insertions(+) > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index a6361cad608b..ae7da4a2e528 100644 > --- a/drivers/rpmsg/rpmsg_core.c > +++ b/drivers/rpmsg/rpmsg_core.c > @@ -20,6 +20,43 @@ > > #include "rpmsg_internal.h" > > +/** > + * rpmsg_create_channel() - create a new rpmsg channel > + * using its name and address info. > + * @rpdev: rpmsg driver > + * @chinfo: channel_info to bind > + * > + * Returns a pointer to the new rpmsg device on success, or NULL on error. > + */ > +struct rpmsg_device * > + rpmsg_create_channel(struct rpmsg_device *rpdev, > + struct rpmsg_channel_info *chinfo) > +{ > + if (WARN_ON(!rpdev) || !rpdev->ops->create_channel) > + return NULL; Ok for the WARN_ON(). In another if(), I would check for ops and ops->create_channel(). Same for the release() operation. > + > + return rpdev->ops->create_channel(rpdev, chinfo); > +} > +EXPORT_SYMBOL(rpmsg_create_channel); > + > +/** > + * rpmsg_release_channel() - release a rpmsg channel > + * using its name and address info. > + * @rpdev: rpmsg driver > + * @chinfo: channel_info to bind > + * > + * Returns a pointer to the new rpmsg device on success, or NULL on error. > + */ > +int rpmsg_release_channel(struct rpmsg_device *rpdev, > + struct rpmsg_channel_info *chinfo) > +{ > + if (WARN_ON(!rpdev) || !rpdev->ops->release_channel) > + return 0; > + > + return rpdev->ops->release_channel(rpdev, chinfo); > +} > +EXPORT_SYMBOL(rpmsg_release_channel); > + > /** > * rpmsg_create_ept() - create a new rpmsg_endpoint > * @rpdev: rpmsg channel device > diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h > index 3fc83cd50e98..d5ab286d0e5e 100644 > --- a/drivers/rpmsg/rpmsg_internal.h > +++ b/drivers/rpmsg/rpmsg_internal.h > @@ -20,6 +20,8 @@ > > /** > * struct rpmsg_device_ops - indirection table for the rpmsg_device operations > + * @create_channel: create backend-specific channel, optional > + * @release_channel: release backend-specific channel, optional > * @create_ept: create backend-specific endpoint, required > * @announce_create: announce presence of new channel, optional > * @announce_destroy: announce destruction of channel, optional > @@ -29,6 +31,11 @@ > * advertise new channels implicitly by creating the endpoints. > */ > struct rpmsg_device_ops { > + struct rpmsg_device *(*create_channel)(struct rpmsg_device *rpdev, > + struct rpmsg_channel_info *chinfo); > + int (*release_channel)(struct rpmsg_device *rpdev, > + struct rpmsg_channel_info *chinfo); > + > struct rpmsg_endpoint *(*create_ept)(struct rpmsg_device *rpdev, > rpmsg_rx_cb_t cb, void *priv, > struct rpmsg_channel_info chinfo); > @@ -75,6 +82,11 @@ int rpmsg_unregister_device(struct device *parent, > struct device *rpmsg_find_device(struct device *parent, > struct rpmsg_channel_info *chinfo); > > +struct rpmsg_device * > + rpmsg_create_channel(struct rpmsg_device *rpdev, > + struct rpmsg_channel_info *chinfo); > +int rpmsg_release_channel(struct rpmsg_device *rpdev, > + struct rpmsg_channel_info *chinfo); > /** > * rpmsg_chrdev_register_device() - register chrdev device based on rpdev > * @rpdev: prepared rpdev to be used for creating endpoints > -- > 2.17.1 >
diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index a6361cad608b..ae7da4a2e528 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -20,6 +20,43 @@ #include "rpmsg_internal.h" +/** + * rpmsg_create_channel() - create a new rpmsg channel + * using its name and address info. + * @rpdev: rpmsg driver + * @chinfo: channel_info to bind + * + * Returns a pointer to the new rpmsg device on success, or NULL on error. + */ +struct rpmsg_device * + rpmsg_create_channel(struct rpmsg_device *rpdev, + struct rpmsg_channel_info *chinfo) +{ + if (WARN_ON(!rpdev) || !rpdev->ops->create_channel) + return NULL; + + return rpdev->ops->create_channel(rpdev, chinfo); +} +EXPORT_SYMBOL(rpmsg_create_channel); + +/** + * rpmsg_release_channel() - release a rpmsg channel + * using its name and address info. + * @rpdev: rpmsg driver + * @chinfo: channel_info to bind + * + * Returns a pointer to the new rpmsg device on success, or NULL on error. + */ +int rpmsg_release_channel(struct rpmsg_device *rpdev, + struct rpmsg_channel_info *chinfo) +{ + if (WARN_ON(!rpdev) || !rpdev->ops->release_channel) + return 0; + + return rpdev->ops->release_channel(rpdev, chinfo); +} +EXPORT_SYMBOL(rpmsg_release_channel); + /** * rpmsg_create_ept() - create a new rpmsg_endpoint * @rpdev: rpmsg channel device diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h index 3fc83cd50e98..d5ab286d0e5e 100644 --- a/drivers/rpmsg/rpmsg_internal.h +++ b/drivers/rpmsg/rpmsg_internal.h @@ -20,6 +20,8 @@ /** * struct rpmsg_device_ops - indirection table for the rpmsg_device operations + * @create_channel: create backend-specific channel, optional + * @release_channel: release backend-specific channel, optional * @create_ept: create backend-specific endpoint, required * @announce_create: announce presence of new channel, optional * @announce_destroy: announce destruction of channel, optional @@ -29,6 +31,11 @@ * advertise new channels implicitly by creating the endpoints. */ struct rpmsg_device_ops { + struct rpmsg_device *(*create_channel)(struct rpmsg_device *rpdev, + struct rpmsg_channel_info *chinfo); + int (*release_channel)(struct rpmsg_device *rpdev, + struct rpmsg_channel_info *chinfo); + struct rpmsg_endpoint *(*create_ept)(struct rpmsg_device *rpdev, rpmsg_rx_cb_t cb, void *priv, struct rpmsg_channel_info chinfo); @@ -75,6 +82,11 @@ int rpmsg_unregister_device(struct device *parent, struct device *rpmsg_find_device(struct device *parent, struct rpmsg_channel_info *chinfo); +struct rpmsg_device * + rpmsg_create_channel(struct rpmsg_device *rpdev, + struct rpmsg_channel_info *chinfo); +int rpmsg_release_channel(struct rpmsg_device *rpdev, + struct rpmsg_channel_info *chinfo); /** * rpmsg_chrdev_register_device() - register chrdev device based on rpdev * @rpdev: prepared rpdev to be used for creating endpoints
Add the channel creation API as a first step to be able to define the name service announcement as a rpmsg driver independent from the RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> --- drivers/rpmsg/rpmsg_core.c | 37 ++++++++++++++++++++++++++++++++++ drivers/rpmsg/rpmsg_internal.h | 12 +++++++++++ 2 files changed, 49 insertions(+)