remoteproc/mediatek: fix null pointer dereference on null scp pointer

Commit Message

Colin King Sept. 18, 2020, 3:24 p.m. UTC

From: Colin Ian King <[e-mail]>

Currently when pointer scp is null a dev_err is being called that
references the pointer which is the very thing we are trying to
avoid doing. Remove the extraneous error message to avoid this
issue.

Addresses-Coverity: ("Dereference after null check")
Fixes: 63c13d61eafe ("remoteproc/mediatek: add SCP support for mt8183")
Signed-off-by: Colin Ian King <[e-mail]>
---
 drivers/remoteproc/mtk_scp_ipi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

[e-mail] Oct. 14, 2020, 12:10 a.m. UTC | #1

Hello:

This patch was applied to andersson/remoteproc.git (refs/heads/for-next):

On Fri, 18 Sep 2020 16:24:28 +0100 you wrote:
> From: Colin Ian King <[e-mail]>
> 
> Currently when pointer scp is null a dev_err is being called that
> references the pointer which is the very thing we are trying to
> avoid doing. Remove the extraneous error message to avoid this
> issue.
> 
> [...]

Here is the summary with links:
  - remoteproc/mediatek: fix null pointer dereference on null scp pointer
    https://git.kernel.org/andersson/remoteproc/c/434ac4d51407

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Patch

diff --git a/drivers/remoteproc/mtk_scp_ipi.c b/drivers/remoteproc/mtk_scp_ipi.c
index 3d3d87210ef2..58d1d7e571d6 100644
--- a/drivers/remoteproc/mtk_scp_ipi.c
+++ b/drivers/remoteproc/mtk_scp_ipi.c
@@ -30,10 +30,8 @@  int scp_ipi_register(struct mtk_scp *scp,
 		     scp_ipi_handler_t handler,
 		     void *priv)
 {
-	if (!scp) {
-		dev_err(scp->dev, "scp device is not ready\n");
+	if (!scp)
 		return -EPROBE_DEFER;
-	}
 
 	if (WARN_ON(id >= SCP_IPI_MAX) || WARN_ON(handler == NULL))
 		return -EINVAL;